Received-SPF: pass (google.com: domain of linux-kernel+bounces-212996-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 13 Jun 2024 18:03:03 +0800
From: Crescent CY Hsieh <crescentcy.hsieh@moxa.com>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH 3/6] tty: mxser: serial: 8250: Relocate device IDs from
 mxser to 8250_pci
Message-ID: <ZmrD1wZGha9aC+Ri@localhost.localdomain>
References: <20240607114336.4496-1-crescentcy.hsieh@moxa.com>
 <20240607114336.4496-4-crescentcy.hsieh@moxa.com>
 <0d8da651-4e41-4af2-81cc-732f17aab403@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0d8da651-4e41-4af2-81cc-732f17aab403@kernel.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?2zTVc/1OaDe0h0WtLkN7kx2n5iwRHBG+8HlB+aSIT8EecQarftifTWax1dTQ?=
 =?us-ascii?Q?ELsstoNFHwkGizfNzikq2lLAvn+aw4tHMMVTInyCufcIcPxm/GMDQNPDlcme?=
 =?us-ascii?Q?/1ChfjU8C2HAtEbk8Kvtc1LHBRrdSEhDaH9xphixdRhr16z0d10ESdoSiIKQ?=
 =?us-ascii?Q?H65JjmZQO7Rmu72u48UJ2rHT34O5GMOwjTjqS+64XwmDIGeSrB4aL7brWvo5?=
 =?us-ascii?Q?48mBrk6fEKGQOor7XBk+KwM4vFCAVAzTRBQ3BioGO96pdvBk5HlYGtH7RNL+?=
 =?us-ascii?Q?jJwPqOWVIZ8U9L3OSLW+UNMEiK/FT5qGGinZKxKnek7EkiyObjM4wFvs/LxL?=
 =?us-ascii?Q?8NayX/jyHitRt9i2qgE2dBWh4MWHJIJ/KB/SiRjht1lYX4N4Ze33cnsV0UiL?=
 =?us-ascii?Q?IYWoCNIbJ4SAEhQQoCoesuq21c37dDuTQ6ng2EmvK1wn6U0Mlmvihd2Xa8N2?=
 =?us-ascii?Q?mrPnk5WIOtC4n8waFYV5e4u5hbQAxdChVPTv3BfWC1ISwNfNgSFG1u0cm2ds?=
 =?us-ascii?Q?Nk3FYGZI3s0se8SILBVQVq24p4ZX6NefExv34Q5QryyHEZz3jA2ZS6BATAgL?=
 =?us-ascii?Q?XF35koUPMVYIzoOhT3uOFxW2Co1hK3KLemJ5QYleSaJ0K/RsBoc4zTvlzPHQ?=
 =?us-ascii?Q?eWwEOx3AqtBfnzuJRwW+TYjvfKc3uhZ48zeetuymjc154mfQMhlJuVotraUH?=
 =?us-ascii?Q?ESYS57KjllP6FCDvX2WEb0XzAt79ouNuy/BwTVzI7rgdOY2WAZC24g8mKnbp?=
 =?us-ascii?Q?MAsiTMPw6/7zozyH68G6cqoHOwB4+/3Ydb1kgKOWPS068LVH2nvNRP7T0Uwv?=
 =?us-ascii?Q?0xGGIExiO9YKGf4/I+H3wtw1zyo8ZK7Y7Erl1ryQCjy+vovjFCFxKBN3iPBx?=
 =?us-ascii?Q?h5k5M32A4FMbeY3hC/4m1MoWxdJKHbqjYDfeidtfY9jwIjrlvpGCCOybwtBN?=
 =?us-ascii?Q?NeE1IzHO4CXzbgmxCkpn0rpC4wpLhySAe4XDD3FmdsL/Hs2AJA21p1+b6zlX?=
 =?us-ascii?Q?nx7yZXzeaUjiXU9DWMP9UhWYbfpjbfmkB0uPqJUqcvk7+XAzx6gPWDFnNvxr?=
 =?us-ascii?Q?hLiR0rwnpXPCrl0Ll3MkCUHwgB0PED2vFT4lwnvSHRihzpkB+WW5sbmxBFkY?=
 =?us-ascii?Q?DjexlA9FSkfIoeCQTHTTHOuGPpAT2rjM5J99Bd8CSsnIUyVNAkdAjU4oxLDG?=
 =?us-ascii?Q?CatsYX8hycFqe0SEMi5MeFMU9KmCXZiLAIYr5y1wZTVpOg75Op/BRe0ycqe7?=
 =?us-ascii?Q?OdSmafFxD4XchAfCyBvtygAc3BynvkaMzpR+wK6LZ94iFerv87AMTYs4CN0G?=
 =?us-ascii?Q?+pn8Wgd+GnvWgW3AvSVLCWMbnVN8WE7v/gpm9HNYNXNomedUf5BIp9n8YQmy?=
 =?us-ascii?Q?WqUb3yBVYONk4QTT28ANP6cZ+3vvr2oBmHarkSPfvonxVgduNWbmksFn+Obn?=
 =?us-ascii?Q?3UTjK/jLvJCN1hPZiM9tmjyCMDU22g8KHwWZ0oQuGsUyrWmlJ+z/mLs1beHS?=
 =?us-ascii?Q?KXIMtRtdp7PPYy5JAAoyJMSLBm9PnKA5UAz4z06/0T4E5QADnAMv1EvptVA+?=
 =?us-ascii?Q?ePqisHhXjpdqFRL4C2QiQ6KZbQDtyzwRBDxnKOoMNu561JxDswBDbyGrPvdD?=
 =?us-ascii?Q?Bg=3D=3D?=
X-OriginatorOrg: moxa.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 85e9fc30-6def-4596-4b3a-08dc8b9005ea
X-MS-Exchange-CrossTenant-AuthSource: PUZPR01MB5405.apcprd01.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2024 10:03:07.2464
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5571c7d4-286b-47f6-9dd5-0aa688773c8e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rZgQz1BaTlJB5SCmu8SYhp03zl0qifXeRp27pX4uInkgI9Hu0QyBn3+5Hf3gKsLFuEukARj+9uP3Ujes5WzhICjS+6nroYdl2BVvO2tUc1E=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR01MB4226

On Tue, Jun 11, 2024 at 09:42:36AM +0200, Jiri Slaby wrote:
> On 07. 06. 24, 13:43, Crescent Hsieh wrote:
> > @@ -212,32 +187,7 @@ static const struct {
> >   /* driver_data correspond to the lines in the structure above
> >      see also ISA probe function before you change something */
> >   static const struct pci_device_id mxser_pcibrds[] = {
> > -	{ PCI_DEVICE_DATA(MOXA, C168,		8) },
> > -	{ PCI_DEVICE_DATA(MOXA, C104,		4) },
> > -	{ PCI_DEVICE_DATA(MOXA, CP132,		2) },
> > -	{ PCI_DEVICE_DATA(MOXA, CP114,		4) },
> > -	{ PCI_DEVICE_DATA(MOXA, CT114,		4) },
> > -	{ PCI_DEVICE_DATA(MOXA, CP102,		2 | MXSER_HIGHBAUD) },
> 
> How is this MXSER_HIGHBAUD handled in 8250_pci?

I will first create a patch to split the Moxa-related code from
`8250_pci.c` into `8250_moxa.c`. Then, I will try to migrate `mxser.c`
to `8250_moxa.c` and handle MXSER_HIGHBAUD there.

> 
> > -	{ PCI_DEVICE_DATA(MOXA, CP104U,		4) },
> > -	{ PCI_DEVICE_DATA(MOXA, CP168U,		8) },
> > -	{ PCI_DEVICE_DATA(MOXA, CP132U,		2) },
> > -	{ PCI_DEVICE_DATA(MOXA, CP134U,		4) },
> > -	{ PCI_DEVICE_DATA(MOXA, CP104JU,	4) },
> >   	{ PCI_DEVICE_DATA(MOXA, RC7000,		8) }, /* RC7000 */
> 
> Can you simply add this exception to mxser_get_nports() I suggested in 1/6
> and drop the whole mxser then \o/?
> 
> I had a long-term plan to mount mxser onto serial-core (or 8250). I haven't
> managed the conversion yet. So I am glad to see this.

Yes, I know you have been working hard to convert `mxser.c` into a
general driver, and I truly appreciate your efforts.
https://lore.kernel.org/linux-serial/20210618061516.662-1-jslaby@suse.cz/

However, I am curious if a general serial driver can support the full
functionality of PCI serial boards. Additionally, what's the plans for
addressing specific functionalities?

---
Sincerely,
Crescent Hsieh