Received: by 2002:a89:413:0:b0:1fd:dba5:e537 with SMTP id m19csp38431lqs; Thu, 13 Jun 2024 03:10:04 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVDGW2iGpGhM4wAIxFhiRdIBWUQD5ndQ/WJfYuVsv7d8w5OQOyIIERExfIbTlTP0ETBxj2C8/y0weuUz7oxrHeicSlx2NzxSS367wJGew== X-Google-Smtp-Source: AGHT+IHqR927hefT41qOOyl5gJ21GhA9Z4HicaBIIxeoHOWZbkx2vnqP4ia3QSVPsX2NpgxlON8z X-Received: by 2002:a17:902:dac1:b0:1f6:f336:899f with SMTP id d9443c01a7336-1f83b7a33c5mr46196165ad.54.1718273403820; Thu, 13 Jun 2024 03:10:03 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718273403; cv=pass; d=google.com; s=arc-20160816; b=FUU77bXXpgFw4SdaQN0W591ermSzifwh7DHy2ykl3o24cvjm1HOxN6R4Z8ASkLwRAW Ka9EBkrHsA+hlxQwi3uwipyZ6v0Dt3Ko+EHoII4snXn1yLlRvyt3/8zediF8XKX/XRxk hMnlKa01OERZSct+xXmgNEs9iRL+vEBhHFhy9DZ5qFVd0hFZZCwJX9DSpZGi9iugsHhN uz+cZ9sJgpSiLKMR0eaA4V+KMtMvFVz5h2UMNmDKqn+ISsgRQGbLN6jmZi4XdDBiPYGT ahrHs8IF6px1I04+x1qfxcOl3vBeRv+uOkd7v+b0XG6MFddq28DR10M6gKh3UHRpb1hN R29Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=mZUyZbGRLoZ61VzFcElkmd0RzIflNIRedkXb41aYIms=; fh=c2nAzDtHv+YVJXyBglNeFvtAfhdfLZ8h5EVv6qIheio=; b=SuwVEGPJXhYq5urtjkrmVzXLm6VL8fHADawunEBTFY3KzzeYzJ+6xEdMIhOvGvfUX4 dQm0Ka/k6wEYrm/4lvl5F6AGZPjCKv5l32sJw805dwSBxMWWBMVBEDdnqJ0umUQD3a0J KUIUrMf0CVMiP61g3x470ZcafyDKutvK8KzYuvJ/weL4ZAV7++gn0fnRqOO0xWK9KCiB RDgYKn4zjIq2Z5kZnS33wbNj4QZYJfHMbHs1J++3oZL5AuDIItUo++gIKXQTofACWqxO HMGW8rvPtnLCzDuTSINtyl1OOvMVdwbHRlWeCHChQgpmmAjBCun6xwvPu0KxPSW+x9L+ ioyw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=XMBP4Gj4; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-212581-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-212581-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id d9443c01a7336-1f855e3e165si10055575ad.45.2024.06.13.03.10.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jun 2024 03:10:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-212581-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=XMBP4Gj4; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-212581-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-212581-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 9F70BB23A84 for ; Thu, 13 Jun 2024 05:44:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9FBBE1369A3; Thu, 13 Jun 2024 05:44:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="XMBP4Gj4" Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BDFE136672; Thu, 13 Jun 2024 05:44:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718257465; cv=none; b=qPX39fkgM4twnI03hJ3Cg63DJoTRxn+NzV06OqO7WmrKpbdGK6dVxOeZFcxZEUHaxV2B1ZE4An8hlbKNOrOLSK+5XNiulFudoHVLfvPS+2M55IiS0iieTWUfVSEJ5Lyzd9GuUFA4OAnNkhO/f/9ru/Gn5EWRY8yOuAEuxN2Uo5o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718257465; c=relaxed/simple; bh=/tygySxNptF1bNqqC2R+zD32oTKCFsAxOPINPtnaW6c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VRI0qvtia5MjgIBT59vDB3zAiJuHSqrGtGDK1X1xq72nZWirXRejRr4brz5iA1DaDl6glYF0U0rBHBmZiQVZSBtzUoj/YEqkBec1LL8nikqNYGxHuit/02BX7Pu1Zv2ZrEHv5Wy3It9WQ+0qG/zu+YFWIT4oEJyfpyzPDZCG+8Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=XMBP4Gj4; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mZUyZbGRLoZ61VzFcElkmd0RzIflNIRedkXb41aYIms=; b=XMBP4Gj4alCsQXtnGvwGXhKGJq WcL/CT6vNh91rMWL54YOhyIVKEZ/leEAqL33Ichz8d1gGp+JsGDS2PbQPDoQGZr96bGQqisXqcIsJ OuEO+i9FYIEzwCXV36lgY4XnjcWtzPmXcjWWaOvp5deZ60g/G7q+sKCNsNgeM21GL+aAIXBewlA9h h7mCJ6SESIzFIIHYiPRtM2v1wtHhYFCW9tb+tr/QPY3z0FdPkqJxzfzXUyDeiXOKjmA45C2hTvlD6 Pu3Xx6w3CK5nY7Zfa/zkDicZU9YyKyX9LdVJ28OmMNCTD+BBduLlz0Ooq2RoJ35KLgLW4xgDRHnQ5 /vHY+Ewg==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHdG1-0000000FCio-48U9; Thu, 13 Jun 2024 05:44:21 +0000 Date: Wed, 12 Jun 2024 22:44:21 -0700 From: Christoph Hellwig To: Martin Oliveira Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Jason Gunthorpe , Leon Romanovsky , Greg Kroah-Hartman , Tejun Heo , Andrew Morton , Logan Gunthorpe , Mike Marciniszyn , Shiraz Saleem , Michael Guralnik , Artemy Kovalyov Subject: Re: [PATCH v2 1/4] kernfs: remove page_mkwrite() from vm_operations_struct Message-ID: References: <20240611182732.360317-1-martin.oliveira@eideticom.com> <20240611182732.360317-2-martin.oliveira@eideticom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240611182732.360317-2-martin.oliveira@eideticom.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Tue, Jun 11, 2024 at 12:27:29PM -0600, Martin Oliveira wrote: > + if (vma->vm_ops->page_mkwrite) > + goto out_put; > + I'd probably make this a WARN_ON so that driver authors trying to add a page_mkwrite in the vm_ops passed to kernfs get a big fat warning instead of spending a couple hours trying to track down what is going wrong :)