Received-SPF: pass (google.com: domain of linux-kernel+bounces-213010-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 13 Jun 2024 18:15:23 +0800
From: Crescent CY Hsieh <crescentcy.hsieh@moxa.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Jiri Slaby <jirislaby@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH 0/6] Adjustments and Enhancements for MOXA PCI Serial
 Boards
Message-ID: <ZmrGu4j8SRIgxCum@localhost.localdomain>
References: <20240607114336.4496-1-crescentcy.hsieh@moxa.com>
 <ZmQovC6TbDpTb3c8@surfacebook.localdomain>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZmQovC6TbDpTb3c8@surfacebook.localdomain>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?VepZyCcnILBbOt+m7LjJfbGoJw2+GTQnKEMx1Ymjs+6BF8Kw1CuP5wFJ0l17?=
 =?us-ascii?Q?RddBd4nnFnQsREKJWcc3RLSSSvYmYd6UbpWNvKF9aLvR4OhexBqBbvEGlH3a?=
 =?us-ascii?Q?XJ5AXt08xHyCEIl6hmRWEjTxpV7I8BO6PgNLH+4i8DtzHs0ubAcUZvmDAsnN?=
 =?us-ascii?Q?PEBHGorE65BmIKxITT9BM6UNAyksddDYtgFaVKnaZDoKIUBcrobapX5MIkKN?=
 =?us-ascii?Q?c+E2QHrQjAQA9c5GH+4+Jo3MrdBNzni5BM4m+mi5Th/dXAFqeUSAg8T0D9Dt?=
 =?us-ascii?Q?mc+cKisQp/fJ93+ERxthIASlMCPVwslW6sZqiMRggs425l1HulsbB7HH+C3D?=
 =?us-ascii?Q?FsD7Rew3q9Jyb6rv5C81wQWbhBClNbgUoRmr/YvZLQcHEZKa6GPvr3hW7Nsp?=
 =?us-ascii?Q?oqL2WURJXAclw55av13oQQYSIl3NEQgmYgcA15ULS4Tk76LZh6lRjrePTSyC?=
 =?us-ascii?Q?bxFpwVz48HqiowCgRYU7EH5e8INK5PSLKInp2OLe632o1j+aqglk+abCqlq6?=
 =?us-ascii?Q?ebnzbh3uRMmEzPPUDI361/PKEkwkY67rYIcl4pXF7ktTxu/hw9Y4uwVR3Q2i?=
 =?us-ascii?Q?WKqCu0IJgjn8k5jT0Iyly66E7jVsGKSmEVp68G/Cz2iyys9x5Nsrv0w+aSEL?=
 =?us-ascii?Q?KjRwGCq+xd16bAZNS0uHtSK5i5/ROHfSjivqpBn9FDpLXEaP9htcLNIQxd/x?=
 =?us-ascii?Q?C2uC+UP+1Nk7bActHxeZqTyPokyZt6SWXmKN0Oy5QTrad9GeoL/wIPh8+wKp?=
 =?us-ascii?Q?oamNCUlPZG0z0GQdo0fKwGqVHHT3RK3W/a+c9eF9W7D8+mKgPGfgkEvIc12P?=
 =?us-ascii?Q?PlZovkGmz1m2CCAS5uxCUgIBVQKVFGJ6WeQ3AFxHYRRelc7viT30bkgzFzwL?=
 =?us-ascii?Q?05lDMswi24KKOQFCb3DkMzsVHuaJNYglC7zw5LXfz9T0Tkv24OZLBOnyzyDR?=
 =?us-ascii?Q?Ks0PiECwJmEcH0EdiirHJAt4ncfiuWabB7YWBM0Hpr/LcqOFwZU1qs/uP2QK?=
 =?us-ascii?Q?ji2MGh2tgHIRLYT08n9aPG2KIy0oLN6hpSMUI5sUHp34LECRjJcXnqFSCmi9?=
 =?us-ascii?Q?cvV2wlHLiY3G7fHLAP/7/0Ll1WJsNCB0qUININ3w67izWjJUBX8vm9qaV92m?=
 =?us-ascii?Q?xCGyvhlX/UxGsNb/3p3drMzSD1v+qfCd8KzCcmzBHqfo357kvEaGkj5C8hFn?=
 =?us-ascii?Q?63I/HQyEogVMn6+cP2EGubKU2R6zVPDlkMh6wEFjbeZC8mN5ucDEWJ+aVeaQ?=
 =?us-ascii?Q?+h9Ns3mDO8b8eHyg+1lZ4VpeR/bRB13Fm1Yto4z1gn90o/7e1JoGVJp9haxp?=
 =?us-ascii?Q?xIJxSLFEwNJbGkk/QgVQC3jz++8dqQ7wdfhhEtk1SqdhDkGngAAeAEg3rxvP?=
 =?us-ascii?Q?7GyX0R6M2PD28oWCIqNPu1FADs/phWUK9UBwtDZe4pmnR8JxvUwI3ZObTys9?=
 =?us-ascii?Q?zNUzDWeWW4lac11LNCiyoUQpkXATWgv3GEF5+0giSc0kC8j5lAJgBXxv4lNj?=
 =?us-ascii?Q?Pe9Hk/yiQ5Zf70WdixMSyqlqtO7JjiwI5fET1AiMZF7bolbo696AeVdVxYwq?=
 =?us-ascii?Q?w962CxlRGeps3L8e816MecQ8iNihfV/wm/m9uKtRDJ4+NVmJ0EnYwExXOfwD?=
 =?us-ascii?Q?PA=3D=3D?=
X-OriginatorOrg: moxa.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6e44a06b-955d-448e-84af-08dc8b91be78
X-MS-Exchange-CrossTenant-AuthSource: PUZPR01MB5405.apcprd01.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2024 10:15:26.2935
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5571c7d4-286b-47f6-9dd5-0aa688773c8e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZkRE0zkJYokFo+3benya5azOqrs7ciwRflAuV5AL0Q0cCMhHDjTJSMSyX5099Uft/clAIqfhVPAnxb4N1MeK/oXo+8lqus5Z929thERHklo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR01MB5930

On Sat, Jun 08, 2024 at 12:47:40PM +0300, Andy Shevchenko wrote:
> Fri, Jun 07, 2024 at 07:43:30PM +0800, Crescent Hsieh kirjoitti:
> > There are 6 patches within this patch series to make some adjustments
> > and enhancements for MOXA PCI serial boards, a briefly description is
> > written below:
> > 
> > - The first patch is an independent bug fix patch.
> > - The second and third patches migrate some MOXA PCI devices from
> >   `mxser.c` to `8250_pci.c`.
> > - The fourth and fifth patches address improvements and adjustments in
> >   handling the serial interface.
> > - The sixth patch adds a UART configuration that aligns with the
> >   hardware capabilities of MOXA PCI serial boards.
> 
> Everything is fine except one issue. Can we avoid polluting 8250_pci?
> What I would expect as a patch 2 is a separation of 8250_moxa from
> 8250_pci (see examples how it was done in the past: 8250_exar, 8250_lpss,
> 8250_mid, ...) and then updating code there. Can it be achievable?

Agree, I have been putting too much stuff into `8250_pci.c`.
I will send the bug fix patch first, then create a new patch series to
split the code into `8250_moxa.c`.

---
Sincerely,
Crescent Hsieh