Received: by 2002:a89:413:0:b0:1fd:dba5:e537 with SMTP id m19csp62955lqs; Thu, 13 Jun 2024 04:04:58 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWRc3IqUPW+sQuqE5d5Su12CNkyy4uxldVua5NEDik0TYQtd6lhjo/6OW/AxmvIMuAT7luUfSXTbs2AmcqqS7Qtv1xUC0T3mQ9skJdt+w== X-Google-Smtp-Source: AGHT+IENjI030vB5s6NXfxEdWCFnJFB4wEcdkleL/W05MeJWyjB3Iav6S7RelgVLu7Nhgp7Npp6v X-Received: by 2002:ac8:5e53:0:b0:43f:f098:9662 with SMTP id d75a77b69052e-4417aa294efmr38125761cf.26.1718276698047; Thu, 13 Jun 2024 04:04:58 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718276698; cv=pass; d=google.com; s=arc-20160816; b=tyLtO4jickYSGfnyvIdhGx4fPZ+FOWplYEfq4mXvP+e8V6b6IHPwE38Q4inciZZEZq vvBL8xKkh7T85YBA67l8S/0/0R0F0H1tnsVqJc0vxN1qztXPUB819x+Bf9tUm0FIWCCs xxt/TmhZfzgEAOJf0DSC567cfxmqXmmRFRCCt65YxLh8KPZvQzdXK8LKPHMfGomVKWlI 9o8MT9lFoclJE8d56KLRPTRu9Ee1dlV8IHKnZpZIt2BHO8q2VX4f2pfyT1ZU5gJo4QUL OykER42VsrOtwCnGvOrtiepdc3mj3gYXazXjVnlOTx6x0Irx4w+ZaoOZ26cVTXmlAyeO 0K9A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=r05GSGoeixdTdrkrNQk/uUV5myauBem2SPDkvyRDYgc=; fh=ev41kFM7MiHeAYKuMcVXwOcriF57i9wc/R0mmsFfqnw=; b=U/trkF5JCK2d8sYEEzqYn+ioZVxGpZlqIvXep+zA4Xw7ASsQHBinSAF3voxgbY65sQ /hn2oUX+Pdgulu1qPUnmhsTJENqZbnnG0bpEWfkXt7ha1qbAqx54I86lbEatc7joBUmx yCL9+5EcTaeHgJ5SlJdH9tIieQs8nt636kuwFGBuRqRMtSBOh5sGDcWIALf7qId/eKvI M+35gadBvZagikfUm9reombcmu1ABcsVIhYDUbw3noZgyN+HZ7E7FvaqX5Z+LGcMjdRj juiYaH6UVFidkryFYWtKM+3UgztCfTMqN/Vonp05kGZb/XI9gfCgQtUXd78wK3l145SV Fw0g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=w4xBmUY1; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-213071-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-213071-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id d75a77b69052e-441f2eaaf19si12302471cf.288.2024.06.13.04.04.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jun 2024 04:04:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-213071-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=w4xBmUY1; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-213071-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-213071-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id B131B1C22706 for ; Thu, 13 Jun 2024 11:04:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D8E31142E87; Thu, 13 Jun 2024 11:04:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="w4xBmUY1" Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C621142E73 for ; Thu, 13 Jun 2024 11:04:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718276693; cv=none; b=nI4xQPWUxSh0C6VvVAxCZ73Bd8tsZ01SqJIJxOGgz/924zahg29J7/uhoZGsSY7htywY0jFisgttVH2e9f6XymoCB6ctlfai6h4i9Uxz3C+1pY8v9+jZhafZNWlo6cNUtA1jaIovemowxS2DSha938nOTH5jXsuN7zkLFtPCQ14= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718276693; c=relaxed/simple; bh=tAcSgvKXqfnSUFX2CtxDigGjnUYTBy78IoinGdlH2fw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dImnQ4PF3LivxERjGdIyN6iszZ/pI/Pv8VWinie1rERJEvjpL1il21uA8BlSOdhgo/AV5w2ozhUZkyTxziIM9JTPK+bWEQhmKQ899OnOny9vuFBfxfqkIwuX93rp+pwe55bvlaSPfL/jVIzxAkc/L8QyEvV4GKOfB8i049fWyo0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=w4xBmUY1; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-57a44c2ce80so878523a12.0 for ; Thu, 13 Jun 2024 04:04:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1718276690; x=1718881490; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=r05GSGoeixdTdrkrNQk/uUV5myauBem2SPDkvyRDYgc=; b=w4xBmUY1ZJlIjBu16PzN8sZaXgkMZqijgAdXFvQWwFJBZ2towBcf+TEUgIUNrLAD4U 1cvWhBKoj8wd7QY3XyPGjA+HmL2OUzXk2np8ayObVlZw8UKfOptdXsVmnIVxmi+kOOhv KEAPweB709bz/I/N6lVo8b6fiwDS+Xi+HYL3fqwXRTOPtjmJlndtIm+UoyFSjUzdRoAS HPs3nVNcc4hFM3K8qv9r62e5AqK35r7HquKA20Tqh8Ey97mRsMmgdvsyHWkRUly3AbRA WvMCd61dPGvXp6IttJsP2Tn+NMa5TKqSE5W6rJPVXBlo5VQmtMzd7sCZGfpwvHjxjIvi PWeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718276690; x=1718881490; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=r05GSGoeixdTdrkrNQk/uUV5myauBem2SPDkvyRDYgc=; b=uUgNbe4xdV/EU8OQNaGna0kMAk8K7pFF9Hu400Odl4pl8fo+ErtD900K8NLBKGtHyn /JSDc6DnktBmUGAY2R+A/UkvmqkO6i4a96UJ68aLE0KIqLKCP1gzJMup3YEwBKRI9SbC IWzfRdlu3eTsIZfkO5x4JncAGrnltIVLZTPa8y3fEml/3wCgBrT/jKfh6bRqB1V1pJ8G B0zUQoKNqUlIolbiZS9HME0BQYpzJXMB4awkQWRy8ogEJvSCh8DGM/LAVmJ+SOt2JKZT NL93jC8YW4FjYi0V8cZnimXrjmJ3vffG5P11NPGPs83yyx7hc0ge/xNsdkB0LYfq2kek r6vg== X-Forwarded-Encrypted: i=1; AJvYcCVI2H09biHCHtNNlOoj8KapujnCFnAGdy1tm3h3EReOhEB0Lp05Ay7LDxahkl28+AG3piZpPonmajPIyX0SopJUO4IaRlE+iATU+RAF X-Gm-Message-State: AOJu0YwYfv2DX08xtPIw4ncMuTiChy3uPbEo9vD/xeP6t4jO4U8ldxBQ xLUtvAPOUZt0z6FhH/x1zKoLTG7BedujsoDQ3nTkpIlYhpXQ2ezfMuhj8wwPdPs= X-Received: by 2002:a50:d7d9:0:b0:57c:5f22:f9c1 with SMTP id 4fb4d7f45d1cf-57ca976a4e8mr3004561a12.21.1718276689646; Thu, 13 Jun 2024 04:04:49 -0700 (PDT) Received: from [192.168.1.195] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id 4fb4d7f45d1cf-57cb72da37csm768974a12.27.2024.06.13.04.04.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Jun 2024 04:04:49 -0700 (PDT) Message-ID: <93b2de4e-dc2d-4781-9c1b-d6ad6d888eb2@linaro.org> Date: Thu, 13 Jun 2024 12:04:48 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/3] ASoC: codec: lpass-rx-macro: add support for 2.5 codec version To: Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Banajit Goswami Cc: neil.armstrong@linaro.org, linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org References: <20240612-lpass-codec-v25-v4-0-f63d3676dbc4@linaro.org> <20240612-lpass-codec-v25-v4-3-f63d3676dbc4@linaro.org> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 13/06/2024 12:00, Krzysztof Kozlowski wrote: > On 13/06/2024 12:49, Srinivas Kandagatla wrote: >> LPASS Codec v2.5 has significant changes in the rx register strides. >> Due to this headset playback on SM8550, SM8650, x1e80100 and all SoCs >> after SM8450 have only Left working. >> >> This patch adjusts the registers to accomdate 2.5 changes. With this >> fixed now L and R are functional on Headset playback. > > I was just about to respond, are you sure this is suitable for sm8450? I > looked now at registers and sm8450 (which should have codec v2.5) has > old style register layout. > from 2.5 the layout has changed, I have verified it on SM8450, with and without this patch, This fixes the issue one speaker issue. --srini > >> >> Signed-off-by: Srinivas Kandagatla >> Tested-by: Krzysztof Kozlowski > > I tested earlier version of patchset on SM8550 and X1E80100. > Best regards, > Krzysztof >