Received-SPF: pass (google.com: domain of linux-kernel+bounces-213161-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 13 Jun 2024 15:00:40 +0300
From: Vladimir Oltean <olteanv@gmail.com>
To: Martin Schiller <ms@dev.tdt.de>
Cc: martin.blumenstingl@googlemail.com, hauke@hauke-m.de, andrew@lunn.ch,
	f.fainelli@gmail.com, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org, netdev@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v5 09/12] net: dsa: lantiq_gswip: Consistently
 use macros for the mac bridge table
Message-ID: <20240613120040.agc2vlurospupqui@skbuf>
References: <20240611135434.3180973-1-ms@dev.tdt.de>
 <20240611135434.3180973-1-ms@dev.tdt.de>
 <20240611135434.3180973-10-ms@dev.tdt.de>
 <20240611135434.3180973-10-ms@dev.tdt.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240611135434.3180973-10-ms@dev.tdt.de>
 <20240611135434.3180973-10-ms@dev.tdt.de>

On Tue, Jun 11, 2024 at 03:54:31PM +0200, Martin Schiller wrote:
> From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> 
> Only bits [5:0] in mac_bridge.key[3] are reserved for the FID.
> Also, for dynamic (learned) entries, bits [7:4] in mac_bridge.val[0]
> represents the port.
> 
> Introduce new macros GSWIP_TABLE_MAC_BRIDGE_KEY3_FID and
> GSWIP_TABLE_MAC_BRIDGE_VAL0_PORT macro and use it throughout the driver.
> Also rename and update GSWIP_TABLE_MAC_BRIDGE_VAL1_STATIC to use the
> BIT() macro. This makes the driver code easier to understand.
> 
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Signed-off-by: Martin Schiller <ms@dev.tdt.de>
> Acked-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---

Reviewed-by: Vladimir Oltean <olteanv@gmail.com>