Received: by 2002:a89:413:0:b0:1fd:dba5:e537 with SMTP id m19csp94532lqs; Thu, 13 Jun 2024 05:06:37 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXhZYjRYRUxEeotcDg6h1yJ+HAavvVfZGwLTd0z0F29WpbC1QkZEOgKAz7TfdQwa+Gg03UD6xdz14yUQ93KbBURZkDNS+Y+AuoWOjL0oA== X-Google-Smtp-Source: AGHT+IEIdYgjeUbhb1wR0gWjlRYCQxSKB7XH0xBzuZ6FkkuA7yL9cohuf2wGwR9NH/Sui3Gof0+y X-Received: by 2002:a05:620a:471e:b0:795:4671:d494 with SMTP id af79cd13be357-797f602abdfmr502878685a.25.1718280397167; Thu, 13 Jun 2024 05:06:37 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718280397; cv=pass; d=google.com; s=arc-20160816; b=vQzllSY0bE4h4D+2L4cjF1QjNKzTcsipEuojH9QORA1tjM7MESMJ+OvRUKfXc10LCX LtyJzQzA3V99xwQqCLUszgpTqoV/DS8ch9c/rqfGl92O6x5U/ru+B0k61cJ8Z4urbd2/ reDmCypSTnxRXxdpOK9D2d0w+z5k3LsNxeazmebPuQvgECGVw8q2cFSeYttSF5XBHfTH U9vFzC9UDKzqx1a/hKQwIaud9OMU5pXeYCiDqvT/9b8g2k7p6D8Y9Ogfod1GUvQLfABR 28excTiPlelqoAmlo3uogUs9lCoyyFL+JCGNQHs26XztCMXbC5ouxbFgvE7YD8hrkHWH YOEQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=TBJ1ejFH7z7OGpwZgl0po5UnGmqdnLOVmfHOb4vTMGo=; fh=g+baMlps6bvC9qiyBkMIaWOcZikB85F8J5CGRf3G5gY=; b=Cic41LzdEUqxSf7kMhk6b1PUm6koyobhEXhIzUp2/Cj6vq1hTfjEZPKCPT6gqH/80b J1GfABxcxz1YFRQW5FYggJWgPnMuQd6c/+8HoQVDl2gaEMJO9PvaHosSQVcopiwkMAmf Zd1806RtY7kfOurkb9WjTKJlNNAPHRl1rBrcGKzdHRsYE4K+F+fisnJiioXvlqee+EPC 1tP2H1+8wYig8J3mHt6/v1PbNBJjNaJOnX8Y1M9fdRaFBxfL9Y0RzsIOLMkZfDS2XKFR rGgJIJG41OB/5qScCpikI1muxdgTO7YQ6C1yO8qHdqiEo9O1hQRSQ7qq7fKyvzj6Dfaq AQjg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=a0BwPDCo; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-213163-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-213163-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id af79cd13be357-798ab8ffc40si120584085a.301.2024.06.13.05.06.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jun 2024 05:06:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-213163-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=a0BwPDCo; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-213163-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-213163-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id DBEA81C220D8 for ; Thu, 13 Jun 2024 12:06:36 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DA21F1487C8; Thu, 13 Jun 2024 12:01:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="a0BwPDCo" Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87878145A14; Thu, 13 Jun 2024 12:01:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718280094; cv=none; b=EMw1UdIfzWUEkBUyh/QTQi47f1alI2kvRlmp0vF8eOylT83rj249gYS1hrDrFs6P0a3XMB1nV4xidYOjmQTqVCc9km6hxuSu4cJZ/ZnJZpW4MvdjCSmdnXFGF/K0sIXk2K7pqbNHJswOeG2AXRwS4SHYMKXF5PPBCzbJCHlPDCg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718280094; c=relaxed/simple; bh=4Lqh1jE2xY516irQXX/1xMbdZu7XXl5X23gAe0VliwY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qUhBhJaINvmVqWLNJEbigeEIgw9atkQ6X/tz+To2wuDq6AsH3S5xveVusLv04xGpmUI40PG/6FCYgUU+CFQv5HWQ4no8Q7Y95NzAdxK6zBZD/LNEc4nJdbo0uDoaCdJceL+2j3Fthi34W21bU6155oV5fTFGKDSri9sUQYfS4v4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=a0BwPDCo; arc=none smtp.client-ip=209.85.167.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-52c82101407so1854064e87.3; Thu, 13 Jun 2024 05:01:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718280090; x=1718884890; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TBJ1ejFH7z7OGpwZgl0po5UnGmqdnLOVmfHOb4vTMGo=; b=a0BwPDCoZifbrca7QkgR+LbyA+EEHGJcNcE1uk6BnVZUQ5+KrZqug8VirEMCPK6/lU /HWEb9qW5mpHGpj64zgGFuGwnj0gfkGJOLJ3KKxSJ8eDYa47vjEOPW9NPfFT0I3yNUmp yWC4Mxo1IlzQTGoRBERuyEol/g2fuqmyZj7vrKXvtvhhBieVhMrJW+i62ysBcrV6RAw+ 1EoM40uKCB1J0shPli1HDqCIKbnhp9wlDn+nfGDZkKcTSkRC8QAVMt6rVP2TZhNt5I4B YjY14ly02a6i0+aDnOUPE9yreFhINPmPQ8uuRiWZvJbVUOagzcD1jRWW4zqWVpBw5Wd7 BRoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718280090; x=1718884890; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TBJ1ejFH7z7OGpwZgl0po5UnGmqdnLOVmfHOb4vTMGo=; b=My88MxMerZUtANmPuYZLD4+5tIKiyLY8xFEqRoF6dYKAYFGHOmZY4X6eTwXHy473cq E2MzCpo6qnLMJg2Eg9n/T7vZ6WhY9ukehepC/Qa7U09qrKtTw3vwXipGV5Lv198ivAOx SW2XwKdR0uuiCJezQN9u4L4L/og2thj6VYXGhUsbuQIgCIREiy9/r5g3TeKp8j5D9a+R E9A1ssJ/fVPiM/I6NfwaWtRysie3WUFEX8ynonOBgxb+ZP0nQUZLzTM1ZGWMadM+V4Rm X04w/YkFxokJL2mE8KXVz7Bx0VBojjkusda2kW6BstAlN+/0JCyYgghWP9/I7OJHdNoW x36g== X-Forwarded-Encrypted: i=1; AJvYcCWL+xuX5tGMF2ZsKOcA5wx29hHTJoExRyxtfjs+Go+okojR6vOPzHUhh6koIh7nJQHQsw3P9OtKB76wPSC4wE/fSqmzZ4TAiU6XVrLYyTMbxDUaqAhNpWwA14hjZuSUa3UclRwQlGq+kL6iRzRToYlMhuJutRKeBE38xDI5PL7E7w== X-Gm-Message-State: AOJu0YwdfA3T+0jXm3LNqX+hGDgJyEM10BfahnZ8MR7C/X+WHTdtK0rw 6IiR6GFO2ZdMIaHl/ESWiT9N5GidRYDn0odfBl9KY/PREp8PAIpmQPCyldPulzc= X-Received: by 2002:ac2:58d0:0:b0:52c:99ed:4c9b with SMTP id 2adb3069b0e04-52c9a3d1e74mr3286775e87.18.1718280089182; Thu, 13 Jun 2024 05:01:29 -0700 (PDT) Received: from skbuf ([188.25.55.166]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a6f56f42e80sm64042066b.186.2024.06.13.05.01.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jun 2024 05:01:28 -0700 (PDT) Date: Thu, 13 Jun 2024 15:01:25 +0300 From: Vladimir Oltean To: Martin Schiller Cc: martin.blumenstingl@googlemail.com, hauke@hauke-m.de, andrew@lunn.ch, f.fainelli@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v5 10/12] net: dsa: lantiq_gswip: Remove dead code from gswip_add_single_port_br() Message-ID: <20240613120125.yh5vda6dxornaadj@skbuf> References: <20240611135434.3180973-1-ms@dev.tdt.de> <20240611135434.3180973-1-ms@dev.tdt.de> <20240611135434.3180973-11-ms@dev.tdt.de> <20240611135434.3180973-11-ms@dev.tdt.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240611135434.3180973-11-ms@dev.tdt.de> <20240611135434.3180973-11-ms@dev.tdt.de> On Tue, Jun 11, 2024 at 03:54:32PM +0200, Martin Schiller wrote: > The port validation in gswip_add_single_port_br() is superfluous and > can be omitted. > > Suggested-by: Vladimir Oltean > Signed-off-by: Martin Schiller > --- Reviewed-by: Vladimir Oltean