Received-SPF: pass (google.com: domain of linux-kernel+bounces-213164-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <39eaba63-0e18-439a-82ac-834505e6473e@vivo.com>
Date: Thu, 13 Jun 2024 20:01:39 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] binder_alloc: replace kcalloc with kvcalloc to mitigate
 OOM issues
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: =?UTF-8?Q?Arve_Hj=C3=B8nnev=C3=A5g?= <arve@android.com>,
 Todd Kjos <tkjos@android.com>, Martijn Coenen <maco@android.com>,
 Joel Fernandes <joel@joelfernandes.org>,
 Christian Brauner <brauner@kernel.org>, Carlos Llamas <cmllamas@google.com>,
 Suren Baghdasaryan <surenb@google.com>, linux-kernel@vger.kernel.org,
 opensource.kernel@vivo.com
References: <20240611085629.25088-1-liulei.rjpt@vivo.com>
 <2024061216-faster-cufflink-ceac@gregkh>
From: Lei Liu <liulei.rjpt@vivo.com>
In-Reply-To: <2024061216-faster-cufflink-ceac@gregkh>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bFltRHlJQW9YanFEcGlaN1c1U0J0UDN3TElmVTNRZU1ZY1RpV2xDakljZkQ2?=
 =?utf-8?B?eG1kejNBSE1vY2ovaldMRHQ0TTEzaVVsMnJCY1NqVmpBR0FtcEkrejJkZUh0?=
 =?utf-8?B?VWtONjhNWFM3eEgyVWdhK3NQanFQMno0L3IxdUoyYXhIS3lveXdMOXh0VE9R?=
 =?utf-8?B?aHduOHF4QndMY1NuYjZjb0djdW1JWXRaNjdva1RKakViMThhVmFLSGZ3aVlM?=
 =?utf-8?B?cUVrK1htbUR0a2xRS3Q2blFTL0cydTNybmp1ZjlyRjVaWHF0YnVtT3R4WWRs?=
 =?utf-8?B?Tk4xUG5KNEJsSERIamw5KzNETTlLVlZKUmtKc2JYUG9JK1Uza2VvK3BBRzcv?=
 =?utf-8?B?Z0tRNXBDQ2gvZ1NEVXpOR2ZMcE56b1dwTGMvYUtseXhoWVJHVzRDaXcxalVK?=
 =?utf-8?B?WkQ1WG12eE1CYy9oVFJGNUl4cWUvT0VHd3c5TU5QUWRja1NidG10NmZSenp4?=
 =?utf-8?B?ZGU1SEVtRHZqVk5rSjFsRVhGL0llTC9rVXh2RTk1d2ZrT1JKWXBBRUpkdlNw?=
 =?utf-8?B?ZXZVaGd4REJDMi9WM0R4NVVHaFFhMmxUMzNIckxiZlF0bC9BSkFKRnhpaFRP?=
 =?utf-8?B?bHNybHlrUjh4cE1yK2JNQVZTZVZCT2QwOGF3NkRLNHAwVFJFVjNndG9PZnRr?=
 =?utf-8?B?bUZRRTFKcW9NK3pCdzhGYTRPSkNXSU0rVm55NGFrVUZmS3lsTDFxZUw5NTU0?=
 =?utf-8?B?bTNGVkhMWDFDYm54N2NuOTF5a1lOYUpFdjZPOWxFOTg0ZzlLZlYvWEYweXlK?=
 =?utf-8?B?T1hldDJNSktvNHJLbktHdTRzTzRTeUlSTENOTmwwVlU2UzJmYkpPMk96VWUy?=
 =?utf-8?B?czN6QVVNSUczMXRDeGlSWUtWc1d0WW9vbWo1THBhbjlXWGRJeXZGSHhaaWxT?=
 =?utf-8?B?OTFDZHRkc0xBeGRhbVVrZURPYzhoSVd3RkJKQ1dxYU5xbnBVOU5Kc0ZuNkU4?=
 =?utf-8?B?Q29jQXFKbk5YRDQ2eEprc3lvQkpjZXpmMGNMSlRDVGtidlRQVVE5elJsTGNt?=
 =?utf-8?B?b1F4ZmNvUHRXZnh0Y255aXJvRER1VTRhVkcyZVFOMHM1ZXFnTGpJeWNtSjBE?=
 =?utf-8?B?QkUwSFREekRQLzdGZVQ4WnZJZEFMWFRDOG1Xb1cwWncwdDFwaENsVWY2NDVa?=
 =?utf-8?B?S2c4ek4yelRRUWhiQ2hYYlNUcDdSUXI5SWJQYlJMWHQ1NnRxSXRWOUptVWln?=
 =?utf-8?B?Q2xXWlFLcUNSWHc5aVNGRExqK3l2NHg5cVFEeCtLbmp3RjJtamJBWGcvYmhQ?=
 =?utf-8?B?Wmg4Ym9zSktZYit1YkxhRi9SbkFvanVmaGNKN2NtN1RxRk1EaWdhbXY5UDd3?=
 =?utf-8?B?RlJpTmxDSEdURk1xcS9XYnpscFg1QXQrS3JxUWpvTXB1aUUyR2lFckg3VmM3?=
 =?utf-8?B?RTJlaU5MZGp0azNlR1R6MWw4NWNKVVhGTDZkZ05SQWg1c2dYSDUwNGV5OTlV?=
 =?utf-8?B?OEFvVGRFOGJFaTBaZ2hFS0hIcVREMTZ0T0M1UHNtcjlPZ3NIOGI4RHhNN1hj?=
 =?utf-8?B?VEJ0WFF0OVpkRWtuSUlia1ZxV2tEMW1zVXFDc3NGZlAwOW5IU0Flc0JQNXMy?=
 =?utf-8?B?OFFnaFhrSElMbnR1eWRldEU0NGFabW5VcHlxUkp0eUxESjdkYTk4ekFPaFRM?=
 =?utf-8?B?VC9HMkIzTlhmaHF2MXpkZlpheU1mNVNicTNKVkU1c3M1blZRWUt4NnVXN2ZL?=
 =?utf-8?B?aWRWNU1Menpyek1KMDkrSlpHOFduTnRYYVV0NkprbnZudmxtNEZiZFJGMlBy?=
 =?utf-8?B?MjRVcis3TjhabUxpd21qVjZWbS9LZXlNTFIwSkVlQmtWZG8wUFB0SWF4UFdV?=
 =?utf-8?B?VUJFK3JRT1NrWm5QcWVjQ2JsSzVGT2NLN1JMUFZyaEVqZkVkaVhHcmZPblFJ?=
 =?utf-8?B?L0htem5PQ2ttYUtxN050d2pLTmRHeTJ6SVFWV2dRRUI3V0xlRGVTbXUxWmYw?=
 =?utf-8?B?clFVZFZ5ZzVQMExHelJIOGdlYlErc3FNU0FKYjRuSEZtUHdkTFhSUzZyRmJx?=
 =?utf-8?B?RVgrU1lnTkQ1T2FuTENzYUlIUzFUZjRWQndNWm1GbkFhYUs1dkN6Vi9hNmhO?=
 =?utf-8?B?a2Izd1ZuTGZLMGcrYi92aEVuUC9FWExxYmtyV0xWN203Q3k0cFhzRktVdGor?=
 =?utf-8?Q?LcRyX5IJzBxcemybhkZ+GsMXI?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 19a3eaad-4170-4cf4-f068-08dc8ba0a0c9
X-MS-Exchange-CrossTenant-AuthSource: PUZPR06MB5620.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2024 12:01:58.9571
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fry1UJesxJm/He8ZcHx+z/2QFZX53UONED5MLe5PsMRAS9hDBN9O87FUOTSMcrPwVYc9rKRcTZ9sKa7Oqh88/A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB5788

On 2024/6/12 17:58, Greg Kroah-Hartman wrote:
> On Tue, Jun 11, 2024 at 04:56:28PM +0800, Lei Liu wrote:
>
>> In binder_alloc, there is a frequent need for order3 memory 
>> allocation, especially on small-memory mobile devices, which can lead 
>> to OOM and cause foreground applications to be killed, resulting in 
>> flashbacks. We use kvcalloc to allocate memory, which can reduce 
>> system OOM occurrences, as well as decrease the time and probability 
>> of failure for order3 memory allocations. Additionally, it can also 
>> improve the throughput of binder (as verified by Google's 
>> binder_benchmark testing tool). We have conducted multiple tests on 
>> an 8GB memory phone, and the performance of kvcalloc is better. Below 
>> is a partial excerpt of the test data. throughput = (size * 
>> Iterations)/Time Benchmark-kvcalloc Time CPU Iterations 
>> throughput(Gb/s) 
>> ---------------------------------------------------------------- 
>> BM_sendVec_binder-4096 30926 ns 20481 ns 34457 4563.66↑ 
>> BM_sendVec_binder-8192 42667 ns 30837 ns 22631 4345.11↑ 
>> BM_sendVec_binder-16384 67586 ns 52381 ns 13318 3228.51↑ 
>> BM_sendVec_binder-32768 116496 ns 94893 ns 7416 2085.97↑ 
>> BM_sendVec_binder-65536 265482 ns 209214 ns 3530 871.40↑ 
>> Benchmark-kvcalloc Time CPU Iterations throughput(Gb/s) 
> Both benchmarks are the same? Or is this labeled incorrectly?
I'm really sorry, I got the title of the table wrong, here are the 
updated data:
throughput = (size * Iterations)/Time
kvcalloc->kvmalloc:
Benchmark-kvcalloc    Time    CPU    Iterations    throughput(Gb/s)
----------------------------------------------------------------
BM_sendVec_binder-4096    30926 ns    20481 ns    34457    4563.66↑
BM_sendVec_binder-8192    42667 ns    30837 ns    22631    4345.11↑
BM_sendVec_binder-16384    67586 ns    52381 ns    13318    3228.51↑
BM_sendVec_binder-32768    116496 ns    94893 ns    7416    2085.97↑
BM_sendVec_binder-65536    265482 ns    209214 ns    3530    871.40↑

kcalloc->kmalloc
Benchmark-kcalloc    Time    CPU    Iterations    throughput(Gb/s)
----------------------------------------------------------------
BM_sendVec_binder-4096    39070 ns    24207 ns    31063    3256.56
BM_sendVec_binder-8192    49476 ns    35099 ns    18817    3115.62
BM_sendVec_binder-16384    76866 ns    58924 ns    11883    2532.86
BM_sendVec_binder-32768    134022 ns    102788 ns    6535    1597.78
BM_sendVec_binder-65536    281004 ns    220028 ns    3135    731.14
>> ---------------------------------------------------------------- 
>> BM_sendVec_binder-4096 39070 ns 24207 ns 31063 3256.56 
>> BM_sendVec_binder-8192 49476 ns 35099 ns 18817 3115.62 
>> BM_sendVec_binder-16384 76866 ns 58924 ns 11883 2532.86 
>> BM_sendVec_binder-32768 134022 ns 102788 ns 6535 1597.78 
>> BM_sendVec_binder-65536 281004 ns 220028 ns 3135 731.14 
>> Signed-off-by: Lei Liu <liulei.rjpt@vivo.com> --- 
>> drivers/android/binder_alloc.c | 6 +++--- 1 file changed, 3 
>> insertions(+), 3 deletions(-) diff --git 
>> a/drivers/android/binder_alloc.c b/drivers/android/binder_alloc.c 
>> index 2e1f261ec5c8..5dcab4a5e341 100644 --- 
>> a/drivers/android/binder_alloc.c +++ b/drivers/android/binder_alloc.c 
>> @@ -836,7 +836,7 @@ int binder_alloc_mmap_handler(struct binder_alloc 
>> *alloc, alloc->buffer = vma->vm_start; - alloc->pages = 
>> kcalloc(alloc->buffer_size / PAGE_SIZE, + alloc->pages = 
>> kvcalloc(alloc->buffer_size / PAGE_SIZE, sizeof(alloc->pages[0]), 
>> GFP_KERNEL); 
> Nit, update the indentation please. 
> thanks, greg k-h
The previous incorrect table title has been updated. Please help review 
it again.

Thank you!
Lei Liu