Received-SPF: pass (google.com: domain of linux-kernel+bounces-213147-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <ecf55d97-363d-4731-bcfa-81cb4e58f2c7@linaro.org>
Date: Thu, 13 Jun 2024 13:51:57 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5] driver core: Add timeout for device shutdown
To: Greg KH <gregkh@linuxfoundation.org>,
 Soumya Khasnis <soumya.khasnis@sony.com>
Cc: rafael@kernel.org, linux-kernel@vger.kernel.org, festevam@denx.de,
 lee@kernel.org, benjamin.bara@skidata.com, dmitry.osipenko@collabora.com,
 ldmldm05@gmail.com, srinavasa.nagaraju@sony.com,
 Madhusudan.Bobbili@sony.com, shingo.takeuchi@sony.com,
 keita.aihara@sony.com, masaya.takahashi@sony.com
References: <20240613083226.GA8191@sony.com>
 <2024061326-moonlit-protozoan-61f8@gregkh>
Content-Language: en-US
From: Daniel Lezcano <daniel.lezcano@linaro.org>
In-Reply-To: <2024061326-moonlit-protozoan-61f8@gregkh>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 13/06/2024 10:43, Greg KH wrote:
> On Thu, Jun 13, 2024 at 08:32:26AM +0000, Soumya Khasnis wrote:
>> The device shutdown callbacks invoked during shutdown/reboot
>> are prone to errors depending on the device state or mishandling
>> by one or more driver. In order to prevent a device hang in such
>> scenarios, we bail out after a timeout while dumping a meaningful
>> call trace of the shutdown callback to kernel logs, which blocks
>> the shutdown or reboot process.
> 
> Again, this is not a "device shutdown" timeout, it is a "the whole
> system has not shutdown this fast" timeout.
> 
> And in looking at my system, it doesn't shutdown in 10 seconds as it is
> madly flushing a ton of stuff out to the disks, and they are slow
> beasts.  So your 10 second default would cause me data loss on my
> workstation, not good!

Thanks for pointing this out. It is exactly what I was worried about ...

[ ... ]

> Isn't this just a bug in your drivers?  Why not fix them?  Or if you
> really have to have 10 seconds to shut down, use a watchdog timer that
> you trigger from userspace and stop petting once you want to shut down.
> Then, if it expires it will reset the machine, all of your policy
> decisions would have been done in userspace, no need to get the kernel
> involved at all.

+1


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog