Received: by 2002:a89:413:0:b0:1fd:dba5:e537 with SMTP id m19csp100057lqs; Thu, 13 Jun 2024 05:15:31 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUU2lkNciT9+H8Oc42vJUEdQ8nFatEhPThnth+QHGT8sdaM/0QzUq9iY8+5lK9Ea1LNE1Qwc6OIdXETIBMQIrVmfYj+1OuXRzQJKosRzQ== X-Google-Smtp-Source: AGHT+IHg5GkD5Ukt+7Miq4Tx7xvOPZQtNJBp8nfoo48Z+ExwdsqBBAPkHuzJ1hnW9I6xtcK42RhS X-Received: by 2002:ac8:5a4c:0:b0:440:5361:a83b with SMTP id d75a77b69052e-4417aa0bed3mr34525151cf.8.1718280930980; Thu, 13 Jun 2024 05:15:30 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718280930; cv=pass; d=google.com; s=arc-20160816; b=HYqKKndkPjlxvajsh1W5/ojprGcy0yoCxcYCAPFHnWojucTI7JlpqRoRGNekQHlXcg A4kJidVgDrZDbk1ykGK/VqSrckHf4QS3MWCiXiDijnZdhjP4as/tFxh1W5P2+clf/u6f 8nDTXzgZ8agTIakaQBPk6DvLaWJwVEDtGgxEt82z7U6J6HeYN6KCOR7414JFSG03xdNG DwQN9dEj4FzcfbeUlq6IdJmmOeWiYBuBrFfKcYpVlN0PasR182O4gLt2vd1csZ+WUczI xqRmMVEFOu+uMjs47rvOqvvMHjrYR6hhNnKtViXZdAeMHG9BmiLK40tnsqMc9og5+/Ae 7VrA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=LGjGDZJ+oK0bsfV0wugxbiOxTRoQHBa8hRKPPyoKoB4=; fh=ZdDGo3uQv5rqDCs83osKKVQmo4z8rtv/CA7qgNydb30=; b=jG3wYlPMb1FHb8v8RPumkv6tL+bPux8NVxUxPKM02nK01bbOL7xISXppUqBhgoKmsW W9l+gdu9JEQwGiL6bnaaXlnX8gTbXRnJqufznvYtTFNLoCimWO2zf6pluML6hYdOThFO dNceEHRu3gPRz5wJzZqLJBvXQ3SaOQydAf5yW7WDNqccH5Q+wBqszg2N1WkppyJ6gGzx /8SBSlRKmMQTvQ12XZsWCPUtBxrcHB2ACyaMAmk9fbC8A02oIOnbkgItBsWZeUoMnXti ltBm6L566gXStde5LNODknIveW0P1wQzZzgM9EhCOeMYnRYeviTJunPj9S1JemyqzjG8 179A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ai5pawwH; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-213177-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-213177-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id d75a77b69052e-441ef3dc540si12833211cf.174.2024.06.13.05.15.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jun 2024 05:15:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-213177-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ai5pawwH; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-213177-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-213177-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id A5D8F1C2104D for ; Thu, 13 Jun 2024 12:15:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9B5B3145B0B; Thu, 13 Jun 2024 12:12:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ai5pawwH" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C00DD145B14 for ; Thu, 13 Jun 2024 12:12:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718280766; cv=none; b=a2A7wzMqr9jOEVLfz7L4hdmrtBoXd+uzLgWWqhNcUX8YGSqqqFRPa1wOMP5gzLv5lnw9lJZ7LZzAvuAsi58MA0bgSaB9leCyPE5BsNcYr/29VSEezpNV1c9lsIbuncTBU9EMCT70wGyXht8Yf6y9QrVRWdNk3oDfMNNYSfzdSvQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718280766; c=relaxed/simple; bh=VL0D7Z1u35TJY1+wnfk182tojLh6CXU2VOnnleoOGPo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=cxq79KYJ6X2t/wDyL76/wxmDEbGX6TYmzNTR73TCrjn0yY32yzoWYf6N+X0inOvnDbBrMMLZnURm6K852WlIzd8Wlkc9qZiJt96NTe23vq+VByugFJnr0pxPj1bg3pyK5fB4gL+X1XnyXy1jc5nYhTmIuQnUopQCLwJYrj265wo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ai5pawwH; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4AB9BC2BBFC; Thu, 13 Jun 2024 12:12:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718280766; bh=VL0D7Z1u35TJY1+wnfk182tojLh6CXU2VOnnleoOGPo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ai5pawwHc9j0icjq4pAa4AjjNnJZc9FqaRoZzQ0npzN2KgSn4p98y+PlfaOUYfJ8q MiHZkxDgeKTwKMdeb94ZuWvvHjJzbYbkWgyFCmfK4vu+gSxEe2JKouHd+20qcS5EmL 2D+b2AsI0/EOTLomxPi9GbZQaPEgvMkd9repImwqs1nCvQu/ewYc42cb30bmjMPIVE 8cxGSpaMEplkHnt1ms9x//IYOJooxZYglX9lSOEF74ZmHa6H0exHTPfZGcnMPgLKmX GoqRlJkxuuWEwrdRkqrf/IvimYLufFY7IuheLdO7NhDkgMWHvnQujkLbqpNDtoRsUM eo5p7kBXuPE5g== From: Christian Brauner To: Nathan Chancellor Cc: Christian Brauner , Hongbo Li , Richard Weinberger , Anton Ivanov , Johannes Berg , linux-um@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] hostfs: Add const qualifier to host_root in hostfs_fill_super() Date: Thu, 13 Jun 2024 14:12:35 +0200 Message-ID: <20240613-saugt-hebamme-d4c3ce553856@brauner> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240611-hostfs-fix-mount-api-conversion-v1-1-ef75bbc77f44@kernel.org> References: <20240611-hostfs-fix-mount-api-conversion-v1-1-ef75bbc77f44@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1319; i=brauner@kernel.org; h=from:subject:message-id; bh=VL0D7Z1u35TJY1+wnfk182tojLh6CXU2VOnnleoOGPo=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMaRlPTJl7Lx9xSXxXb9yu8pj2Z/nCqc7aanzPg2cw3ju2 MfjE8/YdpSyMIhxMciKKbI4tJuEyy3nqdhslKkBM4eVCWQIAxenAExkZhjD/6CIcu9Iid/76itk z7yIyQ3mCVozyUd+3nfxH2+rbUPX/GRkaL6YaCTI0Vpr9XFtuGPRn+uKU/Tm5DT+ar60P+R+ofg jFgA= X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 Content-Transfer-Encoding: 8bit On Tue, 11 Jun 2024 12:58:41 -0700, Nathan Chancellor wrote: > After the recent conversion to the new mount API, there is a warning > when building hostfs (which may be upgraded to an error via > CONFIG_WERROR=y): > > fs/hostfs/hostfs_kern.c: In function 'hostfs_fill_super': > fs/hostfs/hostfs_kern.c:942:27: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] > 942 | char *host_root = fc->source; > | ^~ > > [...] Applied to the vfs.mount.api branch of the vfs/vfs.git tree. Patches in the vfs.mount.api branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.mount.api [1/1] hostfs: Add const qualifier to host_root in hostfs_fill_super() https://git.kernel.org/vfs/vfs/c/104eef133fd9