Received: by 2002:a89:413:0:b0:1fd:dba5:e537 with SMTP id m19csp107062lqs; Thu, 13 Jun 2024 05:28:15 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVAuQw0teV7qVoTVBqUeCYpModNL6BWX3ESqASj+mwMj+x9Ix864TMkVhKSnA6dxL2bmkRihcrId0SEJP5KlwoJg3NYn0dEQm4GBOiKsQ== X-Google-Smtp-Source: AGHT+IHnHlQ5PTFrzYyaalLW/SgSNw6M5dSaThss8k1mZARYee9/TzSvE7u1LCDVRAjNbF03NQmt X-Received: by 2002:a05:6a00:1415:b0:705:9c4f:e0da with SMTP id d2e1a72fcca58-705bcee100emr4894438b3a.32.1718281695360; Thu, 13 Jun 2024 05:28:15 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718281695; cv=pass; d=google.com; s=arc-20160816; b=gg1qM80sTFNEZoP5xul3GIMUcSpzpOnnsfEkug1fQ31eQ2H4L7y5nZMk1/qy7DayJh C3bQxy7maeVRMs3AuxNXanhKxIWwRk/29K18H4TK4dE9vx/IUEluPEeTGCdYX9z6kIbQ B0ZTHayWaC7/5nOmofvE20SwFqaOg69rz0weG1EZvNM0gDCDDelpsxwSnkYpmZjPPhk7 UZC240R6yNAUTcsj9cwdYN3SVhDQkXzruSkS99wkGepJRVSzBg0B70bjGyQGTIejhZG3 XZA0z2rn0bPrDpLxB3+IJwsYbC2VSkzpSQ2dRenGk27kUb9B8InCbMZi2gPjV/mKaHk3 YGOA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=y9PvvqPgKOXCPbOZfATBsjBIEGefCubkdSOft2h04w8=; fh=00cvKZUvXBpz6I9dyx+/aWnAKhz2Z8URfKOUb28Mrts=; b=eYb9pZo/RRRsPBiVTHyCz4HOyKkQ0CQRwFDsDcZpD2Bv3ykKo1fJ3ZWPmFrb7cMrv2 8A2+iFqHlsVq1+rf4qsdF/QiclmSg/gJxAm5CxQoDrzFW+VLdARzjP1fWNyquxqwAqpd s9nKAQ3+8wikOAAlEAmUjEYX6XrnwHy5hWXBcqRMWIQvj5thE0a5YVsfaSp/a3BjtqMo R8QpXpfWmCNAbmAjvLMSDDlI+WDiEOaFC0cb3nLswu34FUSPpQWhKLMblxAO2EqDHSot rNZd+RUSYf6Q69elPOZ1ZH9pANjHi8YonOHToRcqhA6GuUTti5hJUOsvBsdyWNCouhJ6 Xs6Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=T1OeiUEZ; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-213165-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-213165-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id 41be03b00d2f7-6fedd4f3fd0si1270432a12.174.2024.06.13.05.28.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jun 2024 05:28:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-213165-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=T1OeiUEZ; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-213165-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-213165-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 4F343B23DA5 for ; Thu, 13 Jun 2024 12:07:37 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 20BBA145B03; Thu, 13 Jun 2024 12:02:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="T1OeiUEZ" Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3F0314386B; Thu, 13 Jun 2024 12:02:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718280145; cv=none; b=jB19DsYCYl8PkV6Sqmz0wpPJmO+dtV+ijtF9OtC5ljXrAtvbDiWBPvKXeL2S4ktinyd4hwUzrGbSShtX0rqIJq40EpLAqWb4ikJLjIa+Y3oUWzhkqo/uzbMrjpSRjmYLRS6suzdhvO3+HY00xxiLVFNJEF69SPC7eIsy3mhBHSs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718280145; c=relaxed/simple; bh=qS/QOH6yJijp+eK1nFIeOEOD0OR6fVC/5+/H8ohrMtQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ISVvOBpVzyI5jVdKurVdWbmYnG+bXtLfuA/jfplOzSM/1+4hUoNWUNbPbfZGw5guYiNV0tjrH3IN+TPMFl1Q3b2pfxk+Mjc10W1WLJuAsRJ89rY38v9bF/xu205vme0MHO4KU/skOPHs2wL0q4lMwhn4up1K5jkQeakTpwLjVsM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=T1OeiUEZ; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-57c68c3f8adso980730a12.1; Thu, 13 Jun 2024 05:02:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718280142; x=1718884942; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=y9PvvqPgKOXCPbOZfATBsjBIEGefCubkdSOft2h04w8=; b=T1OeiUEZIqWCND74cevukEzUvpsjn8xl2F7qnK6YMm3wSkDmbnmwr5/hKIInFNzueY 7ULMc44PmzUzu8UWvZeQ0IQDl30kLcbiwUxtL852E3EYpgTrllhpr5h1/5qDNyNRlyd9 Z9CUizBgVp7l/a+fdxZxn68x60biMH/UpkjB3MJAtvIWv+b63YgW4jGhnwHW1tZAkWpf Y0j2uKw6FLo8WZ2GTqMIE8YuGnkPOqkinovl8716L9imZWJtm8Qnz7pgXnUBdwbx8jdh 7SmAwkgmZBeQnu2mluot7WlSJVJxNlXAQVVdDl/KZdvgqHptwVWA3CW5XwO223tQjX2I bB9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718280142; x=1718884942; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=y9PvvqPgKOXCPbOZfATBsjBIEGefCubkdSOft2h04w8=; b=QxWLFxQ+zxadJ7/hmy8OowFWxIJCtvhhJmJ3t6Vx1Rxg89u60xzhQw64lnvEP8wRYG +8i6JtJpOoEmdvBpw3DBPUszA4xcpIug5txEGFjSmMgpP4CsSYaxyxdAVbJpAoEYM0eT glFwlKBUbqqx8TZxINniFxit197CxRCT5Wp32ExaRvGI1NMC1lWzS22xpqNuZgTyc1dV 2bUfU+9oDdO521cBCcUEbUzFYoN3/pecDuz2Rxjv4eIV5G1FS/RKzgSClIY7Zv077vWZ njMeDxG+GYl3XS4I1oViutSoIAVS+PqjwCbQHJzmaNTV5XVahAc6pkbQpvTftVxgIixP QEhA== X-Forwarded-Encrypted: i=1; AJvYcCXrBQ/3OImUrxrBv83lHGTaCKcqIIp2tMi9Qj5JQj6pfupwTZs4h+sDc8rIfLbOfaAbV1Dyzm0gQyr+9FErBVFGoP30DVI9cWP/gAa58khbUfjeap8c6SVs9bUscyW0E8pvq8M6mAPPRNzjmNR+BnMmWZFCy/j0Qe7dyJWnOLLNaQ== X-Gm-Message-State: AOJu0Yy/X77OWZ1R577Z5WlZuS4jgHBXVEJU5IoD3K9y4feV1K+X4whE 1SfvaUbwMvoNIeNuiUmfCL7PXEYp9iQOqAUfj/NN7TMV7UwQz98W X-Received: by 2002:a50:8d52:0:b0:57c:55f6:b068 with SMTP id 4fb4d7f45d1cf-57caa9bee1cmr4116345a12.32.1718280141816; Thu, 13 Jun 2024 05:02:21 -0700 (PDT) Received: from skbuf ([188.25.55.166]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-57cb72e9dd7sm824738a12.57.2024.06.13.05.02.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jun 2024 05:02:21 -0700 (PDT) Date: Thu, 13 Jun 2024 15:02:18 +0300 From: Vladimir Oltean To: Martin Schiller Cc: martin.blumenstingl@googlemail.com, hauke@hauke-m.de, andrew@lunn.ch, f.fainelli@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v5 11/12] net: dsa: lantiq_gswip: Update comments in gswip_port_vlan_filtering() Message-ID: <20240613120218.yem27x7sf3yld3bv@skbuf> References: <20240611135434.3180973-1-ms@dev.tdt.de> <20240611135434.3180973-12-ms@dev.tdt.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240611135434.3180973-12-ms@dev.tdt.de> On Tue, Jun 11, 2024 at 03:54:33PM +0200, Martin Schiller wrote: > From: Martin Blumenstingl > > Update the comments in gswip_port_vlan_filtering() so it's clear that > there are two separate cases, one for "tag based VLAN" and another one > for "port based VLAN". > > Suggested-by: Martin Schiller > Signed-off-by: Martin Blumenstingl > Acked-by: Hauke Mehrtens > --- Needs your sign off. Reviewed-by: Vladimir Oltean