Received: by 2002:a89:413:0:b0:1fd:dba5:e537 with SMTP id m19csp108720lqs; Thu, 13 Jun 2024 05:31:10 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUgasmnQBN/zO+r9tY1lqQc9aNwhoy0mtzZ+VdwdD6/KwDpMeXsqNZvxOZSK4mUWIyG2GAd3tSbBJa/XrtGU5GzqYhYVOWSz4inAbMcJQ== X-Google-Smtp-Source: AGHT+IGVooNW8rmRWsF7RnjrJ1Jm8ZPvm9qZ5xbLMIjd4c6WsicqfNF0j1LWjvem/7l/7bN+g7jB X-Received: by 2002:a17:90a:1fc3:b0:2c3:1234:8bbb with SMTP id 98e67ed59e1d1-2c4a76dfe02mr4686158a91.38.1718281869809; Thu, 13 Jun 2024 05:31:09 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718281869; cv=pass; d=google.com; s=arc-20160816; b=czYHbTBZHTugPgU6CldCyCBPc0agg801RFc75yO6R3Xe5Qdq8wRfAb1usR2Ns83Slz OaU9U3Q188nrh0cvRWG3vszjk0IH75mxOIkYnJzjUPBAyyQsgef5qQlNOpdBxL1lVpPR z4RlrAEQpSj+X3QeJogWIO5Z5+qdOAtsT0DMkW0IiOQWRO5qmA4zT70D9dJh5Ogoxvhw F8Fpm9zLW4NwMiFsI6tYXo+KLqSJxp4D5FrJIiJblPTaiArcyyfXSU8RYGEo/1Pom3Aa JfnI2CaIJ7r8RpOElxiZosUyXbTQuIJLh7HpjQb/BJ0P21z6earQeRYewg1TrgneJ6lE RDlQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=+HhHJLglFbclh4Q0JlYYCqlLbDDYKX312f1pyXPhrks=; fh=4hzGS2mJhBYtPaN+9Ghgd8olLn6XlibSqa7YTErg1LA=; b=IGjy8aOx5uFSMkEiH5EI9Y/r9qAOORXGjcfjMyabn9J1+9aXsupfgMF+MQoBBOMGY8 tZnduYhxbryZ3oUKTd3FkRd7FvGNyyHgmkxHPKMYkHyG4CiIA1VYpL4SdGLgGHFQ/0PJ nLNWvKZb1ZOwliBvzAkt5/Jah5u+xGupOduDsFYAUfRlfn5FsB7CQNJN7RmG9sJed03w tJDQ7ZUo7yN/sf1CSTOQ0roYukmaRoP/prEsWu3CMW0EDtx/PF5JABf/17IFIOF1Nxrh InQuNLwaQXzgjzroCsdANv4ZgX7Su7YUgscqcfuwAexGD9YEZxIUWT/RVbQ6JaNVHwJs Za1Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lHcmG3o3; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-213169-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-213169-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id 98e67ed59e1d1-2c4a75de968si3540175a91.32.2024.06.13.05.31.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jun 2024 05:31:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-213169-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lHcmG3o3; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-213169-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-213169-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 30717B27A15 for ; Thu, 13 Jun 2024 12:09:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 02489146A72; Thu, 13 Jun 2024 12:04:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lHcmG3o3" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FAD714659E; Thu, 13 Jun 2024 12:04:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718280267; cv=none; b=LjZaaGxim17a+OpgILSyI+a7LVmfpJs7N5vkEsx8YiOOf5B+RcHXWs3ZyLAvvr1huj3SjP4wEB701iaP+KnU262Un3xwM2dwwUj8bC2fkdCaMbptQuchLgq7lQ4QJ9FQgLNpaa1O782AVjQkDzqoshPl+EWfK9o+dencUQopCxY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718280267; c=relaxed/simple; bh=FeKv081F4ryjfkLhJLQQcMa4OiwLi8c45XnRk6gnceA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kSqnaCIjbep9YWJO2eF/JH4yW4DC/qpwOvhHSUZxw5caqpANmGCu9m+cMFmONuCPydqCbXTtNtWdzXZ5gMUuxLsb1GhvMcZVjHZklB2tLNrzcvmlJWeBrG3N8F0KvIU2lIEF+K++lznaAhKmsXM1gAQ8Ay07OgwuKWSf3h2dgps= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lHcmG3o3; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id C03ADC4AF1A; Thu, 13 Jun 2024 12:04:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718280266; bh=FeKv081F4ryjfkLhJLQQcMa4OiwLi8c45XnRk6gnceA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lHcmG3o3Ae4kxCS7Qji7JK4J5MToPvmI6f+fy47XcIFafwVOyqvG5eSDGEl0nHcPH tW+zNxcr55Qm3cLJcTiX5fOJb/nVF5Iys9qekUYNYocqlkoAiFdQPjMAVhIv/7t3hQ Sj58yWpmkg9N4JNz3Ry0PY6gyazKtuj697ZdZpvJivmqwfSwevUlnpRECs/SrpvZ6d dA7QoYX2KSDVzlEW4iDcAAf6G05h52vI/9LJOYwRNz7u7h6Bs0NOKvJsji7je2d+td Q2Afo0MiFgk1ZOxVPPoBi6UlxN3FM4nbB+k4Y/b04kQ3NyNwp/yHjwNp0/ozV3pQz3 OaOBftj/DrykA== Date: Thu, 13 Jun 2024 13:04:20 +0100 From: Lee Jones To: Andre Przywara Cc: Chen-Yu Tsai , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, Jernej Skrabec , Samuel Holland , Ryan Walklin , Chris Morgan , Philippe Simons Subject: Re: [PATCH v2 1/5] mfd: axp20x: AXP717: Fix missing IRQ status registers range Message-ID: <20240613120420.GO1504919@google.com> References: <20240418000736.24338-1-andre.przywara@arm.com> <20240418000736.24338-2-andre.przywara@arm.com> <20240502093907.GM5338@google.com> <56aef347-7582-497e-be02-d82eda7b3528@arm.com> <20240612152510.GE1504919@google.com> <7fdc23ff-fd55-4347-ac61-dd115eff6ff1@arm.com> <20240612154817.GH1504919@google.com> <8a968327-131d-40f1-b6e2-effe1390ef70@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8a968327-131d-40f1-b6e2-effe1390ef70@arm.com> On Thu, 13 Jun 2024, Andre Przywara wrote: > Hi Lee, > > On 12/06/2024 16:48, Lee Jones wrote: > > On Wed, 12 Jun 2024, Andre Przywara wrote: > > > > > Hi, > > > > > > On 12/06/2024 16:25, Lee Jones wrote: > > > > On Wed, 12 Jun 2024, Andre Przywara wrote: > > > > > > > > > Hi Lee, > > > > > > > > > > On 02/05/2024 10:39, Lee Jones wrote: > > > > > > On Thu, 18 Apr 2024, Andre Przywara wrote: > > > > > > > > > > > > > While we list the "IRQ status *and acknowledge*" registers as volatile, > > > > > > > they are missing from the writable range array, so acknowledging any > > > > > > > interrupts was met with an -EIO error. > > > > > > > > > > > > > > Add the five registers that hold those bits to the writable array. > > > > > > > > > > > > > > Fixes: b5bfc8ab2484 ("mfd: axp20x: Add support for AXP717 PMIC") > > > > > > > Reported-by: Chris Morgan > > > > > > > Signed-off-by: Andre Przywara > > > > > > > --- > > > > > > > drivers/mfd/axp20x.c | 1 + > > > > > > > 1 file changed, 1 insertion(+) > > > > > > > > > > > > Acked-by: Lee Jones > > > > > > > > > > Can you please take just this patch as a fix for 6.10? This fixes the power > > > > > key operation. > > > > > This applies cleanly on top of v6.10-rc3, so there is no need for any extra > > > > > immutable branch or coordination with regulator. > > > > > (The same is true independently for patch 2/5, on the regulator side). > > > > > > > > What does the Fixes: commit break? > > > > > > > > Or is it the case that it never worked properly? > > > > > > The interrupt part never worked properly, but so far that's only needed for > > > the power key operation. Unfortunately that part wasn't tested properly > > > initially, so the patches were merged into your tree before that. > > > > This doesn't sounds like a -fixes candidate. I'll mark the set for v6.11. > > Sorry, correction, this patch missing is actually fatal now, since we have > an interrupt connected in the DT (which wasn't there initially). The code > tries to clear all IRQs upon driver probe, which fails due to regmap > error-ing out. This makes the whole driver fail probing, and since the AXP > supplies basically every peripheral, the system is dead in the water: > > [ 1.173014] sunxi-rsb 7083000.rsb: RSB running at 3000000 Hz > [ 1.174996] axp20x-rsb sunxi-rsb-3a3: AXP20x variant AXP717 found > [ 1.198931] axp20x-rsb sunxi-rsb-3a3: Failed to ack 0x49: -5 > [ 1.220878] axp20x-rsb sunxi-rsb-3a3: failed to add irq chip: -5 > [ 1.235760] axp20x-rsb sunxi-rsb-3a3: > > (Thanks to loki666@IRC for providing the log!) > > This was discovered early, long before the merge window, and I was actually > hoping to have this patch squashed into the original series still, but there > was this immutable branch already. > > So can you please take this as a fix for 6.10? Please draft a new patch (the diff is likely to be the same) with an updated commit message describing the new problem and why it's required for -fixes. I'll then submit it to Linus. -- Lee Jones [李琼斯]