Received: by 2002:a89:413:0:b0:1fd:dba5:e537 with SMTP id m19csp110453lqs; Thu, 13 Jun 2024 05:34:04 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWehQJK0mqYLzy3YFOvdnyKwZFDMGSQl0GBsB0alF4BHiccIIk/61E5v2djjKdtR48cWJS2NilLLA4AHJ0yMwDuI8euv0XLXSYRS2g34A== X-Google-Smtp-Source: AGHT+IEz5amT6mC4lBIKE287u1VVtqabm1plsj4gbnr9rSCn1MPtWBXjyRs7Ot8YtJ+RIwCOFBTC X-Received: by 2002:a17:906:e0d:b0:a6f:45b7:f69e with SMTP id a640c23a62f3a-a6f47d34e3amr279003766b.20.1718282043852; Thu, 13 Jun 2024 05:34:03 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718282043; cv=pass; d=google.com; s=arc-20160816; b=dc1030tHkt0h8F78g27UKN8pvpmzo367PKPcGav5LiD53YQxFpfKvPDAmLKjG1dSx7 o9f6LqgrgsNqXuYW7GpAbnZY3GN8H1UGc4cf9kfs2jp1wWuUuR00VaMIBmbYnEDW+LA9 XnaYmsGVsAkY4cRpzM+1c/IUUlEI28XJUKEucm0C3Y2ywqLziY3FdMidj41mKkiiZvkD iVtueLxaDz9hDy26vBa2n12qdJ9V1u4of39lGDvLtZHP0G+yXE14Jw7lw68ardbWbQ0g USYKsCHkKAx0sNBX9cuLrKoCSTbIk20bsGjU0SVGj7ArTfur+V40OQqiX2C7+MJmTdXL 70pQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:message-id:references:in-reply-to:organization:subject :cc:to:from:date:content-transfer-encoding:mime-version :list-unsubscribe:list-subscribe:list-id:precedence; bh=rALxiyDxqy5oTOFApw/3O/rr6oaU/UoUjtDmMp7jkJw=; fh=tZs145GEaRpRPd94tXd2oOgS8dsYTYmNF2MdEJfhwBc=; b=0yA1H1hQBZP3QJiFU/zlH0fnxNzzk22+GDj1VOJjFSIiKdLpUP1g0Kb5vMG9OoDazQ NHOI9P0RZS2Fv2ig99TWo03KB1jv+5dAhV/d2RpEKw0x+t1q7my5ljQlAMtU7ViIDaWO nrt4RD/6koL3vMeKY5GNeBBZJboc2mfaVt3wGjlJQ+BsCAFzVvyeQi6457HfO4nSlBo9 cPgcDCdiVId3sPJ4VCnr9NiNxWyrziHHFx0HejoQ+6Ou3mE3Wr/1k6oDCDzh8gmJHV38 4VX42evzdlooSwoNKvsWuZKz/Vpka77QDduYWVFXuNCCtAJnItXGlNmxi5x3Cf7JWfIZ 2M3w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=dev.tdt.de); spf=pass (google.com: domain of linux-kernel+bounces-213209-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-213209-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id a640c23a62f3a-a6f56dd66d9si63804866b.406.2024.06.13.05.34.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jun 2024 05:34:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-213209-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=dev.tdt.de); spf=pass (google.com: domain of linux-kernel+bounces-213209-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-213209-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 7A4051F218EE for ; Thu, 13 Jun 2024 12:34:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5A1A71448C5; Thu, 13 Jun 2024 12:33:18 +0000 (UTC) Received: from mxout70.expurgate.net (mxout70.expurgate.net [91.198.224.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D92E13E3F9; Thu, 13 Jun 2024 12:33:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.198.224.70 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718281997; cv=none; b=PRL+LnUiAYqUq38MTSC6numaDMgovg8Xx47wg9cyN/fhSuuNABK70eD59EPIcUrP1lanOwSLV/HFcvFnSOsg7HZZMSsyzE6UMIq2nMBPngqiQacth+SeY93AGTuWB/EEYrCHs07UTVR38ixyHatB7C1uHRYISb/SjC26b5G2ig4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718281997; c=relaxed/simple; bh=ULg8Fs3ylKzlzeu4L15VUpi6+aXnakKnXxBv8V2L7ac=; h=MIME-Version:Content-Type:Date:From:To:Cc:Subject:In-Reply-To: References:Message-ID; b=ilFwWLLEY6fDn9RKUsK+iXZF0m3vOf3SI6Nka+io3XKb0Dm7X/SHTwbnJIBF1SRuPpLNwdp5+QsmdRkq79jI1SkhcOmcnuhBtP2/mtcV+6Hzk1dU8582umaU6HBTD/pIKENDYpoEXU+pXr1IDLxRHXk0fMQjmu7OUXUEbYi64FM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dev.tdt.de; spf=pass smtp.mailfrom=dev.tdt.de; arc=none smtp.client-ip=91.198.224.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dev.tdt.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dev.tdt.de Received: from [127.0.0.1] (helo=localhost) by relay.expurgate.net with smtp (Exim 4.92) (envelope-from ) id 1sHjdc-002CGp-PB; Thu, 13 Jun 2024 14:33:08 +0200 Received: from [195.243.126.94] (helo=securemail.tdt.de) by relay.expurgate.net with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sHjdc-000WTx-7V; Thu, 13 Jun 2024 14:33:08 +0200 Received: from securemail.tdt.de (localhost [127.0.0.1]) by securemail.tdt.de (Postfix) with ESMTP id E9337240053; Thu, 13 Jun 2024 14:33:07 +0200 (CEST) Received: from mail.dev.tdt.de (unknown [10.2.4.42]) by securemail.tdt.de (Postfix) with ESMTP id 7E5D1240050; Thu, 13 Jun 2024 14:33:07 +0200 (CEST) Received: from mail.dev.tdt.de (localhost [IPv6:::1]) by mail.dev.tdt.de (Postfix) with ESMTP id 2CCC53852A; Thu, 13 Jun 2024 14:33:07 +0200 (CEST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 13 Jun 2024 14:33:07 +0200 From: Martin Schiller To: Vladimir Oltean Cc: martin.blumenstingl@googlemail.com, hauke@hauke-m.de, andrew@lunn.ch, f.fainelli@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v5 05/12] net: dsa: lantiq_gswip: Don't manually call gswip_port_enable() Organization: TDT AG In-Reply-To: <20240613115226.luvvmfwsdkp6bmx3@skbuf> References: <20240611135434.3180973-1-ms@dev.tdt.de> <20240611135434.3180973-6-ms@dev.tdt.de> <20240613115226.luvvmfwsdkp6bmx3@skbuf> Message-ID: X-Sender: ms@dev.tdt.de User-Agent: Roundcube Webmail/1.3.17 X-purgate: clean X-purgate-type: clean X-purgate-ID: 151534::1718281988-F1CA462D-6B8E3CDD/0/0 On 2024-06-13 13:52, Vladimir Oltean wrote: > On Tue, Jun 11, 2024 at 03:54:27PM +0200, Martin Schiller wrote: >> From: Martin Blumenstingl >> >> We don't need to manually call gswip_port_enable() from within >> gswip_setup() for the CPU port. DSA does this automatically for us. >> >> Signed-off-by: Martin Blumenstingl >> >> Acked-by: Hauke Mehrtens >> --- > > Needs your sign off. > > Reviewed-by: Vladimir Oltean Signed-off-by: Martin Schiller