Received-SPF: pass (google.com: domain of linux-kernel+bounces-213210-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Thu, 13 Jun 2024 14:34:38 +0200
From: Martin Schiller <ms@dev.tdt.de>
To: martin.blumenstingl@googlemail.com, hauke@hauke-m.de, andrew@lunn.ch,
 f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net,
 edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org,
 krzk+dt@kernel.org, conor+dt@kernel.org
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v5 07/12] net: dsa: lantiq_gswip: Use
 dsa_is_cpu_port() in gswip_port_change_mtu()
Organization: TDT AG
In-Reply-To: <20240611135434.3180973-8-ms@dev.tdt.de>
References: <20240611135434.3180973-1-ms@dev.tdt.de>
 <20240611135434.3180973-8-ms@dev.tdt.de>
Message-ID: <731687d5beaa7a6d9fa40cdc83ace829@dev.tdt.de>
User-Agent: Roundcube Webmail/1.3.17

On 2024-06-11 15:54, Martin Schiller wrote:
> From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> 
> Make the check for the CPU port in gswip_port_change_mtu() consistent
> with other areas of the driver by using dsa_is_cpu_port().
> 
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
> Acked-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---
>  drivers/net/dsa/lantiq_gswip.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/dsa/lantiq_gswip.c 
> b/drivers/net/dsa/lantiq_gswip.c
> index 8ec329d0c136..58c069f964dd 100644
> --- a/drivers/net/dsa/lantiq_gswip.c
> +++ b/drivers/net/dsa/lantiq_gswip.c
> @@ -1464,12 +1464,11 @@ static int gswip_port_max_mtu(struct
> dsa_switch *ds, int port)
>  static int gswip_port_change_mtu(struct dsa_switch *ds, int port, int 
> new_mtu)
>  {
>  	struct gswip_priv *priv = ds->priv;
> -	int cpu_port = priv->hw_info->cpu_port;
> 
>  	/* CPU port always has maximum mtu of user ports, so use it to set
>  	 * switch frame size, including 8 byte special header.
>  	 */
> -	if (port == cpu_port) {
> +	if (dsa_is_cpu_port(ds, port)) {
>  		new_mtu += 8;
>  		gswip_switch_w(priv, VLAN_ETH_HLEN + new_mtu + ETH_FCS_LEN,
>  			       GSWIP_MAC_FLEN);

Signed-off-by: Martin Schiller <ms@dev.tdt.de>