Received-SPF: pass (google.com: domain of linux-kernel+bounces-213211-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Thu, 13 Jun 2024 14:35:09 +0200
From: Martin Schiller <ms@dev.tdt.de>
To: martin.blumenstingl@googlemail.com, hauke@hauke-m.de, andrew@lunn.ch,
 f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net,
 edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org,
 krzk+dt@kernel.org, conor+dt@kernel.org
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v5 08/12] net: dsa: lantiq_gswip: Change literal
 6 to ETH_ALEN
Organization: TDT AG
In-Reply-To: <20240611135434.3180973-9-ms@dev.tdt.de>
References: <20240611135434.3180973-1-ms@dev.tdt.de>
 <20240611135434.3180973-9-ms@dev.tdt.de>
Message-ID: <234a55f08593f7c8d003d87b3ff1aac9@dev.tdt.de>
User-Agent: Roundcube Webmail/1.3.17

On 2024-06-11 15:54, Martin Schiller wrote:
> From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> 
> The addr variable in gswip_port_fdb_dump() stores a mac address. Use
> ETH_ALEN to make this consistent across other drivers.
> 
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
> Acked-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---
>  drivers/net/dsa/lantiq_gswip.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/dsa/lantiq_gswip.c 
> b/drivers/net/dsa/lantiq_gswip.c
> index 58c069f964dd..525a62a21601 100644
> --- a/drivers/net/dsa/lantiq_gswip.c
> +++ b/drivers/net/dsa/lantiq_gswip.c
> @@ -1413,7 +1413,7 @@ static int gswip_port_fdb_dump(struct dsa_switch
> *ds, int port,
>  {
>  	struct gswip_priv *priv = ds->priv;
>  	struct gswip_pce_table_entry mac_bridge = {0,};
> -	unsigned char addr[6];
> +	unsigned char addr[ETH_ALEN];
>  	int i;
>  	int err;

Signed-off-by: Martin Schiller <ms@dev.tdt.de>