Received: by 2002:a89:413:0:b0:1fd:dba5:e537 with SMTP id m19csp112798lqs; Thu, 13 Jun 2024 05:38:34 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUJQ+5SEO1ktnySj8abUN5Lx+N0iPPXTZxtQE0IFmrGGlp6rIIYV7++8A6cDtpFJQk3mLs+R1IF9E8QEO3992aDfrptVAyM+4ABsEszSQ== X-Google-Smtp-Source: AGHT+IEZrLfJfGFUvu0iXmapJNP2rVCODyR/jmMZnUxCyK2QT9pRU7lBrR32uRqTx/ZjZDRnwutF X-Received: by 2002:a17:902:b209:b0:1f6:fc06:a2ff with SMTP id d9443c01a7336-1f83b74f759mr37108115ad.59.1718282313961; Thu, 13 Jun 2024 05:38:33 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718282313; cv=pass; d=google.com; s=arc-20160816; b=YJNeX8Fiv4/IzM/E9i3zPaZ/H/XxCmqUDZkmmKVtLoDj1uhvU8462oXjWEW5Kj+BIV hHD0eU+iJpLwPhAjO6SgPyWtpRDDcyNOxxLF3Ofu71hjl3MXknZWPr45SwRP8BAC1P/P TEeb2qQi6tvihebw65XacWs2gDalriKy3rnox/OzsNbvwuxGRMpeXnJq1TNpV3pqy5+u 2bZY4MfnXL2LBZ1GPfCUi7bBIRxpYtR2D0tQtPGIaA+Y8raYFZqk/YRsMBZNvzr60RWr OK/px7w4mbe0gELvbStGDG4WRQxcBP70O5ZgLrBMziUZIZ8+aU4xmPEhcfMGSRqrh9vu NXTw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:message-id:references:in-reply-to:organization:subject :cc:to:from:date:content-transfer-encoding:mime-version :list-unsubscribe:list-subscribe:list-id:precedence; bh=HMHd+dkdu/7tYM6dILLiF1MVWxhuuY54mUF3DULKHY0=; fh=tZs145GEaRpRPd94tXd2oOgS8dsYTYmNF2MdEJfhwBc=; b=I6GeKV/VQJCHsIiGFY8OS3gleN5OMF4c/2zn81klIxwWuT6odzepj3hm9pADW8euAE zcscakXh+gficHdj7LnZJJ1wvTvauKbUJHRstMgniYxpIxw9ha1GAexRy+i5yz58DRzz AYTWklmGQXGsAe409JZhV9mXDQHZ2DfWOLSRi4lOqMkoVi46Nn3FlgCSrpWMjdaWxwXR Bjav4FgAQ64GWP+zi7EoBQcyBqacGtC3r9qIH5A2KEdCFTuujY04fkxqv15UtMdOUn12 ZzndgIW7ABShza7qb3HLFRjiWug1ciNm+Kt5LsGDrWndPD+4rKMXFbb/2mEJ4CJFphBn X6LQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=dev.tdt.de); spf=pass (google.com: domain of linux-kernel+bounces-213217-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-213217-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id d9443c01a7336-1f855e535b5si11844085ad.165.2024.06.13.05.38.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jun 2024 05:38:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-213217-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=dev.tdt.de); spf=pass (google.com: domain of linux-kernel+bounces-213217-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-213217-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id E4BB7281816 for ; Thu, 13 Jun 2024 12:38:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 409B81448E0; Thu, 13 Jun 2024 12:37:35 +0000 (UTC) Received: from mxout70.expurgate.net (mxout70.expurgate.net [91.198.224.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66598142654; Thu, 13 Jun 2024 12:37:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.198.224.70 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718282254; cv=none; b=XaDMs/wWeY+CvFjaFV0agy5K+co3fOvku6/EEde7w9g8BPYWLzHB7wQsvVochbfoOzCz08wqwuN8vr4Rg8F9tmBSbRsS0uVAYzPXlEEgdk4gaxFYhxG8tgldeCguHzv6XM/hWgNFLs3HQJj/b+10wcy8xnB0y1W5o9zORQ6+PX8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718282254; c=relaxed/simple; bh=j/mjhU1X2GxfRi8fOLaRUoOXPbNo3HzwBNVoqGZBIZo=; h=MIME-Version:Content-Type:Date:From:To:Cc:Subject:In-Reply-To: References:Message-ID; b=poLKYadMk0RFkmz9DUcmdhboHmxb8xv0pRsWXSh5kWpxQmWlRANM6nbU/eVDmjHUTWi1Efjfz47NFK1R4Wi4e7zp4qm9kzhsJVZ8WajJnn3wEwSISyWtstCOlR+yMzGxfy2PNKJBduQSb7NOvpWqIbXp/VX81I/7u2PXjVWbBFg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dev.tdt.de; spf=pass smtp.mailfrom=dev.tdt.de; arc=none smtp.client-ip=91.198.224.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dev.tdt.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dev.tdt.de Received: from [127.0.0.1] (helo=localhost) by relay.expurgate.net with smtp (Exim 4.92) (envelope-from ) id 1sHjhq-003Fy7-5c; Thu, 13 Jun 2024 14:37:30 +0200 Received: from [195.243.126.94] (helo=securemail.tdt.de) by relay.expurgate.net with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sHjhp-003EDT-KM; Thu, 13 Jun 2024 14:37:29 +0200 Received: from securemail.tdt.de (localhost [127.0.0.1]) by securemail.tdt.de (Postfix) with ESMTP id 49844240053; Thu, 13 Jun 2024 14:37:29 +0200 (CEST) Received: from mail.dev.tdt.de (unknown [10.2.4.42]) by securemail.tdt.de (Postfix) with ESMTP id D0B67240050; Thu, 13 Jun 2024 14:37:28 +0200 (CEST) Received: from mail.dev.tdt.de (localhost [IPv6:::1]) by mail.dev.tdt.de (Postfix) with ESMTP id 8C2543852A; Thu, 13 Jun 2024 14:37:28 +0200 (CEST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 13 Jun 2024 14:37:28 +0200 From: Martin Schiller To: Vladimir Oltean Cc: martin.blumenstingl@googlemail.com, hauke@hauke-m.de, andrew@lunn.ch, f.fainelli@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v5 11/12] net: dsa: lantiq_gswip: Update comments in gswip_port_vlan_filtering() Organization: TDT AG In-Reply-To: <20240613120218.yem27x7sf3yld3bv@skbuf> References: <20240611135434.3180973-1-ms@dev.tdt.de> <20240611135434.3180973-12-ms@dev.tdt.de> <20240613120218.yem27x7sf3yld3bv@skbuf> Message-ID: <0deceb09e3b38f3e95bfc6f9e69a6392@dev.tdt.de> X-Sender: ms@dev.tdt.de User-Agent: Roundcube Webmail/1.3.17 X-purgate-type: clean X-purgate-ID: 151534::1718282250-34A72D11-E88E9E77/0/0 X-purgate: clean On 2024-06-13 14:02, Vladimir Oltean wrote: > On Tue, Jun 11, 2024 at 03:54:33PM +0200, Martin Schiller wrote: >> From: Martin Blumenstingl >> >> Update the comments in gswip_port_vlan_filtering() so it's clear that >> there are two separate cases, one for "tag based VLAN" and another one >> for "port based VLAN". >> >> Suggested-by: Martin Schiller >> Signed-off-by: Martin Blumenstingl >> >> Acked-by: Hauke Mehrtens >> --- > > Needs your sign off. > > Reviewed-by: Vladimir Oltean Signed-off-by: Martin Schiller