Received-SPF: pass (google.com: domain of linux-kernel+bounces-213305-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 13 Jun 2024 15:21:15 +0200
From: Halil Pasic <pasic@linux.ibm.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Cornelia Huck <cohuck@redhat.com>, Eric Farman <farman@linux.ibm.com>,
        Heiko Carstens <hca@linux.ibm.com>, Vasily Gorbik <gor@linux.ibm.com>,
        Alexander Gordeev <agordeev@linux.ibm.com>,
        Christian Borntraeger
 <borntraeger@linux.ibm.com>,
        Sven Schnelle <svens@linux.ibm.com>, linux-s390@vger.kernel.org,
        virtualization@lists.linux.dev, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, Boqiao Fu
 <bfu@redhat.com>,
        Sebastian Mitterle <smitterl@redhat.com>,
        Halil Pasic
 <pasic@linux.ibm.com>
Subject: Re: [PATCH 1/1] s390/virtio_ccw: fix config change notifications
Message-ID: <20240613152115.48b00798.pasic@linux.ibm.com>
In-Reply-To: <6086ef5e-48e7-40f3-b0a7-ff67b20aeae3@redhat.com>
References: <20240611214716.1002781-1-pasic@linux.ibm.com>
	<6086ef5e-48e7-40f3-b0a7-ff67b20aeae3@redhat.com>
Organization: IBM
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0

On Wed, 12 Jun 2024 16:04:15 +0200
Thomas Huth <thuth@redhat.com> wrote:

> On 11/06/2024 23.47, Halil Pasic wrote:
> > Commit e3e9bda38e6d ("s390/virtio_ccw: use DMA handle from DMA API")
> > broke configuration change notifications for virtio-ccw by putting the
> > DMA address of *indicatorp directly into ccw->cda disregarding the fact
> > that if !!(vcdev->is_thinint) then the function
> > virtio_ccw_register_adapter_ind() will overwrite that ccw->cda value
> > with the address of the virtio_thinint_area so it can actually set up
> > the adapter interrupts via CCW_CMD_SET_IND_ADAPTER.  Thus we end up
> > pointing to the wrong object for both CCW_CMD_SET_IND if setting up the
> > adapter interrupts fails, and for CCW_CMD_SET_CONF_IND regardless
> > whether it succeeds or fails.
> > 
> > To fix this, let us save away the dma address of *indicatorp in a local
> > variable, and copy it to ccw->cda after the "vcdev->is_thinint" branch.
> > 
> > Reported-by: Boqiao Fu <bfu@redhat.com>
> > Reported-by: Sebastian Mitterle <smitterl@redhat.com>
> > Fixes: e3e9bda38e6d ("s390/virtio_ccw: use DMA handle from DMA API")
> > Signed-off-by: Halil Pasic <pasic@linux.ibm.com>
> > ---
> > I know that checkpatch.pl complains about a missing 'Closes' tag.
> > Unfortunately I don't have an appropriate URL at hand. @Sebastian,
> > @Boqiao: do you have any suggetions?  
> 
> Closes: https://issues.redhat.com/browse/RHEL-39983
> ?

Yep! That is a public bug tracker bug. Qualifies!
@Vasily: Can you guys pick hat one up when picking the patch?

> 
> Anyway, I've tested the patch and it indeed fixes the problem with 
> virtio-balloon and the link state for me:
> 
> Tested-by: Thomas Huth <thuth@redhat.com>
> 

Thanks!