Received-SPF: pass (google.com: domain of linux-kernel+bounces-213315-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 13 Jun 2024 13:26:29 +0000
From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: mporter@kernel.crashing.org, alex.bou9@gmail.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rapidio: removse some dead defines
Message-ID: <ZmrzhW4_ANIfbOYk@gallifrey>
References: <20240528002515.211366-1-linux@treblig.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <20240528002515.211366-1-linux@treblig.org>
User-Agent: Mutt/2.2.12 (2023-09-09)

* linux@treblig.org (linux@treblig.org) wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'mport_dma_buf', 'rio_mport_dma_map' and 'MPORT_MAX_DMA_BUFS' were
> added in the original
> commit e8de370188d0 ("rapidio: add mport char device driver")
> but never used.
> 
> 'rio_cm_work' was unused since the original
> commit b6e8d4aa1110 ("rapidio: add RapidIO channelized messaging
> driver")
> but never used.
> 
> Remove them.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

Ping?

Dave

> ---
>  drivers/rapidio/devices/rio_mport_cdev.c | 20 --------------------
>  drivers/rapidio/rio_cm.c                 |  6 ------
>  2 files changed, 26 deletions(-)
> 
> diff --git a/drivers/rapidio/devices/rio_mport_cdev.c b/drivers/rapidio/devices/rio_mport_cdev.c
> index 27afbb9d544b..5c83741c3005 100644
> --- a/drivers/rapidio/devices/rio_mport_cdev.c
> +++ b/drivers/rapidio/devices/rio_mport_cdev.c
> @@ -97,18 +97,6 @@ module_param(dbg_level, uint, S_IWUSR | S_IWGRP | S_IRUGO);
>  MODULE_PARM_DESC(dbg_level, "Debugging output level (default 0 = none)");
>  #endif
>  
> -/*
> - * An internal DMA coherent buffer
> - */
> -struct mport_dma_buf {
> -	void		*ib_base;
> -	dma_addr_t	ib_phys;
> -	u32		ib_size;
> -	u64		ib_rio_base;
> -	bool		ib_map;
> -	struct file	*filp;
> -};
> -
>  /*
>   * Internal memory mapping structure
>   */
> @@ -131,14 +119,6 @@ struct rio_mport_mapping {
>  	struct file *filp;
>  };
>  
> -struct rio_mport_dma_map {
> -	int valid;
> -	u64 length;
> -	void *vaddr;
> -	dma_addr_t paddr;
> -};
> -
> -#define MPORT_MAX_DMA_BUFS	16
>  #define MPORT_EVENT_DEPTH	10
>  
>  /*
> diff --git a/drivers/rapidio/rio_cm.c b/drivers/rapidio/rio_cm.c
> index 9135227301c8..97287e838ce1 100644
> --- a/drivers/rapidio/rio_cm.c
> +++ b/drivers/rapidio/rio_cm.c
> @@ -198,12 +198,6 @@ struct cm_peer {
>  	struct rio_dev *rdev;
>  };
>  
> -struct rio_cm_work {
> -	struct work_struct work;
> -	struct cm_dev *cm;
> -	void *data;
> -};
> -
>  struct conn_req {
>  	struct list_head node;
>  	u32 destid;	/* requester destID */
> -- 
> 2.45.1
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/