Received-SPF: pass (google.com: domain of linux-kernel+bounces-213319-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 13 Jun 2024 13:28:57 +0000
From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: johan@kernel.org, gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: serial: spcp8x5: remove unused struct
 'spcp8x5_usb_ctrl_arg'
Message-ID: <Zmr0GV57EGwxcYeM@gallifrey>
References: <20240529234722.130609-1-linux@treblig.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <20240529234722.130609-1-linux@treblig.org>
User-Agent: Mutt/2.2.12 (2023-09-09)

* linux@treblig.org (linux@treblig.org) wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'spcp8x5_usb_ctrl_arg' has been unused since the original
> commit 619a6f1d1423 ("USB: add usb-serial spcp8x5 driver").
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

Ping?

Dave

> ---
>  drivers/usb/serial/spcp8x5.c | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/drivers/usb/serial/spcp8x5.c b/drivers/usb/serial/spcp8x5.c
> index 09a972a838ee..6b294bf8bc43 100644
> --- a/drivers/usb/serial/spcp8x5.c
> +++ b/drivers/usb/serial/spcp8x5.c
> @@ -49,16 +49,6 @@ static const struct usb_device_id id_table[] = {
>  };
>  MODULE_DEVICE_TABLE(usb, id_table);
>  
> -struct spcp8x5_usb_ctrl_arg {
> -	u8	type;
> -	u8	cmd;
> -	u8	cmd_type;
> -	u16	value;
> -	u16	index;
> -	u16	length;
> -};
> -
> -
>  /* spcp8x5 spec register define */
>  #define MCR_CONTROL_LINE_RTS		0x02
>  #define MCR_CONTROL_LINE_DTR		0x01
> -- 
> 2.45.1
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/