Received: by 2002:a89:413:0:b0:1fd:dba5:e537 with SMTP id m19csp149610lqs; Thu, 13 Jun 2024 06:35:56 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXNH4InXP4RBfz/g+sEZ36WjGAmtbsHZLCzWVfwihZWWN/XNeOxvvU0A1hrMV6xq6TeghK/2bK1wqiKIl0wihOP/0PdWVGzJ3NZzZbiQQ== X-Google-Smtp-Source: AGHT+IH6tRlqfeowEOdzKHK57WHijDdGV7roAOnblZZ+dwPAFuZI3OS1bLTTiZi6C09rvnXkESir X-Received: by 2002:a05:6a00:2e1e:b0:705:951e:ed84 with SMTP id d2e1a72fcca58-705bce42e51mr5339029b3a.15.1718285756703; Thu, 13 Jun 2024 06:35:56 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718285756; cv=pass; d=google.com; s=arc-20160816; b=Wp/sE4AEzTCHINc2hOiWCIxIrr9oHgAu7Hl4W6AJ3I7/7rSBbsnAjV+pkexwgZhqA2 v6W7zpe+z1Y+348HkrPh+H0vEmGViNPWMVSGIDU8pLjbWUtkSQqFGPCqjpt/X15LPkYh qZD2rryFTr/n2o5f6cmxhdcTCYiVkK2HHIEe3EMv63OhXhv4QBBZ9TwXLzDFwFCyfMSN ArvlL7PdCOe0ZBXEDVdYxY36M4avullhggTu1Mfo4ylWa2r20vX0BVawEFID5NkAcQCE k3dJjIZdazqFO8jGMP0y50apPQr7dWTfmMuOVjxI7KJk21mS1P7y7IRHJBuqv0nCpwpe DZFg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=S1RuFp0vlLAyeY1qWapt9cro6Y3Ttv10wLLV6eWht0Y=; fh=DABwI1u6AqIb+Dv9HxnXXMYkltBQFDriYYLZt6vD75o=; b=caVaMxkWhhs4JYxKGnQnmzwQzpgoSZwrNbrrnewd6mjQApoUQw1T3vZsfEmt7gF90F QoAwvfCQdFxIOYVpOuf1SlyOz+kolIvS9PjNqFiwH0aVBD3CZIBEZain7dLzAeoDkCzA 5tJ38Mv9qXXebaYOZNIZ28tH3GmsGrnO09DzugvdxfTvWZno73ulOY0n2s/3NQ+buruS z5C/4NHqB3qvx0ihpJntjmxJ0W4yI1ql2dUqbHPrfdd4mP9r3nVZP1FTphHaRZxRBNQI yB7jmPI4dNxYzZ0FIQA7g02+3elc6U59RjvkBHK3mxC9nP0S0/jFy8XKs7KxGVhqokv4 NTKQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=WnZ97HAT; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-213327-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-213327-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id d2e1a72fcca58-705ccb3e423si1401351b3a.198.2024.06.13.06.35.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jun 2024 06:35:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-213327-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=WnZ97HAT; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-213327-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-213327-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id E724B28419D for ; Thu, 13 Jun 2024 13:34:13 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DC15F1448E5; Thu, 13 Jun 2024 13:34:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="WnZ97HAT" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A5451E49B; Thu, 13 Jun 2024 13:34:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718285646; cv=none; b=pJB2U3Tz3zVbAsch/6wVGyXM0RziYLiufkeaJkUuF3teamwf5Nw9vc2gRix9LRAcXTz3gRvOmNl8Uk4ZE8l3J8Qvi0umza9jO+0p7n3SKWIhWRMRWsBqhtImnqGwczX86FcJ/iGGJ/FANqQSZbkiDyCr2rSIJ1ZwVL146HeJtv0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718285646; c=relaxed/simple; bh=hSnxi1yCAEFbEdOATXUDF4lzPF7LOP3u53tk5+lHDx4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ISyYGI0wLklVHCqkgYSEOYwlrLH2rOmGXZgqlfAKHzDd6yPDMK2LJt4spoz23SbnA+hokIh2IooSHGNchjW8H7sTje3X0wp4YW+bRL/KBlRSoPP8ySwSjYItMCKVWn60nw6eHQtzEJghLveGupx8PV1RTJvDSk/RakNwi6GhZLw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=WnZ97HAT; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=S1RuFp0vlLAyeY1qWapt9cro6Y3Ttv10wLLV6eWht0Y=; b=WnZ97HATOH2e8wV28w4HHoeKFS 2uQgBkOkxlWJMQuvHacBpyXvMzqzqfsI4mIBYmLsPROFEDXxgeBAVBwYVOe/o0eRYHIQ+xO16yvrU Fn28I5tmt9j346HZqiasu5F1ppBG7jZSpjTtlI61kQa5f736Ix241HkfmAaf2xRqn+ZY=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1sHkaM-00HZFj-2B; Thu, 13 Jun 2024 15:33:50 +0200 Date: Thu, 13 Jun 2024 15:33:50 +0200 From: Andrew Lunn To: SkyLake Huang =?utf-8?B?KOm7g+WVn+a+pCk=?= Cc: "daniel@makrotopia.org" , "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "linux@armlinux.org.uk" , "kuba@kernel.org" , "pabeni@redhat.com" , "edumazet@google.com" , "netdev@vger.kernel.org" , "dqfext@gmail.com" , Steven Liu =?utf-8?B?KOWKieS6uuixqik=?= , "matthias.bgg@gmail.com" , "davem@davemloft.net" , "hkallweit1@gmail.com" , "linux-arm-kernel@lists.infradead.org" , "angelogioacchino.delregno@collabora.com" Subject: Re: [PATCH net-next v6 5/5] net: phy: add driver for built-in 2.5G ethernet PHY on MT7988 Message-ID: References: <864a09b213169bc20f33af2f35239c6154ca81e3.camel@mediatek.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: > Since I found out that there's phy-mode="gmii" in mt7981-rfb.dts on > openWRT, I thought maybe we need gmii&internal for mt7981's built-in > GbE and xgmii&internal for mt7988's built-in 2.5GbE. Just because openwrt is using it, does not mean it is correct. We do not break in tree DT files, but out of tree DT can be ignored. Hopefully if mt7981-rfb.dts is ever submitted for mainline, the problem will be fixed. And when OpenWRT updates to a newer kernel they are likely to fix it. Andrew