Received-SPF: pass (google.com: domain of linux-kernel+bounces-213351-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Thu, 13 Jun 2024 09:42:41 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Naresh Kamboju <naresh.kamboju@linaro.org>
Cc: open list <linux-kernel@vger.kernel.org>, lkft-triage@lists.linaro.org,
 Linux Regressions <regressions@lists.linux.dev>, Dan Carpenter
 <dan.carpenter@linaro.org>, Arnd Bergmann <arnd@arndb.de>, Masami Hiramatsu
 <mhiramat@kernel.org>, Mark Rutland <mark.rutland@arm.com>
Subject: Re: LTP tracing crashed on arm64 rk3399-rock-pi-4 - pc :
 ftrace_ops_test
Message-ID: <20240613094241.549038df@rorschach.local.home>
In-Reply-To: <CA+G9fYu+GbYyw5J0XBy_W8VcHPdEf5Yu-gV7nhZTZioz9G6q_A@mail.gmail.com>
References: <CA+G9fYsSVJQZH=nM=1cjTc94PgSnMF9y65BnOv6XSoCG_b6wmw@mail.gmail.com>
	<20240612125130.2c1d6d2d@rorschach.local.home>
	<20240612171748.0bc6d9cb@rorschach.local.home>
	<CA+G9fYu+GbYyw5J0XBy_W8VcHPdEf5Yu-gV7nhZTZioz9G6q_A@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 13 Jun 2024 13:29:58 +0530
Naresh Kamboju <naresh.kamboju@linaro.org> wrote:

> > --- a/kernel/trace/fgraph.c
> > +++ b/kernel/trace/fgraph.c
> > @@ -641,7 +641,7 @@ int function_graph_enter(unsigned long ret, unsigned long func,
> >         {
> >                 for_each_set_bit(i, &fgraph_array_bitmask,
> >                                          sizeof(fgraph_array_bitmask) * BITS_PER_BYTE) {
> > -                       struct fgraph_ops *gops = fgraph_array[i];
> > +                       struct fgraph_ops *gops = READ_ONCE(fgraph_array[i]);
> >                         int save_curr_ret_stack;
> >
> >                         if (gops == &fgraph_stub)
> >
> >
> > Because if the compiler decides to re-read gops from fgraph_array[i] after the
> > above check for the following line that does:
> >
> >                         save_curr_ret_stack = current->curr_ret_stack;
> >                         if (ftrace_ops_test(&gops->ops, func, NULL) &&
> >                             gops->entryfunc(&trace, gops))
> >                                 bitmap |= BIT(i);
> >
> >
> > and gops now points to fgraph_stub, it will trigger this bug.
> >
> > Can you apply the above change and see if the bug goes away?  
> 
> I will apply this patch and run the test in a loop.
> Since it is only seen once. Not sure I could validate this and confirm.

We could just look at the code that clang produced and see if it
accesses the fgraph_array[] again. If this was the cause, it would show
up it in the code.

But regardless, I think I'm going to add that READ_ONCE() anyway,
because it is legitimate for the compiler to do the above without it.

Thanks,

-- Steve