Received-SPF: pass (google.com: domain of linux-kernel+bounces-213393-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 13 Jun 2024 10:02:11 -0400
From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: JaeJoon Jung <rgbi3307@gmail.com>
Cc: maple-tree@lists.infradead.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] maple_tree: modified return type of
 mas_wr_store_entry()
Message-ID: <4gv5fj26lpdhskj7u4fs42h6o3573ozsxcfqhvf44rfqef6v2y@c2rtba3wveu7>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@oracle.com>, 
	JaeJoon Jung <rgbi3307@gmail.com>, maple-tree@lists.infradead.org, linux-mm@kvack.org, 
	linux-kernel@vger.kernel.org
References: <20240606014656.7491-1-rgbi3307@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240606014656.7491-1-rgbi3307@gmail.com>
User-Agent: NeoMutt/20231103
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?Q9W0RlR0y6OF+P7knPrOghzURjgWBkA1TbAhQl+dpkhKo+WJhmKFn4FISEbs?=
 =?us-ascii?Q?XdTL6NTQ0wnOpkv19DXKPY7Rcgpvs8l591eORCxVy1+GmBEjEUFmRJSCYoNa?=
 =?us-ascii?Q?XqPEQuQjhAxyY0P/McjD3DAfyNHzzM2YNmUFn/hvVwIhhe7/Zw4y+DtksTqU?=
 =?us-ascii?Q?pfvn2Uwx7zGbKOm4fkHt3KnT1DoBdlTnIecu8k2qCUTKvuo0CH802OPm2cU1?=
 =?us-ascii?Q?bj7cyGjFG99DkOOhmq0BmtfF1bDeQI1EXNh9stQEc36xT3QraMBGEpPgAn3n?=
 =?us-ascii?Q?FoQdwQdi2m1CFCK8fBukTC+BMG/YWB0rrjdK1ke0cgCIr6BaCKOaj4q+Slt+?=
 =?us-ascii?Q?A+4rAaNppDHyk9Z7XmhE+dlTpKfIfV5US/43mFoumcx7wjh1q3l++bIZqFdI?=
 =?us-ascii?Q?94z3PqCCIPrnxk0P8EFVeD4qg6ZppOEexqZkbBdFquDfQUP6Usp/hhVK6iLC?=
 =?us-ascii?Q?Vit5SjqWzk6T9KoZmnxJzCSg0QKSUUkLtBA9IjRoLqNrs9cOHL2sNT+uUYDU?=
 =?us-ascii?Q?bQ6ZpeM5bYUeLGN1/Q9oIbNCTTqG90z7Z7tjBi1uB8qPv51ElTO+wagQWf7s?=
 =?us-ascii?Q?tc4u9+nwnA/gkQfmFgGDhyjitKIQr1OkqZ4tV9qPyypWKpva6tey81CLEpJR?=
 =?us-ascii?Q?2fhvjT/wm9xTvsNO3coglMhbL/MFFe/lSYT7narI5H6m8fQ8vJNjd7mPzfbg?=
 =?us-ascii?Q?xaXMC1XkX+DrMGjynoA6w5NuShuxhl8w8Rrws/XhFg4F/T6MaT/fRLyBDBca?=
 =?us-ascii?Q?fepmD6I7cZVwQ0IEsmkQT8vTWWWm3FM82T3LUbZcw/JX0huv57jzdM+wbzor?=
 =?us-ascii?Q?1QULAAo6xSxuk5T1RXvujSz88ZTI8HG0Tzv75VW4tI1VgT2K1PC2wqbIAYMF?=
 =?us-ascii?Q?fNPLMyINVc27nwvevHjP7/gWG3NKYqcOkhAChSrzOLQwixpha6/5lGbAZ9O9?=
 =?us-ascii?Q?vFHDj09p/IgsFuOyOWdu3PEBhmtytICYxw8Yrr8Au6opPNTxBu7J9IYsWZ/g?=
 =?us-ascii?Q?RpwZIcrmfEEog65nUeaQICQYaHCXgT531CwXAktM+CanChpyu1F8U3wUOMCs?=
 =?us-ascii?Q?JHzRUJ18vMK4AOI9e1v1W7BbGGO6oTpy+9nURIGltZvP2QrnvWuhm1Axm0p7?=
 =?us-ascii?Q?E/POi7FupY3J/kYkVs/z+lIHd/hGlJMEK0+qdjN5kZTZyWP3NMobtYkcY0xz?=
 =?us-ascii?Q?5fEq1+pDlZWypUPMJywKg/+uUU1e9PN18qevrrnmw/8yeynkH4X0X4Ui6Qar?=
 =?us-ascii?Q?WA0KnU8ouPQT3JAQk0iL2GfoNStral2N5CDkQWvnCEgRELGhEMiWLmdEIQBD?=
 =?us-ascii?Q?NeQxdMuFt3pTr3JbIYtWFJrsRMS5jDUC88TLjyOW+Qwzbg/BJk8d/QCzcLSr?=
 =?us-ascii?Q?Gkg0NtKSQzZEjbeOeTJkHhx1MmYckSTu5XuAaztU2Y1c8gEw4OdBxkKb0+JS?=
 =?us-ascii?Q?MlkDTSye2pZygwGIkwcKiXUueNULWzkwVZRb7WewoOi719/khy0ml793hGG+?=
 =?us-ascii?Q?FeR74dBHN3jUDLqJYcFnzdjOGlYhZJ7crvilHRTP57u0/upNtocR5cxWv/Pg?=
 =?us-ascii?Q?c7xMreaJ01dUq9e03dJfS1LoXTwn1caal9A+NXXP?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	o7cCumum9L9Ai0tJ07HRJhn4d6cN62hPYOBKKXLY+qICJrvBN1nYRdUF8eg5o36i7IaUOE8q++hNi3yZ0pX1UdxNx38FAHsQUdBzgOxNPMWPNDbceROW8jUB6lo2WzRJsLWnqmJ65psr5r2zIp4EbmhHnT/hhNv+ZlyOJYp8fupauYS26gZNkwO96NRIzzAE2p9I5GfOMXzJqmp2FlIMANdrAI0Q8xVE/vESyiup39vbGxPQDu4pc4fQ0jN3gYZsFD9waOO1F6C/LyBdU10bT+rOrUPaNEEg2Pg24wOhO69bE8wWvrFLYONbzWUYB79HXfA6CDd+CFpwWamrQkJP97CcHbX9Y/Mg3Wv7OfVdjEJfeCWfLjySb+rbItg0iPTJGWtG64vUKYpN9ZF5cK+gQMvi3tMruq/GAKLEg8q6Ju6BFZCPuS68yCnACfZegaFE7cB2vu0uNLkp+pw7bi0KhH0lAZUa97h/ybdQULCIeTHJJ6R2EiJCVQ8T3Wh04L9L+u8wWozz8ArIQ/PLEU/PCzo9nM+DQtL9+PDRThAqdU3ev8zA4sUoJplrBoOAPl2KRdOV1NCGHV4WSbaBGAksF0752myamJyVOYG7swGvxpA=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cb4bff3a-f315-48a7-875f-08dc8bb16d92
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2024 14:02:14.5304
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aS4m0e0tmoBltwtGQw/aTK2QQoNe3iYgjjzL6tvkphS4g1jn0QjNEC5CA/lW2f3ZaAUlrvt4Jpa0rrWRTbcvjg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB6172
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16
 definitions=2024-06-13_07,2024-06-13_02,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 adultscore=0
 mlxscore=0 bulkscore=0 malwarescore=0 mlxlogscore=999 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2406130102
X-Proofpoint-ORIG-GUID: OaYC81MBtSya12RoHqzgNxb4M-ikZli_
X-Proofpoint-GUID: OaYC81MBtSya12RoHqzgNxb4M-ikZli_

* JaeJoon Jung <rgbi3307@gmail.com> [240605 21:47]:
> Since the return value of mas_wr_store_entry() is not used,
> the return type can be changed to void.
> 
> Signed-off-by: JaeJoon Jung <rgbi3307@gmail.com>

Thanks, looks good!

Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>

> ---
>  lib/maple_tree.c | 15 ++++++---------
>  1 file changed, 6 insertions(+), 9 deletions(-)
> 
> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> index 2d7d27e6ae3c..aa3a5df15b8e 100644
> --- a/lib/maple_tree.c
> +++ b/lib/maple_tree.c
> @@ -4203,31 +4203,28 @@ static inline void mas_wr_modify(struct ma_wr_state *wr_mas)
>   *
>   * Return: The contents that was stored at the index.
>   */
> -static inline void *mas_wr_store_entry(struct ma_wr_state *wr_mas)
> +static inline void mas_wr_store_entry(struct ma_wr_state *wr_mas)
>  {
>  	struct ma_state *mas = wr_mas->mas;
>  
>  	wr_mas->content = mas_start(mas);
>  	if (mas_is_none(mas) || mas_is_ptr(mas)) {
>  		mas_store_root(mas, wr_mas->entry);
> -		return wr_mas->content;
> +		return;
>  	}
>  
>  	if (unlikely(!mas_wr_walk(wr_mas))) {
>  		mas_wr_spanning_store(wr_mas);
> -		return wr_mas->content;
> +		return;
>  	}
>  
>  	/* At this point, we are at the leaf node that needs to be altered. */
>  	mas_wr_end_piv(wr_mas);
>  	/* New root for a single pointer */
> -	if (unlikely(!mas->index && mas->last == ULONG_MAX)) {
> +	if (unlikely(!mas->index && mas->last == ULONG_MAX))
>  		mas_new_root(mas, wr_mas->entry);
> -		return wr_mas->content;
> -	}
> -
> -	mas_wr_modify(wr_mas);
> -	return wr_mas->content;
> +	else
> +		mas_wr_modify(wr_mas);
>  }
>  
>  /**
> -- 
> 2.17.1
>