Received-SPF: pass (google.com: domain of linux-kernel+bounces-213398-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: SeongJae Park <sj@kernel.org>
To: Honggyu Kim <honggyu.kim@sk.com>
Cc: SeongJae Park <sj@kernel.org>,
	damon@lists.linux.dev,
	Andrew Morton <akpm@linux-foundation.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Gregory Price <gregory.price@memverge.com>,
	linux-mm@kvack.org,
	linux-kernel@vger.kernel.org,
	linux-trace-kernel@vger.kernel.org,
	42.hyeyoo@gmail.com,
	art.jeongseob@gmail.com,
	kernel_team@skhynix.com
Subject: Re: [PATCH v5 8/8] Docs/.../mm/damon: add more damos actions
Date: Thu, 13 Jun 2024 07:07:29 -0700
Message-Id: <20240613140729.27177-1-sj@kernel.org>
In-Reply-To: <20240613132056.608-9-honggyu.kim@sk.com>
Precedence: bulk

Hi Honggyu,

On Thu, 13 Jun 2024 22:20:55 +0900 Honggyu Kim <honggyu.kim@sk.com> wrote:

> This patch adds damon description for "migrate_hot" and "migrate_cold"
> actions for both usage and design documents as long as a new
> "target_nid" knob to set the migration target node.
> 
> Signed-off-by: Honggyu Kim <honggyu.kim@sk.com>
> ---
>  Documentation/admin-guide/mm/damon/usage.rst | 8 +++++++-
>  Documentation/mm/damon/design.rst            | 4 ++++
>  2 files changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/admin-guide/mm/damon/usage.rst b/Documentation/admin-guide/mm/damon/usage.rst
> index 7bff54963975..84d62d16c9f9 100644
> --- a/Documentation/admin-guide/mm/damon/usage.rst
> +++ b/Documentation/admin-guide/mm/damon/usage.rst
> @@ -300,6 +300,10 @@ from the file and their meaning are same to those of the list on
>  The ``apply_interval_us`` file is for setting and getting the scheme's
>  :ref:`apply_interval <damon_design_damos>` in microseconds.
>  
> +The ``target_nid`` file is for setting the migration target node, which is
> +only meaningful when the ``action`` is either ``migrate_hot`` or
> +``migrate_cold``.
> +
>  .. _sysfs_access_pattern:
>  
>  schemes/<N>/access_pattern/
> @@ -759,7 +763,9 @@ list on :ref:`design doc <damon_design_damos_action>`.
>   - 4: ``nohugepage``
>   - 5: ``lru_prio``
>   - 6: ``lru_deprio``
> - - 7: ``stat``
> + - 7: ``migrate_hot``
> + - 8: ``migrate_cold``
> + - 9: ``stat``

This section is for DAMON debugfs interface.  And to my understanding, this
patchset is not adding support of migrate_{hot,cold} DAMOS actions on DAMON
debugfs interface.  So I think this part should be removed.

>  
>  Quota
>  ~~~~~
> diff --git a/Documentation/mm/damon/design.rst b/Documentation/mm/damon/design.rst
> index 3df387249937..3f12c884eb3a 100644
> --- a/Documentation/mm/damon/design.rst
> +++ b/Documentation/mm/damon/design.rst
> @@ -325,6 +325,10 @@ that supports each action are as below.
>     Supported by ``paddr`` operations set.
>   - ``lru_deprio``: Deprioritize the region on its LRU lists.
>     Supported by ``paddr`` operations set.
> + - ``migrate_hot``: Migrate the regions prioritizing warmer regions.
> +   Supported by ``paddr`` operations set.
> + - ``migrate_cold``: Migrate the regions prioritizing colder regions.
> +   Supported by ``paddr`` operations set.
>   - ``stat``: Do nothing but count the statistics.
>     Supported by all operations sets.

Except the DAMON debugfs interface section, this patch looks good to me.


Thanks,
SJ

[...]