Received-SPF: pass (google.com: domain of linux-kernel+bounces-213418-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-515-g87b2bad5a-fm-20240604.001-g87b2bad5
Precedence: bulk
MIME-Version: 1.0
Message-Id: <a7463c6e-2801-4d0e-b723-fc1cf77a04ed@app.fastmail.com>
In-Reply-To: 
 <CAMRc=Mem6HN13FOA_Ru8zC-GqGGLTsQiktLWs5bN4JD1aM3gHQ@mail.gmail.com>
References: <20240610112700.80819-1-wsa+renesas@sang-engineering.com>
 <20240610112700.80819-2-wsa+renesas@sang-engineering.com>
 <CAMRc=MfZ11U+kAh1+K=DxtJ=QL+cY7Q_sBN4sQDF-RNgjpV0QA@mail.gmail.com>
 <jvnvx7a4pn6evrp5ehfrt4qsiuprq6ogvrue2a3uupwtydmgcm@2rvat7ibvgb4>
 <CAMRc=Mc4__0zzJZG3BPnmbua88SLuEbX=Wk=EZnKH5HQvB+JPg@mail.gmail.com>
 <CACRpkda==5S75Bw6F3ZLUmf7kwgi_JkByiizR=m-61nrMDWuvQ@mail.gmail.com>
 <ce1d8150-c595-44d5-b19a-040920481709@app.fastmail.com>
 <CAMRc=McpRjQO8mUrOA4bU_YqO8Tc9-Ujytfy1fcjGUEgH9NW0A@mail.gmail.com>
 <CACRpkdYtLDA3518uSYiTpu1PJuqNErHr9YMAKuar0CeFbfECPA@mail.gmail.com>
 <CAMRc=Mem6HN13FOA_Ru8zC-GqGGLTsQiktLWs5bN4JD1aM3gHQ@mail.gmail.com>
Date: Thu, 13 Jun 2024 16:20:34 +0200
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Bartosz Golaszewski" <brgl@bgdev.pl>,
 "Linus Walleij" <linus.walleij@linaro.org>
Cc: "Wolfram Sang" <wsa+renesas@sang-engineering.com>,
 Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
 "Jonathan Corbet" <corbet@lwn.net>, "Kent Gibson" <warthog618@gmail.com>,
 linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
 "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v9 1/1] gpio: add sloppy logic analyzer using polling
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Thu, Jun 13, 2024, at 15:51, Bartosz Golaszewski wrote:
> On Thu, Jun 13, 2024 at 3:47=E2=80=AFPM Linus Walleij <linus.walleij@l=
inaro.org> wrote:
>>
>> On Thu, Jun 13, 2024 at 11:43=E2=80=AFAM Bartosz Golaszewski <brgl@bg=
dev.pl> wrote:
>>
>> > To prove this point, I even moved the gpio-virtuser driver I'm work=
ing
>> > on to drivers/misc/ too as it isn't a GPIO provider either and mere=
ly
>> > a GPIO consumer with a one-shot user-space interface not conforming=
 to
>> > any standards.
>>
>> We *could* just create drivers/gpio/consumers/* and an entry into the
>> top-level drivers/Kconfig to have those appear right under the GPIO
>> providers...
>>
>> Yours,
>> Linus Walleij
>
> That would just add to confusion. GPIO consumers are all over the tree
> after all.
>
> Whatever, let's keep it in drivers/gpio/. Greg KH just shot down my
> idea of putting gpio-virtuser in drivers/misc/.

I could imagine treating both gpio-virtuser and this code as
a gpiolib extension rather than a consumer (which is usually
part of some other subsystem's driver).

It would also make sense to me to separate gpio providers
from gpiolib in a way, moving one or both of them into a
subdirectory of drivers/gpio/.

It's probably not worth the pain of moving files, but at
least in Kconfig and filenames, they could be named
gpiolib-virtuser.c and gpiolib-sloppy-logic-analyzer.c
to make it clear that these are not gpio provider drivers
but something else, more along the lines of gpiolib-cdev.c
and gpiolib-sysfs.c.

     Arnd