Received-SPF: pass (google.com: domain of linux-kernel+bounces-213421-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Thu, 13 Jun 2024 10:29:18 -0400
From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: Sidhartha Kumar <sidhartha.kumar@oracle.com>
Cc: linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org,
        linux-mm@kvack.org, akpm@linux-foundation.org, willy@infradead.org
Subject: Re: [PATCH v2 08/16] maple_tree: print store type in mas_dump()
Message-ID: <nuij35r6vabz2s5qikvn6t3v7gabshabv5o7ngyzkkbh5tw3ik@lqy322zs2cua>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@oracle.com>, 
	Sidhartha Kumar <sidhartha.kumar@oracle.com>, linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org, 
	linux-mm@kvack.org, akpm@linux-foundation.org, willy@infradead.org
References: <20240607185257.963768-1-sidhartha.kumar@oracle.com>
 <20240607185257.963768-9-sidhartha.kumar@oracle.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240607185257.963768-9-sidhartha.kumar@oracle.com>
User-Agent: NeoMutt/20231103
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?QcDY7oCuyv7c6ATReEZe8OVGM2yCLn8zB0PPNJ2NJCA1Uf6DFZNDt90BXTIN?=
 =?us-ascii?Q?xX+XuueRApaMtnwHzSjXAUw2PHfXt0zpeMUWds2jTR3GGe7MLMNpX9KKfQ2C?=
 =?us-ascii?Q?Oif8LJJgt+1BIu4zTRyrmupuSGTute/DLiuCAdiMWpj80P6GTv4bjH146ZiI?=
 =?us-ascii?Q?68iP4OMuI4hReH2AyxHl6jrGcRAFC4vBKZktJSTWVxuD6EPgtkDtZaVVYndr?=
 =?us-ascii?Q?PzKedKza44T6RC3ADVtVNrHTUC6Vnvq3mROtgtlKr+21x1ovokoT8w2JVzFb?=
 =?us-ascii?Q?L2je6/AOYvId9frDrm3zP8DxOnjnJz8Ov6KxxsaMOQtSyrD0UszFeNfG3WOb?=
 =?us-ascii?Q?OuVZ5YH7axLotdkJfAcm6+5xMM5Rm/869RdzsTIDVaa68fHeh2aQcqmLD6eZ?=
 =?us-ascii?Q?OxtXvMA7K2X70kQDX9X0N1aMD0P2Cqw6huicYiQzgf+qip9BeRJGRqs5UU6q?=
 =?us-ascii?Q?Tcm8mRq8IpQjJMzGNfR3kK/zvYr9WBC6xuiJjFvVuWqpQDWxPHmg9+vc0Avf?=
 =?us-ascii?Q?U90kd/gICdN/A0kq6SJgM3eqTimjMEQHna+8WK6FqwWOo2wlkoHgtqLVhX4D?=
 =?us-ascii?Q?7n5Rnzo86KUQKOkHUt8JepIZewy2uM3qbapy+J3sMRLjRLZ3V7p4Y1jNRC97?=
 =?us-ascii?Q?xVBlx+tK5++OW9M4y8VuCAW7Xj8xXSW+XU4Qv/0+VguXm0TG224hnSe2mVwI?=
 =?us-ascii?Q?o6joTaKaRCK/Xe+Cjhp/k67k87TJ0QRs8q0xq6yqyYv917bdoD4j06aauopJ?=
 =?us-ascii?Q?espMCpTA8hPI8J4I1JNE/I/UiPoU6hw1MnVrQau+2+lKgqWig1bVAUj0Ohxi?=
 =?us-ascii?Q?qWZmd9dzAMSXVcmLY22HbL8GpI030oVlzbodo1s1Jx8+ytZZoFGwK/VVPfVS?=
 =?us-ascii?Q?xkbxkt3+DCA1/P5qH1xvfFr1+xGUCQxC63OE10PLzvg/NrbobrLuavdyMmYc?=
 =?us-ascii?Q?//bjY9Xc0+HQB+E8+B67Vhs4zz8IbJ3MwltjDyPWozPS+3+wMyOu8Tk4IBL8?=
 =?us-ascii?Q?mspIbWBPc8AE4tePY4Bd5kEKUGMcQYE8nlc1rlkscdwMQCC1Y5YvQOCYyzzy?=
 =?us-ascii?Q?p4OxNayTnYbqaNcMEold8rTYVdd5jVV1eNim8v4U14g7hnhHeHfvjxbMyXWK?=
 =?us-ascii?Q?M6gOsWpoN6d/oIbTZlSls85oDBiutQtPnMDhvX6Jk/+/NiVzB+quYSTn0Glk?=
 =?us-ascii?Q?NNcPvj04PHEtDUx9/a0nEAhI4oAP83bhWgB6i2FCATBtr27uJ5RpsfRrGeX2?=
 =?us-ascii?Q?c5nsJgKV9n//hbx/Khuzz/Og5oaRIRzVvuNRm0uP8KwvwttwA4+2PpnhaUMe?=
 =?us-ascii?Q?NpgH87KJnTne2nfbLJZ2KDJpmTtvPs0Qmtomap90ukAusfGyKHv7fJ45Uq0C?=
 =?us-ascii?Q?1ISnXrt3X+OMfi+JJX3bzCyPRVZvGD7tuKFnZ4QCxcK94V+Q5XU8E7JI7hE4?=
 =?us-ascii?Q?3wSefk92vI7biqcw+Q/oZfQkwINJqYPQ6fJpql0U7shbRZw21uQrYZy54b8b?=
 =?us-ascii?Q?K9ev6d9by6k+zXNHaWS9BoSznE2prJk/Q+AtX7fMw3QRRenXP1yUjpt9W/VJ?=
 =?us-ascii?Q?Q/2NjVIHjp42XHE40JQ1FK+B1m/3BBATvyfkV+obN01xAeE4wq9XwC4xnCJM?=
 =?us-ascii?Q?bQ=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	N/akDb6G9p7jwRnG8rstHqJRIzdZYwZG295zmldQIpN7ftq7kiQ+By05Q7EgBGjPFp8n9HtZgJEWS6hmeNz98EAZoOK0eVUpsTPyCPe7OnJmZtfNSClJZoaqlbyRTc62VH/tWb57LR9oFY1pR/dbmkRNR9Hon8O/LfPPizNlUp1qnoNLO6FteCCHs0pc+jTMkbPdw7PBKHJLNccjgsafr8NBw/tUfI7iPDPkj1C6NN7B24cRkhua41O8MRgJhZns61BVMsTFm/p0X2XgjDKHZ2RBIDRGfYbesiOj2yOfLd5VYJiTAwQwlyZcd/CKCnni9+DY1e/4QOeQ4CvHGWL8d45bPz99JETizJstDi5RA5GszqMKDKL/78CB59xhq8T9U1D9mTMZSI8z6Krkr+C8pYDbqnhxerpaUGgJa5uoMHhrP5bobkaZBrHXHWXMOEkiiA5wlT0DJkeRkvZqFEIljAgvsr8xos5dCRE91nAwqU0EGOEaGFtgNCxFY1dvnCc79eHcT8QbTe9mPzVuehbistSh61jWTutgxzkNOsm87zXjn639sBs5tSfhBHTvAUZn10x9tL/HVQdqR8QPmgbr04RHUqAlzYGEexIihcssiA8=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a804cc0e-f4f5-46ac-51ce-08dc8bb536ae
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2024 14:29:20.3792
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8HMWWTwGh7ukv1l2meSX5jP1k+tej508L8AK2Sf1Gvoi0LTczdrxt8tfe+QehkP530N6jt1D54/b2tS8O/G/LQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB7713
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16
 definitions=2024-06-13_08,2024-06-13_02,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 adultscore=0
 mlxscore=0 bulkscore=0 malwarescore=0 mlxlogscore=999 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2406130106
X-Proofpoint-ORIG-GUID: bHI0KFatA6MB_iB7ZtiNalrZE8nohHbD
X-Proofpoint-GUID: bHI0KFatA6MB_iB7ZtiNalrZE8nohHbD

* Sidhartha Kumar <sidhartha.kumar@oracle.com> [240607 14:53]:
> Knowing the store type of the maple state could be helpful for debugging.
> Have mas_dump() print mas->store_type.
> 
> Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
> ---
>  lib/maple_tree.c | 39 +++++++++++++++++++++++++++++++++++++++
>  1 file changed, 39 insertions(+)
> 
> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> index a955316b6745..91b18eef81e1 100644
> --- a/lib/maple_tree.c
> +++ b/lib/maple_tree.c
> @@ -7731,6 +7731,45 @@ void mas_dump(const struct ma_state *mas)
>  		break;
>  	}
>  
> +	pr_err("Store Type: ");
> +	switch (mas->store_type) {
> +	case wr_invalid:
> +		pr_err("invalid store type\n");
> +		break;
> +	case wr_new_root:
> +		pr_err("new_root\n");
> +		break;
> +	case wr_store_root:
> +		pr_err("store_root\n");
> +		break;
> +	case wr_exact_fit:
> +		pr_err("exact_fit\n");
> +		break;
> +	case wr_split_store:
> +		pr_err("split_store\n");
> +		break;
> +	case wr_slot_store:
> +		pr_err("slot_store\n");
> +		break;
> +	case wr_append:
> +		pr_err("append\n");
> +		break;
> +	case wr_node_store:
> +		pr_err("node_store\n");
> +		break;
> +	case wr_spanning_store:
> +		pr_err("spanning_store\n");
> +		break;
> +	case wr_rebalance:
> +		pr_err("rebalance\n");
> +		break;
> +	case wr_bnode:
> +		pr_err("write_bnode\n");
> +		break;
> +
> +	}
> +
> +

There is an extra new line here

>  	pr_err("[%u/%u] index=%lx last=%lx\n", mas->offset, mas->end,
>  	       mas->index, mas->last);
>  	pr_err("     min=%lx max=%lx alloc=%p, depth=%u, flags=%x\n",
> -- 
> 2.45.2
>