Received: by 2002:a89:413:0:b0:1fd:dba5:e537 with SMTP id m19csp192820lqs; Thu, 13 Jun 2024 07:39:53 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWT1na0xNNGAlO6mTt5B5Rb7sNSntkCDuTl0S/3ah7m522fY+Df2xS8wf7Ox/Gymp4qiFon5LcrNTMMnoh2BvhfplCb1/RT297bHOliFw== X-Google-Smtp-Source: AGHT+IH5dDtIftPxs80TkZDY23oF9WpoptD3iyUNUD/HDreNK/8nfgsXAEOwOdXcC+aPmGupbRd+ X-Received: by 2002:a17:902:c402:b0:1f7:2a3a:dda2 with SMTP id d9443c01a7336-1f83b5f2200mr57519545ad.32.1718289592856; Thu, 13 Jun 2024 07:39:52 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718289592; cv=pass; d=google.com; s=arc-20160816; b=yP0l5LwLsBUmhT/jl5CjupJTbMXStJH3bn7z6UOL0GgyB2Zxu44YMYtOALtekpusSF t8YhmD7QXK6n7YbcOQfyC69+a6lxKAlwvOONpOhz3M10xCAwwKlhmcrvk1P6zM6ClEAX w1z0VJrWQz5FaN5HOrvtvkD/4ROS1Wj2DMhOff8G/myNuZNpF/AvBU5FtO+TsahnGmuY UiKah2ZMw7taZbmb9gjoRYwApJ+nKBS+2OU7jpOnJg/n1K7w/DJXJvLfN2aL+2l5TmZY /+JdfHtcLgjtdyCb+DQTHcjBgvBOagR2qIJE/MoMVo2RxsRMadovP328cO+zLPrT/DhF jNFw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=jd12fLOw6Jp7IHBTZ1tqvb2/j4sV5sYMbH/NbtzjmNI=; fh=Tzp6yejc1yBsQ2WV7prlf1Mee5jgHUPmizB20XQeO1M=; b=Aiw/q85QMXelpqYHtOBSOXGHP2joQGTpocsgYl2PkxKHUK0Mmwt9L8siJ/7g/ylozp ZYCOVFZSYU/CMD4zgf8OIUk7hXWP2CTm807MJbXaNIpF5DKYHRbK/ppNuttL9f2qLZt6 tK4wk6Am18rE3jW9Vh/pZc9ZLGXUZqgNzWe2F2DN5QqQQoFN1JxJzTDbYICLsAhel1Ot AS27NLSZkfK/sCokLf4QGYq7nyhIc95YuIprMdSHaCz7EWzWo42XZSRHdulsbBl1mwTc BkUcgb2psDmNHXWAPKdfJ74FKgxXBWBeFtQVbf4yQplPCp1dKLq8uj2YPurB5vtD2A6J L/gQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="rW86Pd7/"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-213438-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-213438-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id d9443c01a7336-1f855e3c6ccsi14389465ad.121.2024.06.13.07.39.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jun 2024 07:39:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-213438-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="rW86Pd7/"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-213438-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-213438-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 0FA8D282ECC for ; Thu, 13 Jun 2024 14:39:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 07091145B2B; Thu, 13 Jun 2024 14:39:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rW86Pd7/" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28A9614430A; Thu, 13 Jun 2024 14:39:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718289570; cv=none; b=puEuFmzNMPwtkfvrn774OPyRj5BwtelyUl9bTHBC7Z5di2Ll1uXUbI/MR2qxNMbnaEEBLwNKGcumPGPIeUpvFTp67immGQNLKcu2euVSJukD1s4+K928W3wbcZc7JjuDAGRrP4SRh2kGhyXq+RLClucyQCYqhqL0H0GNI2FD8oI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718289570; c=relaxed/simple; bh=vg38Qqi1NtxVq+iaIwtVrD3TpEsJBbdtQTUi7OAhS/o=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=BLMGkWTGTh35W1OKzO7LHgKwl4s73UNDBASTAsl/Td27H+O5/92GG+9ytIkwKR+MP8uTEmcGt5nVZn8KuhInZoo2Rm9RM7CC9ot8/JCwqnCFzZAaAW5knH5AvQyyqv9IOZySSfk17BzAqpP8/t9Yu8OSNFQBE3GQq934mNROeGA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rW86Pd7/; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13C86C2BBFC; Thu, 13 Jun 2024 14:39:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718289569; bh=vg38Qqi1NtxVq+iaIwtVrD3TpEsJBbdtQTUi7OAhS/o=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rW86Pd7/xdZnfsZZ+P4pF/+Qg2cZzpurIGyesU+kAajpc6UY4eqqCdPRGNF3VbH7e so4wfnvSxKinTnNDGmYi3DIlv4yL21jBmBmN47sadmzR9vL7ksigappWFCCbkIPywY Vi9mD5HcDPRscWLM+UUD5fLDiuhBS+UzjSeaJnMOwIOccQW4ubhss+iR6Twk2CO/dq xIArb6wB1WcwZXL/6yFF3cLUe4t8DnlfDC5kPDerM4gsVeCcBLMvQZdpQNydPG5Grq vTgNz5KIS+zymR8RZHJDovr1tDPMldApYVcwcJgIAfQ5aylnmq+FLwazPrveB37ljO wnG0Yz1x1dwbQ== Date: Thu, 13 Jun 2024 07:39:28 -0700 From: Jakub Kicinski To: Ziwei Xiao Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, jeroendb@google.com, pkaligineedi@google.com, shailend@google.com, hramamurthy@google.com, willemb@google.com, rushilg@google.com, bcf@google.com, csully@google.com, linux-kernel@vger.kernel.org, stable@kernel.org, stable@vger.kernel.org Subject: Re: [PATCH net] gve: Clear napi->skb before dev_kfree_skb_any() Message-ID: <20240613073928.5d588cf2@kernel.org> In-Reply-To: <20240612001654.923887-1-ziweixiao@google.com> References: <20240612001654.923887-1-ziweixiao@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 12 Jun 2024 00:16:54 +0000 Ziwei Xiao wrote: > + if (rx->ctx.skb_head == napi->skb) > + napi->skb = NULL; There doesn't seem to be much precedent for directly poking at this field in drivers but I don't have any better ideas..