Received: by 2002:a89:413:0:b0:1fd:dba5:e537 with SMTP id m19csp193462lqs; Thu, 13 Jun 2024 07:40:55 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXF/D1bcifWiyxNKlMDUByHiwNSreX6pU+0GY6C/JuJzNWV2yhH/kpigMB0KY/ogypwWTITDW2BLkKZcX5wHhsQicds0y/Z0RNFAYiL5w== X-Google-Smtp-Source: AGHT+IEGne5C+uxNOeSCprzTHmRPeO4zMG9fsdPCTLhaMe4tfmLyRGhs3jvMr3fr3FvMYysedgxc X-Received: by 2002:a17:907:7651:b0:a6f:53f9:7974 with SMTP id a640c23a62f3a-a6f53f97ac4mr196963766b.52.1718289655068; Thu, 13 Jun 2024 07:40:55 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718289655; cv=pass; d=google.com; s=arc-20160816; b=Ai0QGD9pFVAjj8E1BRN1Go1kH5yWTEjn5omQW0LtVV+YvwrdbDuVgd26FSUPFRQ1Th dd71NhMRTk0AVz8Mzmz8ewZ08fXB5wr3x3+3pX9LPZ4s6ii3Q86n3yq0sEeT21hrRpLz +f6+r3mmF8JXK3VGG3w7qyP+SCrPaTO3P+GwXM7pdkO0E11YIqClUVpVJ7YJ9Ev5U1QS u5gs14hC701H8VrbQOv3o/ePtk+Svbogk6lvAWtefmZH94q7AcH2R3B2AgdtrNoEL1XD kyRunXYhGOy9eGVU+kl/N+r6SqLK+Skjga9hzGHs2tyTKgFHZ1z/CT1EbKo+LqKixN6t HRfQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:date:message-id:from:subject :content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=/LKrqOBqHO7PfdkMBzYJtrTmNaEtd0ieIIR8f5Ts/AA=; fh=LfPAhivPmvSIXAGdsxSudXLpeK8aEWQT1hkXI4GPIB0=; b=w+s8q/7PfHi4Z8YHVNUfdfT4xZLLKPuGhq4zL9tVIY5uUJqpDqlJETT4NHD6Cup7EI iAiqmjDAldwTeTlwXTGWvVGdcQRppZmwuPcqq/jK+jfnstCNwKWXsvhuqV8ZynBTHP8N 0O0mRWCIvHlolMXPvKcsC31p8ZdnaE/Mz8TLHEjXW+HAshpC2zxruOJYlAB9E+P2R/Ya 8B6UkQAgn4IDcJigEF5AGxrunGeUvGC1kxCNl5aw/lhtV7P//aQxrfrCAWCxN/vrPa5K 1JUBJfOInXUBTVLqOph14+1ru8e7Ez9BvtW0oIUHfIjpdHFneWgKNl9TsM9Z39Sem+xG tGSA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kqwPFSf+; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-213442-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-213442-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id a640c23a62f3a-a6f56e80a26si78435666b.966.2024.06.13.07.40.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jun 2024 07:40:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-213442-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kqwPFSf+; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-213442-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-213442-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 9225A1F234EE for ; Thu, 13 Jun 2024 14:40:54 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4491C146586; Thu, 13 Jun 2024 14:40:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kqwPFSf+" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D770145B12; Thu, 13 Jun 2024 14:40:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718289631; cv=none; b=luqPIfQTjZfpKHEhrLPPDk9804SnuvLNPaMDpEaAz/UvNHBFOXhLK1Be6Z9VKiSD036D15l0r+jRA728QQmm4X2cnULkQ8H/cn8JkqENbZn29++x/VsWagaNuoy9um+XGy+KZ9lFkZb6WnpBQkpUj9dGW59Ng6cZ/F56fAnlWP4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718289631; c=relaxed/simple; bh=jSu+K80o4zD8PvDW3KilUShNh/XJlo5qMMpgO2sQ1W8=; h=Content-Type:MIME-Version:Subject:From:Message-Id:Date:References: In-Reply-To:To:Cc; b=NKgE6uuMpl0GdiV3x2cFurlhJyiI0SlMdu8o1+D57vhpBNzHsFWET64Wk8+MCBhQtPFEmAsmqbyOQdA+QzAr3YIsWoNMcMXXYjVEyLxrw4m0bCYlEUE6s5zRwxYXMvNQ4FB/ofE/77VYeFc5lxbN0E6BMOiT+7jtpYmMb9UKXDU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kqwPFSf+; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPS id 38215C4AF49; Thu, 13 Jun 2024 14:40:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718289631; bh=jSu+K80o4zD8PvDW3KilUShNh/XJlo5qMMpgO2sQ1W8=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=kqwPFSf+8EUfr/e5BjsNfvlZihqDHFT2p5u/B/7HinLecDqWeh2h7wvKYeiH+H5I7 JALu43/p5tqBahzNhVEH+XqBb/WkFGFeNQYQh4s5CmawMA0J4qeUHmxvrAXFjHY1gX A0i4DocbkEbjT1vk7DxNvu0MhiBtvjn0xUsrrAGlesy3v/dFwYQlN0kKewXA12B8Ci JKVJkpjL0JBNwZCeeVv1ob+lNPIfeeLpABWy0xkwdivsnsP4HWSr2tPxpiE/YLcL/r loNdGoSA2PmOIXBYaOJpPrT6pft4z1yEGkIhOFFMvIzGyFnrR28RKg2CYUT4XSVnGZ 3e2uYjnnqOEpQ== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 29BBFC4314C; Thu, 13 Jun 2024 14:40:31 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net] gve: Clear napi->skb before dev_kfree_skb_any() From: patchwork-bot+netdevbpf@kernel.org Message-Id: <171828963116.5991.16090491063036449379.git-patchwork-notify@kernel.org> Date: Thu, 13 Jun 2024 14:40:31 +0000 References: <20240612001654.923887-1-ziweixiao@google.com> In-Reply-To: <20240612001654.923887-1-ziweixiao@google.com> To: Ziwei Xiao Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, jeroendb@google.com, pkaligineedi@google.com, shailend@google.com, hramamurthy@google.com, willemb@google.com, rushilg@google.com, bcf@google.com, csully@google.com, linux-kernel@vger.kernel.org, stable@kernel.org, stable@vger.kernel.org Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Wed, 12 Jun 2024 00:16:54 +0000 you wrote: > gve_rx_free_skb incorrectly leaves napi->skb referencing an skb after it > is freed with dev_kfree_skb_any(). This can result in a subsequent call > to napi_get_frags returning a dangling pointer. > > Fix this by clearing napi->skb before the skb is freed. > > Fixes: 9b8dd5e5ea48 ("gve: DQO: Add RX path") > Cc: stable@vger.kernel.org > Reported-by: Shailend Chand > Signed-off-by: Ziwei Xiao > Reviewed-by: Harshitha Ramamurthy > Reviewed-by: Shailend Chand > Reviewed-by: Praveen Kaligineedi > > [...] Here is the summary with links: - [net] gve: Clear napi->skb before dev_kfree_skb_any() https://git.kernel.org/netdev/net/c/6f4d93b78ade You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html