Received-SPF: pass (google.com: domain of linux-kernel+bounces-213472-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: =?UTF-8?q?Jo=C3=A3o=20Rodrigues?= <jrodrigues@ubimet.com>
To: 
Cc: jrodrigues@ubimet.com,
	Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org (open list:ETHERNET PHY LIBRARY),
	linux-kernel@vger.kernel.org (open list)
Subject: [PATCH net-next 3/3] net: phy: dp83867: Add support for amplitude graph
Date: Thu, 13 Jun 2024 16:51:53 +0200
Message-Id: <20240613145153.2345826-4-jrodrigues@ubimet.com>
In-Reply-To: <20240613145153.2345826-1-jrodrigues@ubimet.com>
References: <20240613145153.2345826-1-jrodrigues@ubimet.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Output the raw information of each segment.
Each segment also comes with the distance information,
but this does not map to the current output.

Signed-off-by: Jo=C3=A3o Rodrigues <jrodrigues@ubimet.com>
---
 drivers/net/phy/dp83867.c | 86 ++++++++++++++++++++++++++++++++++++---
 1 file changed, 80 insertions(+), 6 deletions(-)

diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c
index ff8c97a29195..e56a892d3da7 100644
--- a/drivers/net/phy/dp83867.c
+++ b/drivers/net/phy/dp83867.c
@@ -54,6 +54,8 @@
 #define DP83867_RXFSOP2	0x013A
 #define DP83867_RXFSOP3	0x013B
 #define DP83867_IO_MUX_CFG	0x0170
+#define DP83867_TDR_GEN_CFG2	0x0181
+#define DP83867_TDR_GEN_CFG4	0x0185
 #define DP83867_TDR_GEN_CFG5	0x0186
 #define DP83867_TDR_GEN_CFG6	0x0187
 #define DP83867_TDR_GEN_CFG7	0x0189
@@ -223,6 +225,8 @@ struct dp83867_private {
 	bool set_clk_output;
 	u32 clk_output_sel;
 	bool sgmii_ref_clk_en;
+	bool cable_test_tdr;
+	s8 pair;
 };
=20
 /* Register values are converted to SNR(dB) as suggested by
@@ -1068,7 +1072,7 @@ static u32 dp83867_cycles2cm(u32 cycles)
 	return cycles * 8 * 20;
 }
=20
-static int dp83867_cable_test_start(struct phy_device *phydev)
+static int dp83867_cable_test_common(struct phy_device *phydev)
 {
 	int ret;
=20
@@ -1082,11 +1086,38 @@ static int dp83867_cable_test_start(struct phy_de=
vice *phydev)
 	if (ret < 0)
 		return ret;
=20
-	ret =3D phy_write_mmd(phydev, DP83867_DEVADDR, DP83867_TDR_GEN_CFG5,
-			    DP83867_TDR_GEN_CFG5_FLAGS);
+	return phy_write_mmd(phydev, DP83867_DEVADDR, DP83867_TDR_GEN_CFG5,
+			     DP83867_TDR_GEN_CFG5_FLAGS);
+}
+
+static int dp83867_cable_test_start(struct phy_device *phydev)
+{
+	struct dp83867_private *priv =3D phydev->priv;
+	int ret;
+
+	ret =3D dp83867_cable_test_common(phydev);
+	if (ret < 0)
+		return ret;
+
+	priv->cable_test_tdr =3D false;
+
+	return phy_write_mmd(phydev, DP83867_DEVADDR, DP83867_CFG3,
+			     DP83867_TDR_START);
+}
+
+static int dp83867_cable_test_tdr_start(struct phy_device *phydev,
+					const struct phy_tdr_config *cfg)
+{
+	struct dp83867_private *priv =3D phydev->priv;
+	int ret;
+
+	ret =3D dp83867_cable_test_common(phydev);
 	if (ret < 0)
 		return ret;
=20
+	priv->cable_test_tdr =3D true;
+	priv->pair =3D cfg->pair;
+
 	return phy_write_mmd(phydev, DP83867_DEVADDR, DP83867_CFG3,
 			     DP83867_TDR_START);
 }
@@ -1105,9 +1136,14 @@ static int dp83867_cable_test_report_trans(struct =
phy_device *phydev, s8 pair,
=20
 	for (i =3D number_peaks; i >=3D 0; --i) {
 		if (peak_value[i] > threshold) {
-			fault_location =3D
-				dp83867_cycles2cm(peak_location[i] -
+			if (peak_location[i] >=3D DP83867_TDR_OFFSET) {
+				fault_location =3D dp83867_cycles2cm(peak_location[i] -
 					DP83867_TDR_OFFSET) / 2;
+			} else {
+				phydev_dbg(phydev, "Returned TDR fault location is too low");
+				fault_location =3D dp83867_cycles2cm(peak_location[i]) / 2;
+			}
+
 			if (peak_sign[i] =3D=3D 1) {
 				fault_rslt =3D
 					ETHTOOL_A_CABLE_RESULT_CODE_SAME_SHORT;
@@ -1208,6 +1244,39 @@ static int dp83867_read_tdr_registers(struct phy_d=
evice *phydev, s8 pair,
 	return 0;
 }
=20
+static int dp83867_simplified_amplitude_graph(struct phy_device *phydev)
+{
+	struct dp83867_private *priv =3D phydev->priv;
+	int peak_sign[5];
+	int peak_loc[ARRAY_SIZE(peak_sign)];
+	int peak_val[ARRAY_SIZE(peak_sign)];
+	int i;
+	int mV;
+	int ret;
+	s8 pair;
+
+	for (pair =3D ETHTOOL_A_CABLE_PAIR_A; pair <=3D ETHTOOL_A_CABLE_PAIR_D;
+			pair++) {
+		if (priv->pair !=3D PHY_PAIR_ALL && pair !=3D priv->pair)
+			continue;
+
+		ret =3D dp83867_read_tdr_registers(phydev, pair, peak_loc,
+						 peak_val, peak_sign,
+						 ARRAY_SIZE(peak_sign));
+		if (ret < 0)
+			return ret;
+
+		for (i =3D 0; i < ARRAY_SIZE(peak_loc); i++) {
+			mV =3D peak_val[i];
+			if (peak_sign[i])
+				mV *=3D -1;
+
+			ethnl_cable_test_amplitude(phydev, pair, mV);
+		}
+	}
+	return 0;
+}
+
 static int dp83867_cable_test_report_pair(struct phy_device *phydev, s8 =
pair)
 {
 	int peak_sign[5];
@@ -1242,6 +1311,7 @@ static int dp83867_cable_test_report(struct phy_dev=
ice *phydev)
 static int dp83867_cable_test_get_status(struct phy_device *phydev,
 					 bool *finished)
 {
+	struct dp83867_private *priv =3D phydev->priv;
 	int ret;
=20
 	*finished =3D false;
@@ -1258,7 +1328,10 @@ static int dp83867_cable_test_get_status(struct ph=
y_device *phydev,
 	if (ret & DP83867_TDR_FAIL)
 		return -EBUSY;
=20
-	return dp83867_cable_test_report(phydev);
+	if (priv->cable_test_tdr)
+		return dp83867_simplified_amplitude_graph(phydev);
+	else
+		return dp83867_cable_test_report(phydev);
 }
=20
 static int dp83867_get_sqi(struct phy_device *phydev)
@@ -1478,6 +1551,7 @@ static struct phy_driver dp83867_driver[] =3D {
 		.set_loopback	=3D dp83867_loopback,
=20
 		.cable_test_start	=3D dp83867_cable_test_start,
+		.cable_test_tdr_start	=3D dp83867_cable_test_tdr_start,
 		.cable_test_get_status	=3D dp83867_cable_test_get_status,
=20
 		.led_brightness_set =3D dp83867_led_brightness_set,
--=20
2.25.1