Received-SPF: pass (google.com: domain of linux-kernel+bounces-213470-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: =?UTF-8?q?Jo=C3=A3o=20Rodrigues?= <jrodrigues@ubimet.com>
To: 
Cc: jrodrigues@ubimet.com,
	Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org (open list:ETHERNET PHY LIBRARY),
	linux-kernel@vger.kernel.org (open list)
Subject: [PATCH net-next 1/3] net: phy: dp83867: Add SQI support
Date: Thu, 13 Jun 2024 16:51:51 +0200
Message-Id: <20240613145153.2345826-2-jrodrigues@ubimet.com>
In-Reply-To: <20240613145153.2345826-1-jrodrigues@ubimet.com>
References: <20240613145153.2345826-1-jrodrigues@ubimet.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Don't report SQI values for 10 ethernet, since the datasheet
says MSE values are only valid for 100/1000 ethernet

Signed-off-by: Jo=C3=A3o Rodrigues <jrodrigues@ubimet.com>
---
 drivers/net/phy/dp83867.c | 51 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 51 insertions(+)

diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c
index 4120385c5a79..5741f09e29cb 100644
--- a/drivers/net/phy/dp83867.c
+++ b/drivers/net/phy/dp83867.c
@@ -53,6 +53,7 @@
 #define DP83867_RXFSOP2	0x013A
 #define DP83867_RXFSOP3	0x013B
 #define DP83867_IO_MUX_CFG	0x0170
+#define DP83867_MSE_REG_1	0x0225
 #define DP83867_SGMIICTL	0x00D3
 #define DP83867_10M_SGMII_CFG   0x016F
 #define DP83867_10M_SGMII_RATE_ADAPT_MASK BIT(7)
@@ -153,6 +154,9 @@
 /* FLD_THR_CFG */
 #define DP83867_FLD_THR_CFG_ENERGY_LOST_THR_MASK	0x7
=20
+/* SQI */
+#define DP83867_MAX_SQI	0x07
+
 #define DP83867_LED_COUNT	4
=20
 /* LED_DRV bits */
@@ -196,6 +200,24 @@ struct dp83867_private {
 	bool sgmii_ref_clk_en;
 };
=20
+/* Register values are converted to SNR(dB) as suggested by
+ * "How to utilize diagnostic test suite of Ethernet PHY":
+ * SNR(dB) =3D -10 * log10 (VAL/2^17) - 3 dB.
+ * SQI ranges are implemented according to "OPEN ALLIANCE - Advanced dia=
gnostic
+ * features for 100BASE-T1 automotive Ethernet PHYs"
+ */
+
+static const u16 dp83867_mse_sqi_map[] =3D {
+	0x0411, /* < 18dB */
+	0x033b, /* 18dB =3D< SNR < 19dB */
+	0x0290, /* 19dB =3D< SNR < 20dB */
+	0x0209, /* 20dB =3D< SNR < 21dB */
+	0x019e, /* 21dB =3D< SNR < 22dB */
+	0x0149, /* 22dB =3D< SNR < 23dB */
+	0x0105, /* 23dB =3D< SNR < 24dB */
+	0x0000  /* 24dB =3D< SNR */
+};
+
 static int dp83867_ack_interrupt(struct phy_device *phydev)
 {
 	int err =3D phy_read(phydev, MII_DP83867_ISR);
@@ -1015,6 +1037,32 @@ static int dp83867_loopback(struct phy_device *phy=
dev, bool enable)
 			  enable ? BMCR_LOOPBACK : 0);
 }
=20
+static int dp83867_get_sqi(struct phy_device *phydev)
+{
+	u16 mse_val;
+	int sqi;
+	int ret;
+
+	if (phydev->speed =3D=3D SPEED_10)
+		return -EOPNOTSUPP;
+
+	ret =3D phy_read_mmd(phydev, DP83867_DEVADDR, DP83867_MSE_REG_1);
+	if (ret < 0)
+		return ret;
+
+	mse_val =3D 0xFFFF & ret;
+	for (sqi =3D 0; sqi < ARRAY_SIZE(dp83867_mse_sqi_map); sqi++) {
+		if (mse_val >=3D dp83867_mse_sqi_map[sqi])
+			return sqi;
+	}
+	return -EINVAL;
+}
+
+static int dp83867_get_sqi_max(struct phy_device *phydev)
+{
+	return DP83867_MAX_SQI;
+}
+
 static int
 dp83867_led_brightness_set(struct phy_device *phydev,
 			   u8 index, enum led_brightness brightness)
@@ -1195,6 +1243,9 @@ static struct phy_driver dp83867_driver[] =3D {
 		.config_intr	=3D dp83867_config_intr,
 		.handle_interrupt =3D dp83867_handle_interrupt,
=20
+		.get_sqi	=3D dp83867_get_sqi,
+		.get_sqi_max	=3D dp83867_get_sqi_max,
+
 		.suspend	=3D dp83867_suspend,
 		.resume		=3D dp83867_resume,
=20
--=20
2.25.1