Received-SPF: pass (google.com: domain of linux-kernel+bounces-213505-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Received-SPF: Pass (protection.outlook.com: domain of seco.com designates
 20.160.56.86 as permitted sender) receiver=protection.outlook.com;
 client-ip=20.160.56.86; helo=repost-eu.tmcas.trendmicro.com; pr=C
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=seco.com;
Message-ID: <b26d352b-145f-4fdd-8e7c-2d67ef8967d7@seco.com>
Date: Thu, 13 Jun 2024 11:11:02 -0400
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] rtc: abx80x: Fix return value of nvmem callback on
 read
To: Joy Chakraborty <joychakr@google.com>,
 Alexandre Belloni <alexandre.belloni@bootlin.com>,
 Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
 Dan Carpenter <dan.carpenter@linaro.org>
Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
 stable@vger.kernel.org
References: <20240613120750.1455209-1-joychakr@google.com>
Content-Language: en-US
From: Sean Anderson <sean.anderson@seco.com>
In-Reply-To: <20240613120750.1455209-1-joychakr@google.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-Microsoft-Antispam-Message-Info-Original:
 =?utf-8?B?bXVBRCswTzFxd2tRMGN1TE1VWDhnSng1Z09DeWxoV1VQL0p0YU4vYjJCMEJ3?=
 =?utf-8?B?dTI1VWYxdnBITW9UTzF0Wm5JOWNXM2ZPQVBnVFIxSTNHeHdKSElEaklSN20v?=
 =?utf-8?B?N0ZJNnhtaGhTcnRzRWNDVXNsUjBicjcwYlJlUW0zeWd4KzJIdTFqeG9DWkR0?=
 =?utf-8?B?eHVIT2pHb2x5YzRLVVB2QTlSWHVBQWE1NHJ6aFpDN0hIeXV3c3VoVTM4YTQw?=
 =?utf-8?B?QUFtcmQ0STkzcVdmVVJ3V20yUU9wd2V5dzY3eUJVd0FjcERQb3VYTkZ2WlRY?=
 =?utf-8?B?Vjd1S01KeCtzQnZRYjQyWE5KanF1TGd6Vm9jbHZnWW4wdVZKcFFVYW9Ta3BK?=
 =?utf-8?B?NlFNTzNnK2RCMkJCSCt3UHVhOS9OV3hwdlplNmJVd2xNK1NMdHNGbGJWVFJk?=
 =?utf-8?B?KzU2Nm5aNUdUVFhMTVRVcGxnZ1c1MlZTZ3hEQVpZTTJwaHRmWFpKc1BVaXVn?=
 =?utf-8?B?R1NKZC96cTdrQjgraXJNZlFGUWw3UzMvS2tGek5hUDlqWFVKcDVvdUREQjRl?=
 =?utf-8?B?cVJXZ1YxeUdibzlZSnRNMlI0dmhpMlRpU05qNFhqdHQ1SDZISCs3U3IvazdO?=
 =?utf-8?B?eVJaeTFsRHBUandNdGlISVRMOEFxL3RZNm40YmlTSWhwSyt1bExCSTR0UHpr?=
 =?utf-8?B?UUQ2ZG5NNEZGWWwrRGtSSWIyYk1xQWl0TkpLUEhueTBBYkVCQjBla24vVG5Z?=
 =?utf-8?B?TmFMM1FnNC9oWXJJa1h1N1BYaEZVK2xIbEh0b0xvTGxKOFZuUStyUFV2VHBl?=
 =?utf-8?B?MW0wMmdyMmZQRDNwenNFb1ZsL0lwRzlraCthTE03U0paaEU1UjN6QnNwSFdV?=
 =?utf-8?B?M0hBbVlWdmhRL0E1L21EdDBKamlIbUoxWjBOV0tFeGtHOE8xSHJNUTI2NkRG?=
 =?utf-8?B?ZGhTRFdrOVFxR2hjZkYvMC9aclhRS3YyVFA4Ujk1M2xsZEQ5UlMxbUFyeWIv?=
 =?utf-8?B?NmhYWlZHQkJiZ0Q2U3pLUm5XVVREaEdXa01MNEVTTnV6QnY5cGNybXVyQ014?=
 =?utf-8?B?blVrQTBJMS9JZEpUYVo0aWl2MkhJbVlHNWJZREFZektDTzhtWlltQzFKN1Vp?=
 =?utf-8?B?d1E0bHMyVzE4WUU2MlkyaUdWMzlTb2l0cU02anhyQ0h5TVQ3TmZQRHBPZWVw?=
 =?utf-8?B?cDQzQWZKZnpUY1RSYVhSZnJRKzNYY2dwNVRtbitwSDByNTVlMmtLNGdtTWNP?=
 =?utf-8?B?YjE0ZVFPTUIyblYva2lqZERPQnd4WnZrQUlmckJqS3dQZ3ZPTGhWbzdNaDFu?=
 =?utf-8?B?NHA1Z25uQTlUbGQxNkMrMXZSQWozNXNET1YvTCtRZkIxTkJUZW1zRm1zd3Jz?=
 =?utf-8?B?ZnFHeXBKVFl3M08yWXY2b3FRbEkxTVk1RS8yTHRDZEdhVGxxenRrbmMyMUJB?=
 =?utf-8?B?UzdRVlNjYW55MUZVZkZvWGNKVmxidVNBeEl6dW5BemRTanpPY2lZdktzUjBK?=
 =?utf-8?B?bEFMR3krL21hamRQeDhVZGhaREs0WFNDYmV4QktuZkgyM1M3enU3YUpMWE5r?=
 =?utf-8?B?UkFjTFlXVU5sMThabmJPVk9kQlZ1eVdNVXZOQTlRNjY1dGk0WDA3eDRudGZi?=
 =?utf-8?B?QzZaMnZIQURzQmZiL2gzNFI1T2RxMHF2QzZUb255QXdHeDFZdTJCMlprdGpm?=
 =?utf-8?B?Rk9YWTBZM3JpUjdxNFM1ZGpZNStRTU5NNWpySTVDYUtwTFZLNVFiY2JrZ3FN?=
 =?utf-8?B?cy9XVzR6OFBMaVVNVlJzcjc1ZmtnVDVFN3ZNUkJiWjdDVHpUOFR0TmVodzlY?=
 =?utf-8?B?cThxbHEwVE5wL1VENW40cDJvRVRsOHo5VkdBV0RlMGFjUUFCcFdKMmFkNUNs?=
 =?utf-8?Q?f1qwQsoeyWN6PJxOR1omj48M/oKg1pZebgFbk=3D?=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR03MB8847.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230035)(1800799019)(366011)(376009)(52116009)(38350700009);DIR:OUT;SFP:1102;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI0PR03MB10805
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM3PEPF00009BA0.eurprd04.prod.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	4f985abd-0910-4f40-91f2-08dc8bbb0c8e
X-Microsoft-Antispam:
	BCL:0;ARA:13230035|36860700008|82310400021|1800799019|35042699017|376009;
X-Microsoft-Antispam-Message-Info:
	=?utf-8?B?WXVPaFNoRGNNckw4djV0ZnhlMFZvaitMWm1XTmxoMjRtUjEvaUNCN0NKNlFt?=
 =?utf-8?B?T1Q4K3VpQVZjYVFSYkh5dGVwWW5FaVdIa29nb0pLUXRCWnlSbkNVbEcvWkgv?=
 =?utf-8?B?RERrV2Vob04zMUVWUW4vdWovdEtUTHllcGxCTjZybHRQTXNneHo1OVQxYURo?=
 =?utf-8?B?KzdWYkJySTdYZnVVcDBFYmdBT05uTVNTclM5eXd5TTR0bEZLWGdPZmNWOUNH?=
 =?utf-8?B?aFFBK2M0NGllUnMwTVplTmhFZE5BRWJMRnBabWZLbDdrT0hMaHRKUDNrMHlE?=
 =?utf-8?B?WFJjdUw2c2FNQjFmYTNNdEtlZ0t0d3dHZjNuOE03VDdGbmVFTjI1NnR6Sytr?=
 =?utf-8?B?T25NcmRENFVxY1FIN09iR0p3UmJ2QUlobUZ3Mm9DMUxXbUwvQmFjVERmVUpY?=
 =?utf-8?B?NnE4U2ZMTzRreDA4NHRiUThoazBmLzltbjk2NjYvbk85Qkx1YkVHLy9IN1JZ?=
 =?utf-8?B?QXVQanpCMThZOG9QdS95Y08yekdKdkxnNzBWc2VlY2M2OTJ5N0RwZk9UbFoy?=
 =?utf-8?B?NjlaVWphVGpuQndmeUNJOXFpUlBXYzFyQ29TSzIyVXdITno2MXFCV055dDRn?=
 =?utf-8?B?MUszZ3NDcEtBL0hCL0NwL3dlZjl2b2RjeTR0cE9NTGgzNHcxSUJRcEpNc29S?=
 =?utf-8?B?SFZuNDF5K2JsclNWT2lqbEdyK2NOMXlWOGZaU1R6UXV3VDN3QTE0WVVlRjI3?=
 =?utf-8?B?cHp5RWUxSGFyT0Jyd1M1RjEwQW1rRzRacnp2ZGdlaFRSTXdJTFoxR2Q5WjNJ?=
 =?utf-8?B?bER5eGpGbWtaNGdBZU1GbjdYdEc0dzczQkJPOGViWk1KTlEvYS82K0FiQTNn?=
 =?utf-8?B?dHV4a24rWFlOUWJZQ2pVNlJxSm5hN3VrcUtaTWdCMnhpMEFKQ3VZVGQwS2c0?=
 =?utf-8?B?VkFJalg0cm14L2xyVGZqa2Z0WWV6S3FzZy9GZExpTExsZ0JnOTBTQTd1T3JP?=
 =?utf-8?B?dEZXdkh6cllWRllmMWtQSzNoNzZ5djdYMFpmZVlZVCtEL3pybDVMZ1R5dENk?=
 =?utf-8?B?Y2l6Ky9kY2dxV2dxeVBuUEVlZ20yM2xXOElEbzR3MGpmSkhjQXBlSVlZbFR4?=
 =?utf-8?B?RTB0NnU0eExRdFpDa2tmb1dxWkkwNTBMN2JMaWxuVkYrUmVjYmJsL2JDZ0FS?=
 =?utf-8?B?Qlk0YzEydXY0REZJSHpUckplckNiL1o3ZDd6clFadjg0dUxYb1hZanFsNXNY?=
 =?utf-8?B?RkZRcWUzc3J2SERhYUNFendTczVkby92L0V6VjEvUEE1cE1OTjRGbXg5WW1T?=
 =?utf-8?B?NUhwWDI0cjJnL0VLOUlKMmVpUHdyRlhjRHpmejBDeFJwbzhhQlVOQzB2SWFY?=
 =?utf-8?B?ak5ObUZCT05kL3RHM01HbXBqNXVhK2VIY0ZOM1RFRmNzb2t1MDRDcVI0NThE?=
 =?utf-8?B?dENveXVWR2U5cFZ1OFZ5NW9la29wVEg3bzAxQThxaUhFaFRjY2NJVndCV2R1?=
 =?utf-8?B?ditDRWtUSFlVY2NVc2JNUGl2bzdSTE8rQzZ1VmZ0eTZRdURXb2NuTGhEVnlq?=
 =?utf-8?B?L3JmZ3lhZUp1ZFdWc2ErU2E4cXYvZStzeTMyc0ZuOHRNK0M5R1RscHZ1WW84?=
 =?utf-8?B?MjJaUzJ4dm9UQjNGUVRudk1TUUc1cDd5MTZkZEdUcERmSGpvZHNlaVFLTWpI?=
 =?utf-8?B?ZU04bGI4b1hjd25kc3BCN0wvU09CNmw1N3hDUEJjNnJqUW0rcjlrd05QbFoy?=
 =?utf-8?B?VWt0cGVzd2xHRjUyVS85aFhoOFJoV3VGZkxSME1WTnVybXlvR2U4SDhPaTVH?=
 =?utf-8?B?UUpHTC9JMVFIb0dtalJjSEdLdEppK1ZIMG1hRjRhOFI4VmN6QmtHTFVhV2l5?=
 =?utf-8?B?TFlVMllpNk51UmlERUt2Z1ZmN3lpZjFwY2VTQloyMGdya3YycDZGRHJaT3ZQ?=
 =?utf-8?B?RnFnbFBrNkFzZWdOM0ViUC9zdEhwRmJYRW9zaHdDWlpLS2c9PQ==?=
X-Forefront-Antispam-Report:
	CIP:20.160.56.86;CTRY:NL;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:repost-eu.tmcas.trendmicro.com;PTR:repost-eu.tmcas.trendmicro.com;CAT:NONE;SFS:(13230035)(36860700008)(82310400021)(1800799019)(35042699017)(376009);DIR:OUT;SFP:1102;
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2024 15:11:13.6442
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: df616738-6312-4141-1b51-08dc8bbb10d6
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bebe97c3-6438-442e-ade3-ff17aa50e733;Ip=[20.160.56.86];Helo=[repost-eu.tmcas.trendmicro.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM3PEPF00009BA0.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR03MB7850

On 6/13/24 08:07, Joy Chakraborty wrote:
> Read callbacks registered with nvmem core expect 0 to be returned on
> success and a negative value to be returned on failure.
> 
> abx80x_nvmem_xfer() on read calls i2c_smbus_read_i2c_block_data() which
> returns the number of bytes read on success as per its api description,
> this return value is handled as an error and returned to nvmem even on
> success.

Humm, I wish this were documented in nvmem-provider.h...

> Fix to handle all possible values that would be returned by
> i2c_smbus_read_i2c_block_data().
> 
> Fixes: e90ff8ede777 ("rtc: abx80x: Add nvmem support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Joy Chakraborty <joychakr@google.com>
> ---
>  drivers/rtc/rtc-abx80x.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-abx80x.c b/drivers/rtc/rtc-abx80x.c
> index fde2b8054c2e..1298962402ff 100644
> --- a/drivers/rtc/rtc-abx80x.c
> +++ b/drivers/rtc/rtc-abx80x.c
> @@ -705,14 +705,18 @@ static int abx80x_nvmem_xfer(struct abx80x_priv *priv, unsigned int offset,
>  		if (ret)
>  			return ret;
>  
> -		if (write)
> +		if (write) {
>  			ret = i2c_smbus_write_i2c_block_data(priv->client, reg,
>  							     len, val);
> -		else
> +			if (ret)
> +				return ret;
> +		} else {
>  			ret = i2c_smbus_read_i2c_block_data(priv->client, reg,
>  							    len, val);
> -		if (ret)
> -			return ret;
> +			if (ret <= 0)
> +				return ret ? ret : -EIO;
> +			len = ret;
> +		}
>  
>  		offset += len;
>  		val += len;

Reviewed-by: Sean Anderson <sean.anderson@seco.com>