Received-SPF: pass (google.com: domain of linux-kernel+bounces-213506-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Thu, 13 Jun 2024 17:11:29 +0200
From: Borislav Petkov <bp@alien8.de>
To: David Thompson <davthompson@nvidia.com>
Cc: "tony.luck@intel.com" <tony.luck@intel.com>,
	"james.morse@arm.com" <james.morse@arm.com>,
	"mchehab@kernel.org" <mchehab@kernel.org>,
	"rric@kernel.org" <rric@kernel.org>,
	Shravan Ramani <shravankr@nvidia.com>,
	"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/2] EDAC/bluefield: fix white space in
 bluefield_edac_mc_probe
Message-ID: <20240613151129.GIZmsMIc1lXDXJf65u@fat_crate.local>
References: <20240612193831.25913-1-davthompson@nvidia.com>
 <20240612193831.25913-2-davthompson@nvidia.com>
 <20240612200056.GGZmn-eO15ePolbAPo@fat_crate.local>
 <DM6PR12MB553462599AA57044F6E41DF4C7C12@DM6PR12MB5534.namprd12.prod.outlook.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <DM6PR12MB553462599AA57044F6E41DF4C7C12@DM6PR12MB5534.namprd12.prod.outlook.com>

On Thu, Jun 13, 2024 at 03:06:38PM +0000, David Thompson wrote:
> I did review this section of the kernel documentation and then
> went on to create a v2 with the updated commit message.
> I apologize but I didn't notice your comment below about 
> your preference to not have this type of patch at all.  I have been
> told in the past to have separate patches for style cleanups, and

Yeah, it all depends on the maintainer. I, personally, do not encourage style
cleanups only because they interfere with git archeology and teach new
submitters not to chase real bugs but do silly patches only.

> not to bundle them with features.  But I can do as you recommend for next
> version.  I will squash the two style fixes into a patch that contains some
> new functionality for the BlueField EDAC driver.

Thanks.

Simply use checkpatch on your patches only but not on the .c files directly. 

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette