Received-SPF: pass (google.com: domain of linux-kernel+bounces-213510-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Thu, 13 Jun 2024 08:12:33 -0700
From: Jakub Kicinski <kuba@kernel.org>
To: "=?UTF-8?B?Q3PDs2vDoXMs?= Bence" <csokas.bence@prolan.hu>
Cc: Frank Li <Frank.Li@freescale.com>, "David S. Miller"
 <davem@davemloft.net>, <imx@lists.linux.dev>, <netdev@vger.kernel.org>,
 <linux-kernel@vger.kernel.org>, "Richard Cochran"
 <richardcochran@gmail.com>, Wei Fang <wei.fang@nxp.com>, Shenwei Wang
 <shenwei.wang@nxp.com>, Clark Wang <xiaoning.wang@nxp.com>, Eric Dumazet
 <edumazet@google.com>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH resubmit 2] net: fec: Fix FEC_ECR_EN1588 being cleared
 on link-down
Message-ID: <20240613081233.6ff570cd@kernel.org>
In-Reply-To: <20240611080405.673431-1-csokas.bence@prolan.hu>
References: <20240611080405.673431-1-csokas.bence@prolan.hu>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Tue, 11 Jun 2024 10:04:05 +0200 Cs=C3=B3k=C3=A1s, Bence wrote:
> +	if (fep->bufdesc_ex) {
> +		val =3D readl(fep->hwp + FEC_ECNTRL);
> +		val |=3D FEC_ECR_EN1588;
> +		writel(val, fep->hwp + FEC_ECNTRL);

FEC_ECNTRL gets written multiple times in this function,
including with 0, and then you RMW it to add this flag.

Is this intentional? It really seems like you should be
adding this flag more consistently or making sure its
not cleared, rather than appending "add it back" at the=20
end of the function...
--=20
pw-bot: cr