Received-SPF: pass (google.com: domain of linux-kernel+bounces-213602-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240613112520.1526350-1-maze@google.com> <bv44ythtmj5sh7uqoo6ydvsdae6r4lamrpkn4gn3n2wx4jebs7@ek3vf4o3m64r>
In-Reply-To: <bv44ythtmj5sh7uqoo6ydvsdae6r4lamrpkn4gn3n2wx4jebs7@ek3vf4o3m64r>
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Date: Thu, 13 Jun 2024 08:49:34 -0700
Message-ID: <CAADnVQKee8cuxjg2cFGmzRMhpvLOiJnnKAXvJWLRBUYGhH=PPw@mail.gmail.com>
Subject: Re: [PATCH bpf] bpf: fix UML x86_64 compile failure
To: Shung-Hsi Yu <shung-hsi.yu@suse.com>
Cc: =?UTF-8?Q?Maciej_=C5=BBenczykowski?= <maze@google.com>, 
	=?UTF-8?Q?Maciej_=C5=BBenczykowski?= <zenczykowski@gmail.com>, 
	Linux Network Development Mailing List <netdev@vger.kernel.org>, 
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, BPF Mailing List <bpf@vger.kernel.org>, 
	Andrii Nakryiko <andrii@kernel.org>, John Fastabend <john.fastabend@gmail.com>, 
	Alexei Starovoitov <ast@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Jun 13, 2024 at 8:30=E2=80=AFAM Shung-Hsi Yu <shung-hsi.yu@suse.com=
> wrote:
>
> On Thu, Jun 13, 2024 at 04:25:20AM GMT, Maciej =C5=BBenczykowski wrote:
> > Cc: Andrii Nakryiko <andrii@kernel.org>
> > Cc: John Fastabend <john.fastabend@gmail.com>
> > Cc: Alexei Starovoitov <ast@kernel.org>
> > Fixes: 1ae6921009e5 ("bpf: inline bpf_get_smp_processor_id() helper")
> > Signed-off-by: Maciej =C5=BBenczykowski <maze@google.com>
> > ---
> >  kernel/bpf/verifier.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
> > index 36ef8e96787e..7a354b1e6197 100644
> > --- a/kernel/bpf/verifier.c
> > +++ b/kernel/bpf/verifier.c
> > @@ -20313,7 +20313,7 @@ static int do_misc_fixups(struct bpf_verifier_e=
nv *env)
> >                       goto next_insn;
> >               }
> >
> > -#ifdef CONFIG_X86_64
> > +#if defined(CONFIG_X86_64) && !defined(CONFIG_UML)
> >               /* Implement bpf_get_smp_processor_id() inline. */
> >               if (insn->imm =3D=3D BPF_FUNC_get_smp_processor_id &&
> >                   prog->jit_requested && bpf_jit_supports_percpu_insn()=
) {
>
> The patch needs a change description[1].
>
> Maybe something along the line of why pcpu_hot.cpu_number not accessible
> in User-mode Linux? (I don't know bpf_get_smp_processor_id() or UML that
> well, just suggesting possible change description)

+1


pw-bot: cr