Received-SPF: pass (google.com: domain of linux-kernel+bounces-213599-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240613150134.66329-1-gychoi.dev@gmail.com>
In-Reply-To: <20240613150134.66329-1-gychoi.dev@gmail.com>
From: Rob Herring <robh@kernel.org>
Date: Thu, 13 Jun 2024 09:44:52 -0600
Message-ID: <CAL_Jsq+UQ+Epe=_UyR-nkTWsbT6Q9HeEqX6__9nb+Uv1vzZCmA@mail.gmail.com>
Subject: Re: [PATCH] drivers:of: Add null check for bus in of_match_bus
To: Gyeonggeon Choi <gychoi.dev@gmail.com>
Cc: saravanak@google.com, devicetree@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Jun 13, 2024 at 9:02=E2=80=AFAM Gyeonggeon Choi <gychoi.dev@gmail.c=
om> wrote:
>
> Added a null check for the bus variable after calling of_match_bus.
> This prevents potential null pointer dereference errors in subsequent
> code, where bus->count_cells could cause a crash if bus is NULL.

Go read of_match_bus(). It never returns NULL and if somehow it did,
we'll BUG() first.

>
> Signed-off-by: Gyeonggeon Choi <gychoi.dev@gmail.com>
> ---
>  drivers/of/address.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/of/address.c b/drivers/of/address.c
> index d669ce25b5f9..85f986d25870 100644
> --- a/drivers/of/address.c
> +++ b/drivers/of/address.c
> @@ -504,6 +504,8 @@ static u64 __of_translate_address(struct device_node =
*node,
>         if (parent =3D=3D NULL)
>                 return OF_BAD_ADDR;
>         bus =3D of_match_bus(parent);
> +       if (bus =3D=3D NULL)
> +               return OF_BAD_ADDR;
>
>         /* Count address cells & copy address locally */
>         bus->count_cells(dev, &na, &ns);
> --
> 2.39.3 (Apple Git-146)
>