Received-SPF: pass (google.com: domain of linux-kernel+bounces-213620-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 13 Jun 2024 12:06:38 -0400
From: Frank Li <Frank.li@nxp.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: alexandre.belloni@bootlin.com, conor.culhane@silvaco.com,
	imx@lists.linux.dev, linux-i3c@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] i3c: master: svc: fix IBIWON not set if IBI
 follow a hot join
Message-ID: <ZmsZDpl1eOonPYL6@lizhi-Precision-Tower-5810>
References: <20240603151527.52235-1-Frank.Li@nxp.com>
 <20240603171919.02c70327@xps-13>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240603171919.02c70327@xps-13>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?iso-8859-1?Q?eLzEJoPrRfhyuUwr2tz52KFCBXeuHPrAlQ0VMoYhmU8jJxiudxjlHhjah6?=
 =?iso-8859-1?Q?7ikgu6aTsKrNVnXVz/TC3u/SxDXzZGKH8xN1ViEtv3DUT7JESrnalFT/6U?=
 =?iso-8859-1?Q?pmqmfJ2Ely2bJKq0wS5SPqkzgcsDdPHahmSLRT02cfEz7xmnMl9SWbf3AQ?=
 =?iso-8859-1?Q?9AHNsTv54OC6+DmjpBDVymjAgVIVvlTL3fbCv9JSh6O2+QpVJ7QHwtAFbn?=
 =?iso-8859-1?Q?EYY7iJNW6duUN34DkZ5Ay++LaPTjyAVP09HD0hIKvdxs8n2h9Dq3lVPx5d?=
 =?iso-8859-1?Q?kX7dKrlExTJTidunRsdAMB/8aglQS0qFJhmsv+V1mXm9SRdWird8xZ4oMT?=
 =?iso-8859-1?Q?QIMwCjItWzpmUzCiTWkgiuqfDKg0CYI3xvq26IYaPn86KI/DiAyYkWo+wJ?=
 =?iso-8859-1?Q?4FmlwvEzr8lxLvoS85CdjALjjGRF5oD/8gJXWEnbGq6TW94YCQXVZo8GXo?=
 =?iso-8859-1?Q?JPMuIlBsjvVMAWCcxpqgJenG0WDMIo1B0v6wLiiEzaS/wtij+ajFJV+RHx?=
 =?iso-8859-1?Q?Q6XeePKH/tvCGdfj0g0j4q5jpWRffeKfrDTwFeJUZjhjv5jrxeHq44LyNn?=
 =?iso-8859-1?Q?1BZT30J0y9AqGsj3eQ0r1uaOJOmFbWT1QtM2f5U6g+FvA8BUgrttl4RWF6?=
 =?iso-8859-1?Q?BRigYkjlbqFYxaWwjxhlBSFGqCXofDjMrijAgHfcnX4NWY/GCiEOjgHLre?=
 =?iso-8859-1?Q?fOd3uKObVsNE6nWRf4jxBPluqVsqBqoueK3+qbXqNOgO8TnHWT8B3q4p8w?=
 =?iso-8859-1?Q?005Dnvw5G1J4jKuVqFGH0/HkKDWRO4DP1QCniGDc1/9QO/4X0V+yLXP1V6?=
 =?iso-8859-1?Q?AbPI0iLzBDUMft82NanOl9GCfaR/76ta4UTvDlgDkKOHCJ8sSV4M7RnPOM?=
 =?iso-8859-1?Q?wBypKrIEejTsNXcCpd6PYRKDtHeKklbdd/Vbn3Rq1Gx9CwtId640Y4I/98?=
 =?iso-8859-1?Q?cwrtFlE0MxOuR///+zG5U8P5tVaMYHLooZrATsX3c+S0fPogjwgpW8XXrW?=
 =?iso-8859-1?Q?RiUmU8q1dYZO4ZiplmBM/fpTIy5Q3PwWIo+DdrnDd5uRy6lbiTEhqEHGR0?=
 =?iso-8859-1?Q?DCvT3OZNp/zP/dnpdoB4ZIGYh0GHBCnfTacax2XFs5fYkphOhpW2qodK8T?=
 =?iso-8859-1?Q?PqjIWJaUegbgGzjuCqLBK+XqTmeUfEiX2SGJUGW1X3OJsLTHiBkYp1t2To?=
 =?iso-8859-1?Q?2vF58yllqRjqC1kttmP0CcT1qVIDbDVAMWZHT7C3kT8RBWsv1U/dkYuNTB?=
 =?iso-8859-1?Q?1vZLIVbUmHhOTz4fYVPQmPiNAxb/GfiKVk5pUhEhd393QqfV5OayBcSUQK?=
 =?iso-8859-1?Q?49CC0Bt2vKgR3jPXz1hgfPhpGn2VLhqm6uXpFHMdcMbnhK/dSkgECdR8hz?=
 =?iso-8859-1?Q?kwiUlpDf4HwSaGi2389Gkw1GbQPauLX6gcD4hSE6rV8PDjrTZXewjCjfjj?=
 =?iso-8859-1?Q?vpNd7TmC56QXc6nj6r4ZPOpEiFkXZse5S9lmzMi79TP0kCWGXe1ifXT7oA?=
 =?iso-8859-1?Q?7tGRoULGPO1KD+yOlqenxizyv42LKQTYyhClG6XyrNvRKWjSjC8jE4FcaQ?=
 =?iso-8859-1?Q?NrDf2TcNNdXUYa4C7VpH/TzdVRLQtL3WTE3o2P0i8pLCYBZyoXyyN2asLM?=
 =?iso-8859-1?Q?KQYYzokn0BTDE=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8de426bc-2f73-49a5-1c78-08dc8bc2d30a
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2024 16:06:46.1573
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iCf65cq/NJGhngW/ELJ2/DKGPiFd9B/SmuSnL58s16/GZi87gRLbqQikdD5GORtbyHivSUsc1RF1DxSUXV2olA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB10234

On Mon, Jun 03, 2024 at 05:19:19PM +0200, Miquel Raynal wrote:
> Hi Frank,
> 
> Frank.Li@nxp.com wrote on Mon,  3 Jun 2024 11:15:26 -0400:
> 
> > When an In-Band Interrupt(IBI) occurs after svc_i3c_master_do_daa_locked(),
> > typically triggered during a Hot Join (HJ) event, the IBIWON flag fails to
> > be set when issuing an auto IBI command.
> > 
> > The issue stems from the omission of emitting STOP upon successful
> > execution of svc_i3c_master_do_daa_locked(). Consequently, the controller
> > interprets it as a repeat start when emitting the auto IBI command. Per the
> > I3C specification, an IBI should never occur during a repeat start, thus
> > preventing the IBIWON flag from being set.
> > 
> > Emit STOP regardless of the success or failure of
> > svc_i3c_master_do_daa_locked() to match I3C spec requirement.
> > 
> > Cc: <stable@vger.kernel.org>
> > Fixes: 05b26c31a485 ("i3c: master: svc: add hot join support")
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> 
> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

Please hold on this patch. Hardware can emit stop automatically. It need
better fix.  Let me work on new version for this one.

> 
> Thanks,
> Miqu?l