Received: by 2002:a89:413:0:b0:1fd:dba5:e537 with SMTP id m19csp265671lqs; Thu, 13 Jun 2024 09:25:01 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWhk3g264OmB8NdeG1eNAOTbiJy+GovsowksTW6hfAO/bCubvyRHM27dieVTQmX1qDtPpaPZKTNbg5eoyyNpvJ6SRiYpv/dzdMmxJ64Dg== X-Google-Smtp-Source: AGHT+IETWlGVyc9smnq32JzY7fK/ug8wzY4/372KUdhVJp5r/Hs+FgUl98thVvcGyOLTbkyCqRv0 X-Received: by 2002:a17:906:a44b:b0:a6f:1600:62cb with SMTP id a640c23a62f3a-a6f6080c699mr23038466b.3.1718295901816; Thu, 13 Jun 2024 09:25:01 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718295901; cv=pass; d=google.com; s=arc-20160816; b=TwdRRpCMqAWidcqKkptlS0pCYSfg7blNPW7S/znb+6xFzw9wiaKDPVoidbr0PNQbaP 7YXW6F+r2CWyUJ3NoIgFqnXXZ7D2ap+PnXm9Fp3z3XDG6upB2U9Z/g53wzSE8qAOobjT Xz3EnyimsjvcYC7rZCuQuXGer2Kta0w1Pf1alJ+TkYNTAPVzRME8wuViRrrfj5yEL9ZQ rlc4jdMWL5ga+TvBDjEDczODwooY0tEYuwaaiZz8GQh7MPaTSmUUpht1iBE9RQ03Pskb INce0WipNYGvyNjrdsHDRGK33JZ9ZL8d3JEnRfTCOpYU1FEI90f3109FRjr/MT7i5NvV 96BQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=xm9fvtFl5M9ClXulLO7X4Jg5vRT4Wu2KsAzkRuWsuxo=; fh=dc+rwCt8YVwrpLBeZG4phfhpjFG6jxFtZ0xUpm/4dRU=; b=Z/dVby90+TbibCoqodIBkwLTF/JMhB8fGbmbs7K6LeH0pA8YagHjr/oOedOwzm0YIs OyYFozJsxzyxOqV4pjmGsVR6jTV0P5MKNmOjWYTwbJPnmy77CQC0kLmB0+tohRasUDBv ezFug8mvogQ4R6j00r17ZFi9ho+waTjuOydUgnB9+zEvqejBvd55jGz1OWE2ogDTmlqn XikOtJ5y1w3EOsR5NyMxBU3KZdf4YkU6vgfPMjWJ7brPyFuLJOqJR1nrTeokXCLbgJ3a P6bUYZWyo3OvH6e7Mx2++tAhgFCb0OYaz0nOn1/+ox4XJtR/KtvbjgDMPvCQ4L42/Wc4 wDiQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=l6iF9Mjl; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-213642-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-213642-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id a640c23a62f3a-a6f5b4a6baesi61521566b.743.2024.06.13.09.25.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jun 2024 09:25:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-213642-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=l6iF9Mjl; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-213642-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-213642-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 834871F234B6 for ; Thu, 13 Jun 2024 16:25:01 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4A067381B0; Thu, 13 Jun 2024 16:24:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="l6iF9Mjl" Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8F0C12FB0B for ; Thu, 13 Jun 2024 16:24:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718295890; cv=none; b=g/hlUSbM8Ph//FiHcbGJx2xe++JGrBtEGbjYfotY/y7ciLFwSor9Uxh+KtaY579x4l8yMuBWJcSZmw3qXnZKuszkbHhw5rALfpIpd+JUCrGd/l2fFfYtVbsVi5zjv7lCJ+DdHESRmphnWUPu6bla+dlsNnj8j+lzWD/DH34++9A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718295890; c=relaxed/simple; bh=dBw9nOUl9fF7SB1r66qOP+3MBsu7aeGgqc4RXD6dJOw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pPYbAQ0UCufwJU2Mtsqqoy+ugdEhgAKAfUW1VzGhzMPYRJA4kpLcCM9H4CNsjGvKidYdiclZ5F85UivpCb38CsRlMYeIITQNwNLCX0Iwr4s43oH3keuHmSR4F79uvZCNRKhWK1O/X79fxnWxEqv6TQo87leGwpxkdsnoU7cbV1o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=l6iF9Mjl; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-35f1bc63981so1486363f8f.1 for ; Thu, 13 Jun 2024 09:24:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1718295887; x=1718900687; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xm9fvtFl5M9ClXulLO7X4Jg5vRT4Wu2KsAzkRuWsuxo=; b=l6iF9MjloMNMalTqu4bJrNkh63RZPCb1R5TIjRuPBlINZJSC7upsx+9qirtNl7sSv5 O8vTP9L4hmvWcVV7UA/pMK9brbYTPMnPV4PLyqKxfMvwDXsiyO4mcxcBzkbobN8JO/Sh a+QvisXIhJgw7O4ArHisT22shqw7OQuzTSz0krJJsDRvEBXSjM9xt8fSC7OxZ6EFwNav hc8tpJH6YnwquW09IddFRLQJ2fE0DQcXW6BUrbc7dpy0CxyT/JJsC2Zav3bMus3jJtGD DLOBx4ISE/bu05Dh5e66vQV7jdb+eA+w5jMg9wosvc87ZPO64OP7FQbzQ2XluXkeuj4u fNcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718295887; x=1718900687; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xm9fvtFl5M9ClXulLO7X4Jg5vRT4Wu2KsAzkRuWsuxo=; b=K05kSVlefD7+RpZJn13aJvsmaOfqXQ4amkPTO4l/IKr7yvgHEe5gP0OPRdFZ7b21Fg gLjpfJBND0+xf3g5f32eePwG9eP7ZIetjzlEumwwRRK6DVAjtA3waj6I+ngqMdhUrfI5 EWfFOhsS8hQ8JLqpE2w/n7F5yyjG7RLzwHnLx0tozDxdJ8OI975TF41/lcoml7cC04SJ uERshvFw02lbGwiJG3mztwx2nYsWUzgcnCQ1IhxH5VOUV+UiQL9ySFZtmJlwLlJNYdG8 77INRih3pjoYPh1dr1bXqMCj3/yatyGZFzofup3U+Qc2/DjvCG1IuHIqC7/8FkMazFyL ++LA== X-Forwarded-Encrypted: i=1; AJvYcCUd93CseFMZE7h9tfmgkTXKue2cBugw8ZufYOLvtjKTvihyEqKbNI6ewcKG/j2d/64Qul4yMOWXxkREQu9HAGbBTbTZrDYwhgGZ9dCE X-Gm-Message-State: AOJu0YzzczoG0gLkb9nLVWxEv468Vyqf7wG6FAWesH6daEdfdRJep/Df sLjl8BrcFmy0Z6WBcN+H7ZmUwqSUjhLtFHZdXpucOTkGnWT5Jp/beJnIss9SpKU= X-Received: by 2002:adf:f88c:0:b0:360:7386:1a49 with SMTP id ffacd0b85a97d-36073861df9mr2356972f8f.32.1718295887142; Thu, 13 Jun 2024 09:24:47 -0700 (PDT) Received: from aspen.lan (aztw-34-b2-v4wan-166919-cust780.vm26.cable.virginm.net. [82.37.195.13]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-360750ad20bsm2130332f8f.54.2024.06.13.09.24.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jun 2024 09:24:46 -0700 (PDT) Date: Thu, 13 Jun 2024 17:24:45 +0100 From: Daniel Thompson To: Dan Carpenter Cc: Patrick Gansterer , Lee Jones , Jingoo Han , Helge Deller , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] backlight: lm3509_bl: Fix NULL vs IS_ERR() check in register() function Message-ID: <20240613162445.GA24098@aspen.lan> References: <187b5bc5-a010-46c2-8ead-980df9efae79@moroto.mountain> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <187b5bc5-a010-46c2-8ead-980df9efae79@moroto.mountain> On Thu, Jun 06, 2024 at 04:10:23PM +0300, Dan Carpenter wrote: > The devm_backlight_device_register() doesn't return NULL, it returns > error pointers. Update the error checking to match. > > Fixes: b72755f5b577 ("backlight: Add new lm3509 backlight driver") > Signed-off-by: Dan Carpenter Reviewed-by: Daniel Thompson Daniel.