Received-SPF: pass (google.com: domain of linux-kernel+bounces-213646-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Abhinav Jain <jain.abhinav177@gmail.com>
To: bmarzins@redhat.com
Cc: agk@redhat.com,
	dm-devel@lists.linux.dev,
	jain.abhinav177@gmail.com,
	javier.carrasco.cruz@gmail.com,
	linux-kernel@vger.kernel.org,
	mpatocka@redhat.com,
	skhan@linuxfoundation.org,
	snitzer@kernel.org
Subject: Re: [PATCH] dm: Add support for escaped characters in str_field_delimit()
Date: Thu, 13 Jun 2024 16:30:15 +0000
Message-Id: <20240613163015.38097-1-jain.abhinav177@gmail.com>
In-Reply-To: <Zmc3vrfFglYISw1P@redhat.com>
References: <Zmc3vrfFglYISw1P@redhat.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

On Mon, Jun 10, 2024 at 01:11:40PM -0400, Benjamin Marzinski wrote:
> This doesn't do anything to the escape character. Presumably you want to
> pass the field containing a separator down to dm_eary_create(). But you
> don't want to pass the escape character itself.
>
> To work correctly, this code needs to remove all those escape characters
> that come before separators. It probably needs to do something like:
>
> 1. Find a next non-escaped separator and change it to NULL, so you have
> your field string.
>
> 2. Find all the escaped separators in the field string, and shift the
> rest of the string over to overwrite the escape character with the rest
> of the string.
>
> -Ben

Hi Ben,

I realised I should have done better testing after processing your feedback.
I have accordingly modified the code and shared a v2:
https://lore.kernel.org/all/20240613162632.38065-1-jain.abhinav177@gmail.com/

Please help review and provide feedback again. Thanks.