Received: by 2002:a89:413:0:b0:1fd:dba5:e537 with SMTP id m19csp277441lqs; Thu, 13 Jun 2024 09:43:11 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW7qbiMoJLFlRmnIekyQZuHcaod2lqymxWEG9fy90l9YCOHGjdKVIxQ3zsUqdhGjiGqlzsAVTBLmwydREja6ROHjtWgjyCnND8Mz2liog== X-Google-Smtp-Source: AGHT+IH2gCwtz2u2nL7olAxdeWnj9yCdFP2wOk+SXGMsAjs94rcBK4NK3e49hbNb2I3QdirhH0ij X-Received: by 2002:a50:8e59:0:b0:57c:a7dc:b0de with SMTP id 4fb4d7f45d1cf-57cbd906d33mr210403a12.39.1718296991721; Thu, 13 Jun 2024 09:43:11 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718296991; cv=pass; d=google.com; s=arc-20160816; b=h+ibMrAjxGA1RgcVXGX/yrybeiSNh1RCiQX/gMkAUx9s6MireBJMX4SKjegedvYs+N 7ipBc/2AGznhjQRE6ihhRIdl4YFr3jotxurF7accJ4GdaFXQYile3wig1NkFbAUifYrx 3nB4oqxfo19MiaWci+V+oa0AcXZxYR/bgrpJ0lA5fTtDohOU0HANak4e4McHF6mAV+sg gtUq0YNhnV5Ob4iug9owhvuYviJJ39ZjhqZKFOZP5uhlP+cVKHvxQjox0X/kzsi/EYlZ u1CWmgtSAIzZf/BqaLNZf59s+yMPy39PNi9fjizGY7JK+iohoDCrUezZrYP7BthxaYVC CU0A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=W7BI/oDuKrfyN14hJNfLnIiQEIOn26IuR45+/shmtyk=; fh=jGaPPDwELDRYyN/xnJK9D3rT+sMXVZyQlxqBME6sEck=; b=iS7ZjMaCTSe5bP+oSZx4CaRIveKB0AyE+umVm0ajtL0oC4ty9Q2m59BWD8KgIWtAGk +QaYY4oJ6CquCzucEldQLat/HaI3kEibRMVtWA2zgN8Naw0XnyAwtJkKQnavt9xGbCb4 0cD3+yVm5Rckc8ZDE6QW062udTxgxW/Fw4OVs2uTxBnSML5VI4ClVeNRz6WP6weSNo0+ mvBpIQTjy/J+OnCAWinppcTi2iiaUx3z/lnVybF51Czfxk0fFmnnDSVc1LMn8Kijl8Kx 38JmbpenHJiaHWFY73rezwH/4e1ZZxAHriWdPhSozCiOWt8IGbi3bkn+gR9aPpZyrz/c Fk/Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Kncp641X; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-213665-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-213665-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-57cb7447ddfsi858065a12.442.2024.06.13.09.43.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jun 2024 09:43:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-213665-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Kncp641X; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-213665-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-213665-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 721251F22AFA for ; Thu, 13 Jun 2024 16:43:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0EC37149C7A; Thu, 13 Jun 2024 16:42:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Kncp641X" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C0261369B0; Thu, 13 Jun 2024 16:42:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718296966; cv=none; b=r96Bmg1QrWH+Zm60bI5NHivV3p5QawgMoUa4KXsWl0INhMdV3D6WOte9zM2YCyqHNEfCgwQ/u2JJXn67tez+JhYaWbybF+xN65QFm/hgf4zmMXfdn9sY9PBsiOHdKjY2k46EnqJ6x+gg3EWGgH5zvJayZR6FMwAW0Y9Inc4pH9U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718296966; c=relaxed/simple; bh=k6RZFuL5RbQMXBfC1QGbjlIe42D9eii5Ww819cD7sCA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZZkiwHwpjkQxfCP3ZCVo169M1G08W7ohH5o9sWfjMJQCMLKgg4DzRNhnFAIWiGaZ13jeZLRQk340ym7YtVEM4fMKPU3Bl3SzD2JRa3LqeSGz4JrtNSYvLMqflNvIUljoeiQ3IEQ3tKFSrXuospUeSSd8VoKR3juG6+dJjjkTNLM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Kncp641X; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95BE0C2BBFC; Thu, 13 Jun 2024 16:42:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718296965; bh=k6RZFuL5RbQMXBfC1QGbjlIe42D9eii5Ww819cD7sCA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Kncp641X+UbghLKCtc6JUOvH5mOgzmtoEz/z4YK0RdIZ59bV2tVcBnppQgJB7g00v i4Qt+uGMjBwLFzx7fAkeb157E4AROuJI7qDYEjm5YCRB/qqM7NM4gFCBJj7BA5VnjP E2tFErP3LenNAcCr5q0F7sW641LObjwlB617yjTOuM1nNokJcs4HhsJBamqM7EyxKY WcfEHR3bIWoFqAOg7nDg4s9M4b11HZ77dTcXzFF+1gE4aY2onT15YV/Rcp8P6tQ4yo KjN8x5hP+GNpgpY9YCN2taV1QCRnSLox7fcvKDApOMcG8tvy+4Lz6u0t59RFrYeUCY czqPkuBZpIaWg== Date: Thu, 13 Jun 2024 10:42:44 -0600 From: Rob Herring To: Conor Dooley , Viacheslav Cc: Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org Subject: Re: [PATCH v5 3/4] dt-bindings: arm: amlogic: amlogic,meson-gx-ao-secure: add secure-monitor property Message-ID: <20240613164244.GA1999034-robh@kernel.org> References: <20240610084032.3096614-1-adeep@lexina.in> <20240610084032.3096614-4-adeep@lexina.in> <20240610-dropout-compress-6d6a9b749524@spud> <4866f6d4-2e3c-40c7-a8cb-ba4e422ffef6@lexina.in> <20240611-undying-earthy-00236ac251aa@spud> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240611-undying-earthy-00236ac251aa@spud> On Tue, Jun 11, 2024 at 07:07:28PM +0100, Conor Dooley wrote: > On Tue, Jun 11, 2024 at 01:25:11PM +0300, Viacheslav wrote: > > Hi! > > > > 10/06/2024 19.08, Conor Dooley wrote: > > > On Mon, Jun 10, 2024 at 11:39:49AM +0300, Viacheslav Bocharov wrote: > > > > Add secure-monitor property to schema for meson-gx-socinfo-sm driver. > > > > > > "bindings are for hardware, not drivers". Why purpose does the "secure > > > monitor" serve that the secure firmware needs a reference to it? > > > > This driver is an extension to the meson-gx-socinfo driver: it supplements > > information obtained from the register with information from the > > SM_GET_CHIP_ID secure monitor call. Due to the specifics of the module > > loading order, we cannot do away with meson-gx-socinfo, as it is used for > > platform identification in some drivers. Therefore, the extended information > > is formatted as a separate driver, which is loaded after the secure-monitor > > driver. > > Please stop talking about drivers, this is a binding which is about > hardware. Please provide, in your next version, a commit message that > justifies adding this property without talking about driver probing > order etc, and instead focuses on what service the "secure monitor" > provides etc. To put it another way, how many secure monitors does 1 system have? What do you do if the property is not present? You didn't make it required which is good because that would be an ABI break. You only need a link in DT if there are different possible providers or some per consumer information to describe (e.g. an interrupt number or clock ID). You don't have the latter and likely there is only 1 possible provider. Rob