Received-SPF: pass (google.com: domain of linux-kernel+bounces-213682-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <9d7623fb-be0f-4adf-e9e0-17ac2f7ebaba@quicinc.com>
Date: Thu, 13 Jun 2024 22:20:07 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH 4/4] arm64: dts: qcom: x1e80100: Add fastrpc nodes
Content-Language: en-US
To: Bjorn Andersson <andersson@kernel.org>
CC: <konrad.dybcio@linaro.org>, <djakov@kernel.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <srinivas.kandagatla@linaro.org>,
        <linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-pm@vger.kernel.org>,
        <quic_rgottimu@quicinc.com>, <quic_kshivnan@quicinc.com>,
        <conor+dt@kernel.org>, <dmitry.baryshkov@linaro.org>,
        <abel.vesa@linaro.org>
References: <20240604011157.2358019-1-quic_sibis@quicinc.com>
 <20240604011157.2358019-5-quic_sibis@quicinc.com>
 <wnvet65zg3s6lqnnn5xd4zzx4jwdclbfh3ywy4ut3cal2wmoto@3z3burliivyo>
From: Sibi Sankar <quic_sibis@quicinc.com>
In-Reply-To: <wnvet65zg3s6lqnnn5xd4zzx4jwdclbfh3ywy4ut3cal2wmoto@3z3burliivyo>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 6/6/24 08:15, Bjorn Andersson wrote:
> On Tue, Jun 04, 2024 at 06:41:57AM GMT, Sibi Sankar wrote:
>> Add fastrpc nodes for ADSP and CDSP on X1E80100 SoC.
>>
> 
> This looks pretty unrelated to bwmon, could it not have been sent alone?

lol, I figured that the rest of the series was in decent shape to
land. Let me resend this one out standalone.

-Sibi

> 
> Regards,
> Bjorn
> 
>> Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/x1e80100.dtsi | 156 +++++++++++++++++++++++++
>>   1 file changed, 156 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
>> index d86c4d3be126..4edabe0ff592 100644
>> --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
>> @@ -5567,6 +5567,55 @@ IPCC_MPROC_SIGNAL_GLINK_QMP
>>   				label = "lpass";
>>   				qcom,remote-pid = <2>;
>>   
>> +				fastrpc {
>> +					compatible = "qcom,fastrpc";
>> +					qcom,glink-channels = "fastrpcglink-apps-dsp";
>> +					label = "adsp";
>> +					qcom,non-secure-domain;
>> +					#address-cells = <1>;
>> +					#size-cells = <0>;
>> +
>> +					compute-cb@3 {
>> +						compatible = "qcom,fastrpc-compute-cb";
>> +						reg = <3>;
>> +						iommus = <&apps_smmu 0x1003 0x80>,
>> +							 <&apps_smmu 0x1063 0x0>;
>> +						dma-coherent;
>> +					};
>> +
>> +					compute-cb@4 {
>> +						compatible = "qcom,fastrpc-compute-cb";
>> +						reg = <4>;
>> +						iommus = <&apps_smmu 0x1004 0x80>,
>> +							 <&apps_smmu 0x1064 0x0>;
>> +						dma-coherent;
>> +					};
>> +
>> +					compute-cb@5 {
>> +						compatible = "qcom,fastrpc-compute-cb";
>> +						reg = <5>;
>> +						iommus = <&apps_smmu 0x1005 0x80>,
>> +							 <&apps_smmu 0x1065 0x0>;
>> +						dma-coherent;
>> +					};
>> +
>> +					compute-cb@6 {
>> +						compatible = "qcom,fastrpc-compute-cb";
>> +						reg = <6>;
>> +						iommus = <&apps_smmu 0x1006 0x80>,
>> +							 <&apps_smmu 0x1066 0x0>;
>> +						dma-coherent;
>> +					};
>> +
>> +					compute-cb@7 {
>> +						compatible = "qcom,fastrpc-compute-cb";
>> +						reg = <7>;
>> +						iommus = <&apps_smmu 0x1007 0x80>,
>> +							 <&apps_smmu 0x1067 0x0>;
>> +						dma-coherent;
>> +					};
>> +				};
>> +
>>   				gpr {
>>   					compatible = "qcom,gpr";
>>   					qcom,glink-channels = "adsp_apps";
>> @@ -5656,6 +5705,113 @@ IPCC_MPROC_SIGNAL_GLINK_QMP
>>   
>>   				label = "cdsp";
>>   				qcom,remote-pid = <5>;
>> +
>> +				fastrpc {
>> +					compatible = "qcom,fastrpc";
>> +					qcom,glink-channels = "fastrpcglink-apps-dsp";
>> +					label = "cdsp";
>> +					qcom,non-secure-domain;
>> +					#address-cells = <1>;
>> +					#size-cells = <0>;
>> +
>> +					compute-cb@1 {
>> +						compatible = "qcom,fastrpc-compute-cb";
>> +						reg = <1>;
>> +						iommus = <&apps_smmu 0x0c01 0x20>,
>> +							 <&apps_smmu 0x0c21 0x20>;
>> +						dma-coherent;
>> +					};
>> +
>> +					compute-cb@2 {
>> +						compatible = "qcom,fastrpc-compute-cb";
>> +						reg = <2>;
>> +						iommus = <&apps_smmu 0x0c02 0x20>,
>> +							 <&apps_smmu 0x0c22 0x20>;
>> +						dma-coherent;
>> +					};
>> +
>> +					compute-cb@3 {
>> +						compatible = "qcom,fastrpc-compute-cb";
>> +						reg = <3>;
>> +						iommus = <&apps_smmu 0x0c03 0x20>,
>> +							 <&apps_smmu 0x0c23 0x20>;
>> +						dma-coherent;
>> +					};
>> +
>> +					compute-cb@4 {
>> +						compatible = "qcom,fastrpc-compute-cb";
>> +						reg = <4>;
>> +						iommus = <&apps_smmu 0x0c04 0x20>,
>> +							 <&apps_smmu 0x0c24 0x20>;
>> +						dma-coherent;
>> +					};
>> +
>> +					compute-cb@5 {
>> +						compatible = "qcom,fastrpc-compute-cb";
>> +						reg = <5>;
>> +						iommus = <&apps_smmu 0x0c05 0x20>,
>> +							 <&apps_smmu 0x0c25 0x20>;
>> +						dma-coherent;
>> +					};
>> +
>> +					compute-cb@6 {
>> +						compatible = "qcom,fastrpc-compute-cb";
>> +						reg = <6>;
>> +						iommus = <&apps_smmu 0x0c06 0x20>,
>> +							 <&apps_smmu 0x0c26 0x20>;
>> +						dma-coherent;
>> +					};
>> +
>> +					compute-cb@7 {
>> +						compatible = "qcom,fastrpc-compute-cb";
>> +						reg = <7>;
>> +						iommus = <&apps_smmu 0x0c07 0x20>,
>> +							 <&apps_smmu 0x0c27 0x20>;
>> +						dma-coherent;
>> +					};
>> +
>> +					compute-cb@8 {
>> +						compatible = "qcom,fastrpc-compute-cb";
>> +						reg = <8>;
>> +						iommus = <&apps_smmu 0x0c08 0x20>,
>> +							 <&apps_smmu 0x0c28 0x20>;
>> +						dma-coherent;
>> +					};
>> +
>> +					/* note: compute-cb@9 is secure */
>> +
>> +					compute-cb@10 {
>> +						compatible = "qcom,fastrpc-compute-cb";
>> +						reg = <10>;
>> +						iommus = <&apps_smmu 0x0c0c 0x20>,
>> +							 <&apps_smmu 0x0c2c 0x20>;
>> +						dma-coherent;
>> +					};
>> +
>> +					compute-cb@11 {
>> +						compatible = "qcom,fastrpc-compute-cb";
>> +						reg = <11>;
>> +						iommus = <&apps_smmu 0x0c0d 0x20>,
>> +							 <&apps_smmu 0x0c2d 0x20>;
>> +						dma-coherent;
>> +					};
>> +
>> +					compute-cb@12 {
>> +						compatible = "qcom,fastrpc-compute-cb";
>> +						reg = <12>;
>> +						iommus = <&apps_smmu 0x0c0e 0x20>,
>> +							 <&apps_smmu 0x0c2e 0x20>;
>> +						dma-coherent;
>> +					};
>> +
>> +					compute-cb@13 {
>> +						compatible = "qcom,fastrpc-compute-cb";
>> +						reg = <13>;
>> +						iommus = <&apps_smmu 0x0c0f 0x20>,
>> +							 <&apps_smmu 0x0c2f 0x20>;
>> +						dma-coherent;
>> +					};
>> +				};
>>   			};
>>   		};
>>   	};
>> -- 
>> 2.34.1
>>
>