Received: by 2002:a89:413:0:b0:1fd:dba5:e537 with SMTP id m19csp297776lqs; Thu, 13 Jun 2024 10:14:35 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUxyHVc83MZZwXVF5QW3wcYQnSX/RchOaymvQo/eJuKpnQeyCaTu1HnPYOLZ2a78sBiaevUtObAN/qiQ4AmpEd+szfPUI7dpurW6iXiEQ== X-Google-Smtp-Source: AGHT+IHdDUTX/xosGTD7Eg7qUzOACCrFPSR1sqS9rE2a7jDzBEZPkVhiDLdZgNtJRvaJxvUrLDss X-Received: by 2002:ad4:450e:0:b0:6b0:7997:ee34 with SMTP id 6a1803df08f44-6b2afd5af25mr2032936d6.50.1718298875043; Thu, 13 Jun 2024 10:14:35 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718298875; cv=pass; d=google.com; s=arc-20160816; b=BdHUOceNwbdBmNpNnMQ18wJ3oHiLIHanMEa8mXZ8OJVyZkWvHl+tzqQA9hTKIOv9fa 83aiUUBHYGIO7Nmj8OZkYunwRaQ94x/w7bLYtGqdGt4ZGQaeZKefjFmYU7sdSiHkYgD6 RVbN2+ndNGDn4PYQEauA7hQkU8+a9uOxxruSabJP9RWQsoHX0whkoVs3zTbqZrstKpjB nvDNbeD/0mGPo5UBodR3ouoDNKBzyKFrOP/h11mAvWL/1kUM8jIYyPBSLYULai8S250r rhVEUMdVpzIJvNzU5st4heXo7iFePAj0gwKxKFL3NB832FhjzxwUoaMjrqhFKFyTHDiI 4uHw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=JW6D9qyMJ+3ReIzyvd9WzhZV2PK8OZhYAxv60Em/Llc=; fh=aDKu0FMA6mltGpVnpskguljJfX/PXlX+qA7eYoSeCm4=; b=pv7Dy0F1HyF5WhiFNLUU8zU8vfn2AdmuFNYeKIBX4enrgetECBw/ALgXMQ0EILCKNO ynymrFDbOs4d9Rij+9VkrtriSytngfIMdC7mF4Sw3AXhIm2IdEzds2uL1oJKmv0N3wfU B/IOoWFlaR+OD7kwUxLlZPPldl8nQZgFXRSunmEJSLxHgdPhhKWipznkuhrJP2n9iKlZ BZTa3kfwAdiKqzzQN09n9PZaomo9AMZmnf9WKZJts4MceqxDaIISRVy5hY0BxZfHGoTE fe96v9gUZTHe7cAbDSaV1fnBbMb+dSifcn/QMPmIysH4GC6RnlZ5htpXp06ttiB9E54t rDNQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BrwSztuf; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-213721-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-213721-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id 6a1803df08f44-6b2a5a17497si18948846d6.122.2024.06.13.10.14.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jun 2024 10:14:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-213721-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BrwSztuf; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-213721-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-213721-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id B31D91C2496A for ; Thu, 13 Jun 2024 17:14:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3840514A4CF; Thu, 13 Jun 2024 17:14:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BrwSztuf" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 646A213CF85 for ; Thu, 13 Jun 2024 17:14:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718298840; cv=none; b=jMh6inM5bKhrZr8B8NZYCtS2Xy3HSMlORXLGY+a784rXJNOre/EEA/d9gGIG/ukILmUJvx3U+QhGkTpqMc47hB32PhfhEOHdZWR0cNQJH2D3NGlALDDZFKQNPoARSBiFwU5np5n17HIFFl9pxzVLWYXUGIDleJzFMJVtvhiHOpE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718298840; c=relaxed/simple; bh=xemkdhPMGacNYdydf3flaCBK3tVRLFLqTB5UykdcJv0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sCo5SJrKupxaSntPhc6vX1CdW1ApdOYtVjFBa04YhtNU4xbZoJIZJZfO+7J0UeMUxHIu9NLBbo1GFSPBgiNGDrgkCWRRzSIKQc8xNPwWdTFyI17xsqTcf23LUiEXCQ/lPCl+/DUEo2UUS34i8zfroxVWMxqEf/9T3imArydl+20= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BrwSztuf; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5B86AC2BBFC; Thu, 13 Jun 2024 17:13:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718298840; bh=xemkdhPMGacNYdydf3flaCBK3tVRLFLqTB5UykdcJv0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BrwSztuf2UyF8ICFbnT1JxRDtLAVjD0tVNdIryD0mJ72D1UX++X7EMnzAs4c+vQLj KoYNvh6p8fxQx6qAFTzoyCzZC8+39MhhTGuCidJweBbMOcPqa4vLPBAW0sq1sHLceY Mr1gw8Zl0gsIHveOv/IxqSokdS/rCTNrmxRhFPr5/RgFClew5xRbMKjrwaS96rmdMv lO1da+4mlz7z1rCY9Ty3EnU/4IsPZlk5NA2g9nJ3uZ0eISbQz+jbrlZElAzmXNRuY+ QhOqeH0JxqIImh2/ESM16SKf1ykSv/Wp2gjRowhNT7qCGDoe51t5l9qFzZz4wbNFN8 ybDsNIAcZfWaA== Date: Thu, 13 Jun 2024 18:13:56 +0100 From: Lee Jones To: Andrew Davis Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: tps65912: Use devm helper functions to simplify probe Message-ID: <20240613171356.GR2561462@google.com> References: <20240610153824.218260-1-afd@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240610153824.218260-1-afd@ti.com> On Mon, 10 Jun 2024, Andrew Davis wrote: > This simplifies probe and also allows us to remove the remove > callbacks from the core and interface drivers. Do that here. > > Signed-off-by: Andrew Davis > --- > drivers/mfd/tps65912-core.c | 21 +++++++-------------- > drivers/mfd/tps65912-i2c.c | 8 -------- > drivers/mfd/tps65912-spi.c | 8 -------- > include/linux/mfd/tps65912.h | 1 - > 4 files changed, 7 insertions(+), 31 deletions(-) Doesn't apply. Please be kind enough to rebase onto the latest Linux -next and resubmit. -- Lee Jones [李琼斯]