Received-SPF: pass (google.com: domain of linux-kernel+bounces-213756-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Thu, 13 Jun 2024 11:35:39 -0600
From: Rob Herring <robh@kernel.org>
To: Elliot Berman <quic_eberman@quicinc.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Sebastian Reichel <sre@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Vinod Koul <vkoul@kernel.org>,
	Andy Yan <andy.yan@rock-chips.com>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
	Satya Durga Srinivasu Prabhala <quic_satyap@quicinc.com>,
	Melody Olvera <quic_molvera@quicinc.com>,
	Shivendra Pratap <quic_spratap@quicinc.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Florian Fainelli <florian.fainelli@broadcom.com>,
	linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v4 1/4] dt-bindings: power: reset: Convert mode-.*
 properties to array
Message-ID: <20240613173539.GA2038101-robh@kernel.org>
References: <20240611-arm-psci-system_reset2-vendor-reboots-v4-0-98f55aa74ae8@quicinc.com>
 <20240611-arm-psci-system_reset2-vendor-reboots-v4-1-98f55aa74ae8@quicinc.com>
 <20240611204001.GA3026541-robh@kernel.org>
 <20240611160619020-0700.eberman@hu-eberman-lv.qualcomm.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240611160619020-0700.eberman@hu-eberman-lv.qualcomm.com>

On Tue, Jun 11, 2024 at 04:23:00PM -0700, Elliot Berman wrote:
> On Tue, Jun 11, 2024 at 02:40:01PM -0600, Rob Herring wrote:
> > On Tue, Jun 11, 2024 at 08:35:13AM -0700, Elliot Berman wrote:
> > > PSCI reboot mode will map a mode name to multiple magic values instead
> > > of just one. Convert the mode-.* property to an array. Users of the
> > > reboot-mode schema will need to specify the maxItems of the mode-.*
> > > properties. Existing users will all be 1.
> > > 
> > > Signed-off-by: Elliot Berman <quic_eberman@quicinc.com>
> > > ---
> > >  .../devicetree/bindings/power/reset/nvmem-reboot-mode.yaml        | 5 +++++
> > >  Documentation/devicetree/bindings/power/reset/qcom,pon.yaml       | 8 ++++++++
> > >  Documentation/devicetree/bindings/power/reset/reboot-mode.yaml    | 4 ++--
> > >  .../devicetree/bindings/power/reset/syscon-reboot-mode.yaml       | 5 +++++
> > >  4 files changed, 20 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/power/reset/nvmem-reboot-mode.yaml b/Documentation/devicetree/bindings/power/reset/nvmem-reboot-mode.yaml
> > > index 627f8a6078c2..9b9bbc0f29e7 100644
> > > --- a/Documentation/devicetree/bindings/power/reset/nvmem-reboot-mode.yaml
> > > +++ b/Documentation/devicetree/bindings/power/reset/nvmem-reboot-mode.yaml
> > > @@ -31,6 +31,11 @@ properties:
> > >  allOf:
> > >    - $ref: reboot-mode.yaml#
> > >  
> > > +patternProperties:
> > > +  "^mode-.*$":
> > > +    items:
> > > +      maxItems: 1
> > 
> > Drop 'items'. Otherwise, you are defining constraints of a matrix.
> > 
> 
> If I do this, I also have to add $ref: .../uint32-array as well so
> the property can be picked up as an array type. Let me know if this isn't
> right, otherwise I'll send out a fixed version in a few days.

Ah, I suppose the tools get confused with what to do here. That's an 
issue I'm working on addressing. The issue is everything is a matrix 
because without other information for a property we don't know how to 
decode them. But with the schemas being fairly complete now and the move 
away from DTB->YAML decoding, we can decode properties to the right 
type. One issue to switch over is places where this 'everything is a 
matrix' crept into schemas. I've been fixing these. The above is an 
example of this.

So for now, just drop 'items'. It won't enforce anything, but once we 
switch over it will.

Rob