Received-SPF: pass (google.com: domain of linux-kernel+bounces-213774-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <aa2f473c-38e3-44a6-a039-99b42d9a51d0@amd.com>
Date: Thu, 13 Jun 2024 12:52:32 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v11 6/9] cpufreq: amd-pstate: Add set_boost callback for
 active mode
To: Perry Yuan <perry.yuan@amd.com>, gautham.shenoy@amd.com,
 Borislav.Petkov@amd.com
Cc: rafael.j.wysocki@intel.com, viresh.kumar@linaro.org,
 Alexander.Deucher@amd.com, Xinmei.Huang@amd.com, Xiaojian.Du@amd.com,
 Li.Meng@amd.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <cover.1718262992.git.perry.yuan@amd.com>
 <c46eb6d79bd8e7068955cf993ffc6b726d86eb92.1718262992.git.perry.yuan@amd.com>
Content-Language: en-US
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <c46eb6d79bd8e7068955cf993ffc6b726d86eb92.1718262992.git.perry.yuan@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YTgwWFNvL1hGYmpmeE5jcDF3UklqK0V3eGM3WUJvb3BlNnFyVmxpdXdPbWVH?=
 =?utf-8?B?Uk1KaUxtM1hYbmZrVEtjYk9GNmhmaEZqVkJENmRTcE1WSU93MXdubGxVYWxt?=
 =?utf-8?B?eDNNQUJ1RE9uNDIvSnBRWmViMFhTOUlsK1FJTzdzZW0wR2tXOFZFdTR1RjNX?=
 =?utf-8?B?ZlJEZEUvTEtIbmlsUTdrWWpUK2Ntek4xMnFJbWR4TkNuczRETXhyZDUybDd4?=
 =?utf-8?B?ODVmZmtlR2pzcjhPUlZwRnI1a3ZDSFNidUJPeUp2QlR5Yi8xazN1ZmdNZU81?=
 =?utf-8?B?dXBDRVhCbUMzSkFMT3g2Q1ptLzhwd0RZZC9NdVQ4QldPVmt5QldKc2diMmwr?=
 =?utf-8?B?TDFVNlg3TzJOaVViazFmcEFKNzRiT3NUeVFEN09ySytwNk1NdkFUZVZmdTNG?=
 =?utf-8?B?VVozK0E3ZUw1ZWZJNWVXTExscFpvQzNJQUtmUVh3Yk1JUGtrdHozMUdSUDhh?=
 =?utf-8?B?VWplbTF6Wk9EOWF1TmQxVi9FSnJ1UjMxQ2ZLSHhNZkl0Nmw3Y0tjbGozNDNy?=
 =?utf-8?B?R3NYd3RQcFQrSG9kYkNKYU1UMDJDdVdaNHRqMm8wVHc1UkxUNVF6aU9LV3R4?=
 =?utf-8?B?bEFzdk1GNGZUNExBK0k5ODRraVBuaVREK1BxUk1nYXZSR0NRZ3lJaWx0NmM0?=
 =?utf-8?B?c2MrS3M5SW8rTk5rb01ta2s1cWFHbHA2cnV2ZTY5K1BrRkVQcXlNVXVqN0ZD?=
 =?utf-8?B?NUxkWVdrUHdWWlRyTkU5WXRCUGJTbjZ0amVXQjZDQWFYZEZkZnlGb3h5azhz?=
 =?utf-8?B?UFFURlFCc0Y1YkoxeVVEb2hFRUhpOGRMMmswbm9acVhRRUZLUkQxTkxyVk5o?=
 =?utf-8?B?R1dXdHdlOWdlcUp0VFBWQ1VxRVN0OXBqVEFZUnNsRkdvKys2VVltSnFVWllP?=
 =?utf-8?B?TjUyQlp2UVZjeWczbDVsczJRZ0Rla20yNWs5OGMvblBlVHFZdktISVJWQk5k?=
 =?utf-8?B?aGRwbVp4K0dQZ21mbXNlU2hOUERMVDVjY0dIMWJZZVJpdkQ1MjFsQ29Wd1cy?=
 =?utf-8?B?V0xTQTJZR1BSL2RRUnpqWTEycUZtSDQ0SjJ2aExCVjVvWmw4anRUcUFtY0dT?=
 =?utf-8?B?UUJ5bmMvb2ZwRkdQNUNJbmhYYVFsYi9Ca2NXb0xOcTBOdkZmUnJkYWt1eGdO?=
 =?utf-8?B?MFBkSGVWRUlrQnFkUTF6S2JrcW1VU3JFMHJvZ3RYUERjM0NSaDdJZUl6Lzd1?=
 =?utf-8?B?bmFCRnhxUW1HYVdQM2lIMEE3Rnp0RGVFek8xbk5wZFZIS2szbE8yRERGOHFO?=
 =?utf-8?B?djIwR2Z1a3NwWXZEUnp5L3lIaHIyZmR2Ym51YUhPNHM1SlpRTjZxa25jYy9E?=
 =?utf-8?B?OXNFa2dFV2lFNDRmM3VicDA1RzI5OU92dUhvaXBUVG1Ed3dPdXZBdUdHRlpr?=
 =?utf-8?B?bmc2YzFtQnFTeWdvNUd4WGhkaHkvUVV5bVdsaitmOGVwN0NoZHo4dG9DemJi?=
 =?utf-8?B?cFNJNHk2M1dqZDl5QkZqcml1SlBpdktYOWU1VCtJTEwwSmEyY0RiUEY4bGkr?=
 =?utf-8?B?WGhoaXdqUmVGbVVVQ3hSdkE2Mm5HTmdNSWFTKzRNRm1QM0tMRVdiZStwQjNk?=
 =?utf-8?B?YUF2cHJjTDJpc25WeitycnRhMUM0c0xEd0xpWEoxbEx0Q2ZrUXh5eXFpSnRw?=
 =?utf-8?B?eDNSd0Zoc3RVUllBcEpmbEduQmhEVDhwcG5aK3JzN3UxOWk4S01QdlR4MHRo?=
 =?utf-8?B?YlZjd2xlZWgrRDYwQk5hTHozd0l0d0x6NzE5dUR6ZzJZd0ZNZVJxWVJLOU9Z?=
 =?utf-8?B?VjhGTjNkSm41SmVHQTVwaHJteHNnRFNzOGpBRWFmZlN6QnFPRURDYkZUUmJZ?=
 =?utf-8?B?OTJpckRid3RZODRpQkthejNBYXJ6aVNTK3NUdERYNThjUjhWRUxPV0c3YnpI?=
 =?utf-8?B?Q0tqMkZ1OVJ0NmxxVWo4cXJwR1dGU0ZtcGovUjBSTHRJSnJ6VHJjWWRsOWdN?=
 =?utf-8?B?WkJuZ1U5K1B3YTdrZEFQS3RteW1uS0ZNQzZrQmc1NTFiMjBPWmt4N0xGNEJB?=
 =?utf-8?B?SlNzTXZMUXFETEpPVTVjdjRxb2lwSVFvVWkwTEtab1BQNjVDTGdndzhmZEJt?=
 =?utf-8?B?VHJrbjlLblhSeHVPbGF1Rjlia2ozK25Ld05IenlqL2g4QXB1NGh0SHFuSEpH?=
 =?utf-8?Q?zRMtguX6qoIS4o3pQ8nU9qtuO?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 395a43b4-7a77-4575-0437-08dc8bd19b67
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2024 17:52:35.2619
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dO7kQae8J2PBIjT9BrAtKQd1q7Gq90tUoj1I4qQLP9y6tZmsJwMbh/XG0pOefX1JkVUp7gh/rbXa5Io0Y/8qsQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7690

On 6/13/2024 02:25, Perry Yuan wrote:
> Add support for the set_boost callback in the active mode driver to
> enable boost control via the cpufreq core. This ensures a consistent
> boost control interface across all pstate modes, including passive
> mode, guided mode, and active mode.
> 
> With this addition, all three pstate modes can support the same boost
> control interface with unique interface and global CPB control. Each
> CPU also supports individual boost control, allowing global CPB to
> change all cores' boost states simultaneously. Specific CPUs can
> update their boost states separately, ensuring all cores' boost
> states are synchronized.
> 
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>
> ---
>   drivers/cpufreq/amd-pstate.c | 18 +++++-------------
>   1 file changed, 5 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index fe7c9d3562c5..d07f09dd7eab 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -701,20 +701,11 @@ static int amd_pstate_set_boost(struct cpufreq_policy *policy, int state)
>   		pr_err("Boost mode is not supported by this processor or SBIOS\n");
>   		return -ENOTSUPP;
>   	}
> +	mutex_lock(&amd_pstate_driver_lock);
> +	ret = amd_pstate_cpu_boost(policy->cpu, state);
> +	mutex_unlock(&amd_pstate_driver_lock);
>   
> -	if (state)
> -		policy->cpuinfo.max_freq = cpudata->max_freq;
> -	else
> -		policy->cpuinfo.max_freq = cpudata->nominal_freq * 1000;
> -
> -	policy->max = policy->cpuinfo.max_freq;
> -
> -	ret = freq_qos_update_request(&cpudata->req[1],
> -				      policy->cpuinfo.max_freq);
> -	if (ret < 0)
> -		return ret;
> -
> -	return 0;
> +	return ret < 0 ? ret : 0;

What's wrong with just doing this instead:

return ret;

>   }
>   
>   static int amd_pstate_boost_set(struct amd_cpudata *cpudata)
> @@ -1875,6 +1866,7 @@ static struct cpufreq_driver amd_pstate_epp_driver = {
>   	.resume		= amd_pstate_epp_resume,
>   	.update_limits	= amd_pstate_update_limits,
>   	.init_boost	= amd_pstate_init_boost,
> +	.set_boost	= amd_pstate_set_boost,
>   	.name		= "amd-pstate-epp",
>   	.attr		= amd_pstate_epp_attr,
>   };