Received-SPF: pass (google.com: domain of linux-kernel+bounces-213775-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <79024a39-63c0-4d86-ba48-618f59df729e@amd.com>
Date: Thu, 13 Jun 2024 12:53:35 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v11 9/9] Documentation: cpufreq: amd-pstate: update doc
 for Per CPU boost control method
To: Perry Yuan <perry.yuan@amd.com>, gautham.shenoy@amd.com,
 Borislav.Petkov@amd.com
Cc: rafael.j.wysocki@intel.com, viresh.kumar@linaro.org,
 Alexander.Deucher@amd.com, Xinmei.Huang@amd.com, Xiaojian.Du@amd.com,
 Li.Meng@amd.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <cover.1718262992.git.perry.yuan@amd.com>
 <f0c47cba673261c7d868d5236d3ffb15ae092e74.1718262992.git.perry.yuan@amd.com>
Content-Language: en-US
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <f0c47cba673261c7d868d5236d3ffb15ae092e74.1718262992.git.perry.yuan@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RWxtNDRtcDhkbThLSTJlMEdya094VXVISWhPbW5ObmNjMFNTMkZDenFPZWkx?=
 =?utf-8?B?Q1VNMGE5SXNiU2hnL1RJd0tTZlJrUEc5blA0R1hiTWZ2Nk5VTmI4OEdoY250?=
 =?utf-8?B?S0VCWWtVckdBZGNWQmpoQXpPQ05rS0Z1M0RYVWYvc3E5eGRSZ3BPVHB6MG1Y?=
 =?utf-8?B?anZpaDlPMlJIM2M5aWZpWXZxeEdSUVdqMHhyZk5xaEJHRURYeHVsS0FENmlY?=
 =?utf-8?B?QVpqZFV0K0hSemtyb3BFTnpPUGwvUEdpcVEvbm00RmtUODR3Q0J2ZkdNYWZi?=
 =?utf-8?B?NHh5RUZSYnNJcTNZVHZxUXpDM0hCSlNzTUtvT21ZR2QxYlhvWDZZdkhNK1Vz?=
 =?utf-8?B?OXQzMGJvYXIvUERDQnc2dmhrRi9mSE11VUVodVlCT0lZNWVpdmR4N3dKc0JG?=
 =?utf-8?B?Vks3RUR2UUhjejJwVmVncXpDK1FEcHhQek5Fa0MvQWVSVEM1UHNLQ2hwWEs0?=
 =?utf-8?B?QlMvcmpjK2FseFl6aDBZaWR4RHg4R0M3ZHZ4c1g1MktZaGRIZ0NlWEpsVzE2?=
 =?utf-8?B?eW1kNEdPaVRwODlnWHJMRDdwSUlnVTBlK0dJTFFZMjdoQzQ5VjNKMk9rTWFP?=
 =?utf-8?B?M0FNdXhMenludFUxblRqMmZZMy9mMldkSVRmZURYdHovMkdTUHNjV2dDaFlE?=
 =?utf-8?B?eHNrWmM1eVUxSGNZbXpiM3Q3Z3VNbEdEVmJ5cFl5MmlzcytHN1NuSGFJcWVw?=
 =?utf-8?B?MFdaYzFXWlluM1EwcWpXeC9IVExJMzhZbXNENFNBeFEyMGtaTVpQS3cwWjVZ?=
 =?utf-8?B?cjkwNVovRnYvcTdPM3VCSlUvVW5vOXJHYlppamtGTXc4aXFwWmtTWmtWQkcz?=
 =?utf-8?B?UlNrNlBiTzRxNW90cG1nRjlTQ012M0RwR3Q2STMyZXB5Q0habG9zVWNJYVlo?=
 =?utf-8?B?cEF3SXBqSkRtSlREQnpZUDVsUFhoZjVZZExHdlkvT202Nk96U2UvUzlLMlRL?=
 =?utf-8?B?bDBsV3YrWjlvWVhIcTcxYlo2UU1VUmluaWJCWEZQY1A5dlAwblhhMWVQT2Fl?=
 =?utf-8?B?UFhOWWU2ektnUkh2bW9ibE1tazAvUGdMV3RyUXhtTVowNENoVDQzdE9nVE9B?=
 =?utf-8?B?Z3lSR0lpbmRZM0dRSVpFUTM4U0FBUmRCMFVqRm4rRmNjYzc2VjF5RDNmSitl?=
 =?utf-8?B?bVdPajFRRWtyeXBrR015N2ZoQ2ZKYi9SQmZWVTJSeWZkTFhMangvZG5CakRi?=
 =?utf-8?B?cFRIaWY3c2dqMGhINFRZSVJudVJsekdpcHBSMEJ4dHZBVkMrc3IwRlFqRTFO?=
 =?utf-8?B?RHdzWnAycE03QXlSc0p6eGJhc0p2bkFkdFdDVFBxU1hPNk9NekM0ZWdxV3BZ?=
 =?utf-8?B?S2d3Unh6RWhaTWxjWEJyRDE3Q3Jkc3JBaW1lbnVjcU9aSmFSdzZqZnE3WnZi?=
 =?utf-8?B?aGNlNHBJZVkrKy85UHM4TlVwK2gyNStqZWp4RjFBOXVjUVlpdW1kVldpbEVO?=
 =?utf-8?B?b0ZuMG51SUpQWXVZQnJ4ODk3OHRnT1BYdm1aVEpJbTFIQzFUUmdnUVBkWSt5?=
 =?utf-8?B?WnBYVk5UOHlvcG82WHpWWkd3bTNkSjQyYWR6WmpNWHd5NmRCbEtXeFlKRHdT?=
 =?utf-8?B?dDRPcXRRWS90RHhIbWc0MEJzK0ttMExQSnM2UllySEordmtsQzkvb3J4SmNt?=
 =?utf-8?B?OExVOE5hSVZLWllRRmJ0eXFMWURVb2d1Rjl4RHAyRG4zMUVvM3lqclZDMzhK?=
 =?utf-8?B?UjdLWFFCRDRvUEhadW1IMTkxaDM3d2ljb1VyWlI4MFBsUUJsMWFTMDdiNWdj?=
 =?utf-8?B?R090QTNiVjZvMlpkeWc1YmZWVDJpRFM3RS92RFk2UEhpZEJzWUVRdUJUSzZG?=
 =?utf-8?B?N3JiTVVWOUpOTHl5ZWIySGYybUJYbDRtbzBqRTdNSVNnMThWd1VQU256Um5Z?=
 =?utf-8?B?ZzgwSEJaNHlyNC9aazgxZUJPLzQ1VHlkTzlXeXFBRE0yRUFMWm40TEpCV05C?=
 =?utf-8?B?ZzI4N3J5RUdQZjc3dFdWanArYks0VFZoaFVlTVVJb2piZ2Z1NS9NdVduZ2pG?=
 =?utf-8?B?aS83UDdKZGZRWjBjbzBESTk4TjZQWlBTdU4vekhodWM0Qy9CaTlyOTBIalZy?=
 =?utf-8?B?UWtWL1R1TzhEMXdrckVNWXB1bTZTY0NUZmhITmJtWmdmd2ljZlpBVnZlNVAr?=
 =?utf-8?Q?8X/clxr3kcZVFqiZEIdC0q8bR?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 36e521ff-6be9-4fb1-b6c2-08dc8bd1c0cb
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2024 17:53:38.1108
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gJkke4na2tpracenPjU+OiRxC7VIKcmuOdue/IgBs/pXm/kVtJ8L+YnksNxIWPCSz1Tg0qL3HCf3jLzU8hV9ig==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7690

On 6/13/2024 02:25, Perry Yuan wrote:
> Updates the documentation in `amd-pstate.rst` to include information about the
> per CPU boost control feature. Users can now enable or disable the Core Performance
> Boost (CPB) feature on individual CPUs using the `boost` sysfs attribute.
> 
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>

Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>

> ---
>   Documentation/admin-guide/pm/amd-pstate.rst | 20 ++++++++++++++++++++
>   1 file changed, 20 insertions(+)
> 
> diff --git a/Documentation/admin-guide/pm/amd-pstate.rst b/Documentation/admin-guide/pm/amd-pstate.rst
> index bcc0d9404c18..98e43c53c387 100644
> --- a/Documentation/admin-guide/pm/amd-pstate.rst
> +++ b/Documentation/admin-guide/pm/amd-pstate.rst
> @@ -281,6 +281,26 @@ integer values defined between 0 to 255 when EPP feature is enabled by platform
>   firmware, if EPP feature is disabled, driver will ignore the written value
>   This attribute is read-write.
>   
> +``boost``
> +The `boost` sysfs attribute provides control over the CPU core
> +performance boost, allowing users to manage the maximum frequency limitation
> +of the CPU. This attribute can be used to enable or disable the boost feature
> +on individual CPUs.
> +
> +When the boost feature is enabled, the CPU can dynamically increase its frequency
> +beyond the base frequency, providing enhanced performance for demanding workloads.
> +On the other hand, disabling the boost feature restricts the CPU to operate at the
> +base frequency, which may be desirable in certain scenarios to prioritize power
> +efficiency or manage temperature.
> +
> +To manipulate the `boost` attribute, users can write a value of `0` to disable the
> +boost or `1` to enable it, for the respective CPU using the sysfs path
> +`/sys/devices/system/cpu/cpuX/cpufreq/boost`, where `X` represents the CPU number.
> +
> +It is important to note that modifying the global variable
> +`amd_pstate_global_params.cpb_boost` will override the individual CPU settings.
> +
> +
>   Other performance and frequency values can be read back from
>   ``/sys/devices/system/cpu/cpuX/acpi_cppc/``, see :ref:`cppc_sysfs`.
>