Received-SPF: pass (google.com: domain of linux-kernel+bounces-213780-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <c6b2fb16-bdb5-4c53-8fee-a031be1b298b@amd.com>
Date: Thu, 13 Jun 2024 12:55:17 -0500
User-Agent: Mozilla Thunderbird
From: Mario Limonciello <mario.limonciello@amd.com>
Subject: Re: [PATCH v11 4/9] cpufreq: amd-pstate: initialize new core
 precision boost state
To: Perry Yuan <perry.yuan@amd.com>, gautham.shenoy@amd.com,
 Borislav.Petkov@amd.com
Cc: rafael.j.wysocki@intel.com, viresh.kumar@linaro.org,
 Alexander.Deucher@amd.com, Xinmei.Huang@amd.com, Xiaojian.Du@amd.com,
 Li.Meng@amd.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <cover.1718262992.git.perry.yuan@amd.com>
 <b5faa3f5e27a5991402c356f8dfb8299aaf03a09.1718262992.git.perry.yuan@amd.com>
Content-Language: en-US
In-Reply-To: <b5faa3f5e27a5991402c356f8dfb8299aaf03a09.1718262992.git.perry.yuan@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dlF3RUE5K0UzaU9IMllkSG5RaWVmS3VtWmZjaStZcWRGNG9IcDJWeG9pUDNp?=
 =?utf-8?B?R05PNHM0ZnNZQnplbmlLM0J6V3AydlF3ZkVsZjQxZHJaSWRRalJDVWVVYUhD?=
 =?utf-8?B?TThZZnlJYTBOa1FicWVIbjd1UTUrU3JXYzF2WDBqYUV6VXBnVDlFTVZYVUJt?=
 =?utf-8?B?ZGlnY0V4eUNWdUhycWtJS0wvNnRtUXArZTJxYlJzcHduelBXVzFXTXZDSm52?=
 =?utf-8?B?dDZwcFo0RVRtVG5FcHVmMnZPRFUzQTJGZmxGYU4wRVhncno3MCthNG1vRHgw?=
 =?utf-8?B?U3pYdFhybldzMTF2T2NWdHJKSUpuRWZPajVWUFNhdkxRcUhGM1pNS1llM09K?=
 =?utf-8?B?SFh0TTgxQjNuek1FaERRTzF5L3JnTFo1Ukt1TitXU21mbXhCMXRmYmdtV3c4?=
 =?utf-8?B?THJwZ3RrcVZlb2xuK25ORy9ITERGejhLNHpOUGt3Tkx1MHFNbzlXWU95Tlhu?=
 =?utf-8?B?QmdSZmR6eHV1NlZzeXZwOEJmN2lUUkFFTFlQN3JSaUNjcXdXUmp3bWJNTTZR?=
 =?utf-8?B?dWpBVEU1ZmdIRk5EQXlXYmFKZGI5UmZlSWprU2ViUDRoRkxXUjhZYWdOd29q?=
 =?utf-8?B?eSt0d3p4Yk0wQjJMcmp4YW93b3hsSFNWZnJldTVqNFhXN09udWtEY0dneEt2?=
 =?utf-8?B?S243SXJ3UFUrQzVWWDU5RG83TUZ0dUt2LzdQYXJ2Y1V2T1lTQko3ODQ3V3J2?=
 =?utf-8?B?LzJ0MVdMRllkWXFpZDVkZU9qeEN6N1ozZTR2R2NyOFoyUU5QRkU2dkNUWVRO?=
 =?utf-8?B?am1xbnFMTTRBb3BZZFRmWmJmK1NaWGVuOTQ4LzYyU1RjR3ZSQlV3a1RkekRM?=
 =?utf-8?B?c2UxZE9XMm9Lektyczc0TXVDSG5iU1hxMGRrMW05bzhnZFI1WTl5WjJyMGd3?=
 =?utf-8?B?U1dsNVVJTjY1cmloMVNRWW15M2hQV0VybHdkRkdGejJSOFM2a3JwUDdnbmh2?=
 =?utf-8?B?UHllNkFKZjlpK2VhRHVMcEo2UnJ1YnNNdXdOakVYcis3d3RyTEIrTkZ6V2Jw?=
 =?utf-8?B?S3lncTc5M3VTdk91Nm8yOFJuSDNJc2x0elZyeDNPc2hkM2RON1p0UDlXWmht?=
 =?utf-8?B?OG42U05adTIyeWg1dmdjUE5obHJuakJkYVFGb2w4RVBhN0RYeHJZbGh6eEhN?=
 =?utf-8?B?clhSNzdTZVAyWHBXb0tuUHlNMERPLys5UENlY0pkNnNUNTAwb1dZdEpLaEI1?=
 =?utf-8?B?M2hGS21kVFV1QnN5ejNWcU5GdHVMSVlYZzVoRzNDZHVjZHRjdXMwQzVaSUtZ?=
 =?utf-8?B?NHJzVk5VanRhak1tNGV4ckF5dE1uemFUTnZOcTBXd2szTklQcitWa0tCcXJo?=
 =?utf-8?B?SU5PRlNsYVBpNFluc0pVZkJ5T0QyOWhySEU5OWVhZXlrYitDZnVXNTJnUmlQ?=
 =?utf-8?B?OC9KNjF1QzVXbG4yazhmVUFJMHdkeUVLdUNUbjVIL3djTzJWZ2YrMkVrSUhW?=
 =?utf-8?B?Y2w4eTlzWUIwT25zTnZId2h0eituRlVrT1A2UHNKTU5hTkNGcGQ2OWtNOEFL?=
 =?utf-8?B?cVBqbkpva0lGdXl1WFZyZ3pZS1oxbVZqMDV4WHdOSE9qTUhzbS8waHAycFNY?=
 =?utf-8?B?RHhwSCtTRnptd3A3aGxLZytFSnFUcGxwbk1zcjdiM1hZZG9Ub2tZYy9pcDdC?=
 =?utf-8?B?SGhqMFFBZkdpR0RSMEh3ZXdZTW9oZXNIV1N4aHluVndQaUozR1RaVGtIT0tJ?=
 =?utf-8?B?R09kblZ0MGZZMGtwWk9EcFZzelhPOFlWM2RSS0gxVVpKUDlXSjNIL1NicGhm?=
 =?utf-8?B?QW4wTlVQMVQvV0FuR2wrZy9nalJhd3YyZmlkZmxlWitWYjdXbUpnVVMwamgx?=
 =?utf-8?B?ME9uWmNXc254aE04SmhIbHB5WDB6VjBqTFZCQnBycDNmNFNCSW91ZzlwUE9l?=
 =?utf-8?B?MXJadnN6SndMWXVFMUZaQ3JoR2VDc2xlbC9ycmt5SUdINWh2WE96Tzl6bW9B?=
 =?utf-8?B?ODQ1dmNUUXN1Vi8wcnpMNEkvSFUwMmRxeVA0U0lMYkNFbE9UejJZT3Y2VDRq?=
 =?utf-8?B?dUxYU0xVWmFJK1R3Qzl2VnZUd3ZKeWRXNEhWTFFxejh1UWxvM0k4amJrdHpk?=
 =?utf-8?B?NGZzUjJlNWFZcVRFaW9YU21vZmN1aXREK3N5UUZlSzdJWENYWmdXZXJFKzBk?=
 =?utf-8?Q?E6f6y334VjQKCUSfUSrvJ65dq?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 28482f2d-5592-4206-993c-08dc8bd1fc80
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2024 17:55:18.1882
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: avka0BuM8LjNdjT1ko75lVzODxZVCY6vIWu49TPCEbyObvT+Tm17/jPEHfl2fhSgxCY3lVAgn9p0xD8NI+pXTw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8074

On 6/13/2024 02:25, Perry Yuan wrote:
> From: Perry Yuan <Perry.Yuan@amd.com>
> 
> Add one global `global_params` to represent CPU Performance Boost(cpb)
> state for cpu frequency scaling, both active and passive modes all can
> support CPU cores frequency boosting control which is based on the BIOS
> setting, while BIOS turn on the "Core Performance Boost", it will
> allow OS control each core highest perf limitation from OS side.
> 
> The active, guided and passive modes of the amd-pstate driver can
> support frequency boost control when the "Core Performance Boost"
> (CPB) feature is enabled in the BIOS.  When enabled in BIOS, the user
> has an option at runtime to allow/disallow the cores from operating in
> the boost frequency range.
> 
> Add an amd_pstate_global_params object to record whether CPB is
> enabled in BIOS, and if it has been activated by the user
> 
> Reported-by: Artem S. Tashkinov" <aros@gmx.com>
> Cc: Oleksandr Natalenko <oleksandr@natalenko.name>
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217931
> Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
> ---
>   drivers/cpufreq/amd-pstate.c | 59 +++++++++++++++++++++++++++++-------
>   drivers/cpufreq/amd-pstate.h | 13 ++++++++
>   2 files changed, 61 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index fda8f86c90e0..9f42524074a9 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -102,6 +102,8 @@ static int cppc_state = AMD_PSTATE_UNDEFINED;
>   static bool cppc_enabled;
>   static bool amd_pstate_prefcore = true;
>   static struct quirk_entry *quirks;
> +struct amd_pstate_global_params amd_pstate_global_params;
> +EXPORT_SYMBOL_GPL(amd_pstate_global_params);
>   
>   /*
>    * AMD Energy Preference Performance (EPP)
> @@ -696,7 +698,7 @@ static int amd_pstate_set_boost(struct cpufreq_policy *policy, int state)
>   
>   	if (!cpudata->boost_supported) {
>   		pr_err("Boost mode is not supported by this processor or SBIOS\n");
> -		return -EINVAL;
> +		return -ENOTSUPP;
>   	}
>   
>   	if (state)
> @@ -714,18 +716,38 @@ static int amd_pstate_set_boost(struct cpufreq_policy *policy, int state)
>   	return 0;
>   }
>   
> -static void amd_pstate_boost_init(struct amd_cpudata *cpudata)
> +static int amd_pstate_boost_set(struct amd_cpudata *cpudata)
>   {
> -	u32 highest_perf, nominal_perf;
> +	u64 boost_val;
> +	int ret = -1;
>   
> -	highest_perf = READ_ONCE(cpudata->highest_perf);
> -	nominal_perf = READ_ONCE(cpudata->nominal_perf);
> +	if (!cpu_feature_enabled(X86_FEATURE_CPB)) {
> +		pr_debug_once("Boost CPB capabilities not present in the processor\n");
> +		ret = -EOPNOTSUPP;
> +		goto exit_err;
> +	}
>   
> -	if (highest_perf <= nominal_perf)
> -		return;
> +	ret = rdmsrl_on_cpu(cpudata->cpu, MSR_K7_HWCR, &boost_val);
> +	if (ret) {
> +		pr_err_once("failed to read initial CPU boost state!\n");
> +		ret = -EIO;
> +		goto exit_err;
> +	}
> +
> +	amd_pstate_global_params.cpb_supported = !(boost_val & MSR_K7_HWCR_CPB_DIS);
> +	if (amd_pstate_global_params.cpb_supported) {
> +		current_pstate_driver->boost_enabled = true;
> +		WRITE_ONCE(cpudata->boost_supported, true);
> +	}
>   
> -	cpudata->boost_supported = true;
> -	current_pstate_driver->boost_enabled = true;
> +	amd_pstate_global_params.cpb_boost = amd_pstate_global_params.cpb_supported;
> +	return 0;
> +
> +exit_err:
> +	WRITE_ONCE(cpudata->boost_supported, false);
> +	current_pstate_driver->boost_enabled = false;
> +	amd_pstate_global_params.cpb_boost = false;
> +	return ret;
>   }
>   
>   static void amd_perf_ctl_reset(unsigned int cpu)
> @@ -1007,7 +1029,6 @@ static int amd_pstate_cpu_init(struct cpufreq_policy *policy)
>   
>   	policy->driver_data = cpudata;
>   
> -	amd_pstate_boost_init(cpudata);
>   	if (!current_pstate_driver->adjust_perf)
>   		current_pstate_driver->adjust_perf = amd_pstate_adjust_perf;
>   
> @@ -1389,6 +1410,21 @@ static bool amd_pstate_acpi_pm_profile_undefined(void)
>   	return false;
>   }
>   
> +static int amd_pstate_init_boost(struct cpufreq_policy *policy)
> +{
> +	struct amd_cpudata *cpudata = policy->driver_data;
> +	int ret;
> +
> +	/* initialize cpu cores boot state */
> +	ret = amd_pstate_boost_set(cpudata);
> +	if (ret)
> +		return ret;
> +
> +	policy->boost_enabled = READ_ONCE(cpudata->boost_supported);

Because of the change I suggested in patch 3/9, I believe you should 
move the check for

if (!cpudata->boost_supported)

from amd_pstate_boost_set() to the beginning of amd_pstate_init_boost().
Something like this:

static int amd_pstate_init_boost(struct cpufreq_policy *policy)
{
	struct amd_cpudata *cpudata = policy->driver_data;
	int ret;

	if (!cpudata->boost_supported) {
		policy->boost_enabled = false;
		return 0;
	}
	ret = amd_pstate_boost_set(cpudata);
	if (ret)
		return ret;

	policy->boost_enabled = true;

	return ret;
}

> +
> +	return 0;
> +}
> +
>   static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy)
>   {
>   	int min_freq, max_freq, nominal_freq, ret;
> @@ -1467,7 +1503,6 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy)
>   			return ret;
>   		WRITE_ONCE(cpudata->cppc_cap1_cached, value);
>   	}
> -	amd_pstate_boost_init(cpudata);
>   
>   	return 0;
>   
> @@ -1706,6 +1741,7 @@ static struct cpufreq_driver amd_pstate_driver = {
>   	.exit		= amd_pstate_cpu_exit,
>   	.suspend	= amd_pstate_cpu_suspend,
>   	.resume		= amd_pstate_cpu_resume,
> +	.init_boost	= amd_pstate_init_boost,
>   	.set_boost	= amd_pstate_set_boost,
>   	.update_limits	= amd_pstate_update_limits,
>   	.name		= "amd-pstate",
> @@ -1723,6 +1759,7 @@ static struct cpufreq_driver amd_pstate_epp_driver = {
>   	.suspend	= amd_pstate_epp_suspend,
>   	.resume		= amd_pstate_epp_resume,
>   	.update_limits	= amd_pstate_update_limits,
> +	.init_boost	= amd_pstate_init_boost,
>   	.name		= "amd-pstate-epp",
>   	.attr		= amd_pstate_epp_attr,
>   };
> diff --git a/drivers/cpufreq/amd-pstate.h b/drivers/cpufreq/amd-pstate.h
> index e6a28e7f4dbf..0b75a6267fca 100644
> --- a/drivers/cpufreq/amd-pstate.h
> +++ b/drivers/cpufreq/amd-pstate.h
> @@ -101,4 +101,17 @@ struct amd_cpudata {
>   	bool	suspended;
>   };
>   
> +/**
> + * struct amd_pstate_global_params - Global parameters, mostly tunable via sysfs.
> + * @cpb_boost:		Whether or not to use boost CPU P-states.
> + * @cpb_supported:	Whether or not CPU boost P-states are available
> + *			based on the MSR_K7_HWCR bit[25] state
> + */
> +struct amd_pstate_global_params {
> +	bool cpb_boost;
> +	bool cpb_supported;
> +};
> +
> +extern struct amd_pstate_global_params amd_pstate_global_params;
> +
>   #endif /* _LINUX_AMD_PSTATE_H */