Received-SPF: pass (google.com: domain of linux-kernel+bounces-213783-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <cb824650-1d89-4573-b0b2-067a80b9019f@amd.com>
Date: Thu, 13 Jun 2024 12:55:24 -0500
User-Agent: Mozilla Thunderbird
From: Mario Limonciello <mario.limonciello@amd.com>
Subject: Re: [PATCH v11 2/9] cpufreq: simplify boolean parsing with kstrtobool
 in store function
To: Perry Yuan <perry.yuan@amd.com>, gautham.shenoy@amd.com,
 Borislav.Petkov@amd.com
Cc: rafael.j.wysocki@intel.com, viresh.kumar@linaro.org,
 Alexander.Deucher@amd.com, Xinmei.Huang@amd.com, Xiaojian.Du@amd.com,
 Li.Meng@amd.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <cover.1718262992.git.perry.yuan@amd.com>
 <490341a4cec543fb95aad76b257a2bee525c515c.1718262992.git.perry.yuan@amd.com>
Content-Language: en-US
In-Reply-To: <490341a4cec543fb95aad76b257a2bee525c515c.1718262992.git.perry.yuan@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MGFldm52VW5wMGNvdVJEU1dGQ3o0WTUvVzlpYnF6bklxRVN5d2loYXQ2Ymdr?=
 =?utf-8?B?ZTk3bjczMGgrcng4aElFa1FJemZxdjh5ditHUDB3SlRseCt1V2VGL1dTQjdD?=
 =?utf-8?B?UURtaytKQk52SHZ5TUVGcGtkM0pwMVZjOEI0MUNMbXFkWEtYOGFXb0RGTnFV?=
 =?utf-8?B?dnh4eE5lSzNXa1BlU1Bhck5iS2M1WW1xbjZCVDNJc0YvVGlrd2Fad3NseTU1?=
 =?utf-8?B?eXJJZGlabzVCd3d1VU5CUG9FWWdmSDgwUDJZZGI4Y21tZGdoVjJkQ0NrRnM3?=
 =?utf-8?B?R2s5b2xNai9xaXJmYy8zRlJER1hXQTB3eFJJVG5pNS9tdFZGRjR3YUo2eTJ2?=
 =?utf-8?B?dkRteXpaajkraTlySjlXblArdmlCdUR0dWhzSFh0QlVLWk1CdGRvRWZJY2dF?=
 =?utf-8?B?NFh4UU40a2J3dFJOU0pHdlQ3Q3M0ZE03NEtwajE0eVVzcHV3Yk1CemNIOFZl?=
 =?utf-8?B?YnlveHhuZDFEMzRFcTdTQi9ZaXgxU2praVNCR3lwOWlmODJROXJMaUpvYmRD?=
 =?utf-8?B?VURiMC84VHAwOE1BYmRwd2VicmtDeUtwYzRGN2xDSFlmL0RvUUliWDZ2MDYy?=
 =?utf-8?B?Z0M4Y1RrUUY5cXEycHJ5WDBzQU9FdUtybTFGTXJxeEYzNmh2azV4Z3Y2eExl?=
 =?utf-8?B?RnBPaFM3VDh5RmgyL1JwcTJHUHpWU0tUNXl1THpEWS9pTTRqNUs5bmppWFkx?=
 =?utf-8?B?cE5tSVVReG1NcE1PZ0FZa3VlMDVPT1MyWEc3LzJXZjhWREhWeFlkSUJ3UERB?=
 =?utf-8?B?VG5lUTA0NTNWbC96dkV0V1NuNEVnQ2JjR2NmNVdQVXdUUml3U2U2aGpVV0Rt?=
 =?utf-8?B?aVI3NEJDRVE4azZ6dThZZzltditjY2xCeVU4Tk5ESkl6dDF6OTBFZS9jMHpi?=
 =?utf-8?B?c3pPTDlMb3VHOWxzRWdIeGFyYmljRFhuaXpqL0FIZ2FRTEsrRVN6SG5hR2Zt?=
 =?utf-8?B?V2JjWlIySjNHRmR6eXg0RkJYSWpMV2Vsb0dCWmREeENvRkVjTnZvbjJ2M1JD?=
 =?utf-8?B?Q20rZDEyei9KWXNVKzljeDZFV0lTUmtQU3pTSkVzWVpTZm4vdDkyK2YwVURQ?=
 =?utf-8?B?UmlMWHZuTXdLZG1oRUt5WGk0UWdFRzhPTWVZWXh0NTNzRGUzMHpvcWtUWlU5?=
 =?utf-8?B?U3BCZ1lVbThiUEIxSHlFaE50b2V1UEdNaWVaNkozRVhoandoaWlERlRsK2ha?=
 =?utf-8?B?SmRBZUdvbVRLVGl3ZEs0d0FGVkV6alU1NEJpYnRucXhuaGpHK0ZsQmZIYVZ4?=
 =?utf-8?B?c0RvTTJWS012NzRPeVM4U3BJeXFTTHhueHM2RTBLdFFCY2FpUmZCT29qSEJL?=
 =?utf-8?B?WGR6M2NlVlBKbFcyWnZHNndSeEQ3c2JydnluTFF4cEpRQlgyelQzTjFvN1Vp?=
 =?utf-8?B?QzEvY2g1c3l6ZUdjUEF5Nk53cEVSQWd0Qi9HRG9yYXlQeWkxK3RKVlptYXBE?=
 =?utf-8?B?em90RFZlblAraXA3dnhGTldKRENVZm9yNVNwb0RFcW8wRzJ0M0NnZm5aalA2?=
 =?utf-8?B?aXJEc2ZUaTFBeDFxS2VqNWU1eWkzRmFSdlZFV2pOTzBEOHVTY3ZkS2dlV3l4?=
 =?utf-8?B?N3B6RGlPU2N2b3pCci9RbEJPMW9HUHVyaG5Fc3Z2L0UvTFBzSmVxWWh6NFFY?=
 =?utf-8?B?Nk0wTGoxeDF0ZXFOYXNja3F3VDFnSnc0L2tabGhROC9qSTJMR0xkRCt4ZFY5?=
 =?utf-8?B?cWxEL0JtZVdzY1NsUXFUZGRhL3JSQ1FsUVJoMzIwSm5BbzVZYldmZ1RDNW54?=
 =?utf-8?B?RmIrd0ZCUmNFNzB5R1ZkcG1Wa0pQbklyWFBPa1dIbXB1VCtpczRKb0RkdGVs?=
 =?utf-8?B?UGFteURWcVdwSXlRbk1TOHdPOE91L1JJeHUvWnFtOEJraGNMTGMyN2xndk5T?=
 =?utf-8?B?amY2b1NiM3A4L2tycmJPT28yZ0EzVkJ4OEdzSEVBNTY4OFk0VC9SOWxObnBW?=
 =?utf-8?B?ME9xTlpxbjVLdVZ2SkZXS0J6NUc2WXFJZVlHYkpPam5halhhQ2FrN3k2RmRK?=
 =?utf-8?B?eEdKVW5hajAyU0tVdkRzOGFKOURIQm05RlkyZld1YlJxa0xBQ1NDOUpZZUJx?=
 =?utf-8?B?elBZczJReGswdHRCNkNNcDhzQ210R3NOUUZFTWUzZllmMjRKT1lKQkRaVFEw?=
 =?utf-8?Q?9kI+gEqlyhP53OsObf+noejxS?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 82e43c57-9817-476d-aae7-08dc8bd200fa
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2024 17:55:25.7144
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: REQAXOIHRIkR1KZFc5j0MfpT1nOXz8jweTPlze8pkxmiKxz/OHx0mGjXKJ/8THpgSb5LYFjpPH4459tIqGcBRA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8074

On 6/13/2024 02:25, Perry Yuan wrote:
> Update the cpufreq store function to use kstrtobool for parsing boolean
> values. This simplifies the code and improves readability by using a
> standard kernel function for boolean string conversion.
> 
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>

Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>

> ---
>   drivers/cpufreq/cpufreq.c | 11 +++++------
>   1 file changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index a45aac17c20f..1fdabb660231 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -614,10 +614,9 @@ static ssize_t show_boost(struct kobject *kobj,
>   static ssize_t store_boost(struct kobject *kobj, struct kobj_attribute *attr,
>   			   const char *buf, size_t count)
>   {
> -	int ret, enable;
> +	bool enable;
>   
> -	ret = sscanf(buf, "%d", &enable);
> -	if (ret != 1 || enable < 0 || enable > 1)
> +	if (kstrtobool(buf, &enable))
>   		return -EINVAL;
>   
>   	if (cpufreq_boost_trigger_state(enable)) {
> @@ -641,10 +640,10 @@ static ssize_t show_local_boost(struct cpufreq_policy *policy, char *buf)
>   static ssize_t store_local_boost(struct cpufreq_policy *policy,
>   				 const char *buf, size_t count)
>   {
> -	int ret, enable;
> +	int ret;
> +	bool enable;
>   
> -	ret = kstrtoint(buf, 10, &enable);
> -	if (ret || enable < 0 || enable > 1)
> +	if (kstrtobool(buf, &enable))
>   		return -EINVAL;
>   
>   	if (!cpufreq_driver->boost_enabled)