Received-SPF: pass (google.com: domain of linux-kernel+bounces-213788-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 13 Jun 2024 11:59:46 -0600
From: Rob Herring <robh@kernel.org>
To: Potin Lai <potin.lai.pt@gmail.com>
Cc: Corey Minyard <minyard@acm.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Quan Nguyen <quan@os.amperecomputing.com>,
	openipmi-developer@lists.sourceforge.net,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Patrick Williams <patrick@stwcx.xyz>,
	Cosmo Chou <cosmo.chou@quantatw.com>,
	Potin Lai <potin.lai@quantatw.com>
Subject: Re: [PATCH 1/2] bindings: ipmi: Add property for skipping SBMR boot
 progress response
Message-ID: <20240613175946.GA2085029-robh@kernel.org>
References: <20240612043255.1849007-1-potin.lai.pt@gmail.com>
 <20240612043255.1849007-2-potin.lai.pt@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240612043255.1849007-2-potin.lai.pt@gmail.com>

On Wed, Jun 12, 2024 at 12:32:54PM +0800, Potin Lai wrote:
> In ARM Server Base Manageability Requirements (SBMR) document, Callers can
> choose to not read back Response Data after sending the command "Send Boot
> Progress Code".

Got a link to that document?

> Define "arm-sbmr,skip-bootprogress-response" property for skipping the
> response of "Send Boot Progress Code" from userspace.

I don't understand why this would be conditional? How can you define in 
the BMC what the host behavior is? Doesn't the host side decide 
that? So don't you always have to support no response?

> 
> Signed-off-by: Potin Lai <potin.lai.pt@gmail.com>
> ---
>  Documentation/devicetree/bindings/ipmi/ssif-bmc.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/ipmi/ssif-bmc.yaml b/Documentation/devicetree/bindings/ipmi/ssif-bmc.yaml
> index 02b662d780bbb..b21e958efc184 100644
> --- a/Documentation/devicetree/bindings/ipmi/ssif-bmc.yaml
> +++ b/Documentation/devicetree/bindings/ipmi/ssif-bmc.yaml
> @@ -19,6 +19,11 @@ properties:
>    reg:
>      maxItems: 1
>  
> +  arm-sbmr,skip-bootprogress-response:

Form is vendor,property-name where vendor is defined in 
vendor-prefixes.yaml. 'arm-sbmr' is not a vendor.

> +    type: boolean
> +    description:
> +      Skipping ARM SBMR “Send Boot Progress Code” response.
> +
>  required:
>    - compatible
>    - reg
> -- 
> 2.31.1
>