Received: by 2002:a89:413:0:b0:1fd:dba5:e537 with SMTP id m19csp331242lqs; Thu, 13 Jun 2024 11:13:03 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVzGG4e4J+JFqCFABbFvVVMiB8LFQVkjFMWSkmloX4B0IXx3jM+Y8rJxOcwsoG6cCgnX5Us/BAzxgmMO0mD9BMk0MPYjwnZvPtZ7QqBIg== X-Google-Smtp-Source: AGHT+IEyEsYoVdE/30tDBmQHCQw+xKBMt0hmfJ9LtXUQmzCtszbYtXFXfjJ5I9eXkp0JrNbUfzh5 X-Received: by 2002:a17:906:a2c4:b0:a6f:1d44:577e with SMTP id a640c23a62f3a-a6f60de0daemr35821866b.63.1718302383446; Thu, 13 Jun 2024 11:13:03 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718302383; cv=pass; d=google.com; s=arc-20160816; b=Q1eZrtshDWxwaKJ+OuFvq+aK9JwMJ77wWkD5VgfATYH5XgT/huJG5gF9pHgg5JZUXx ARPALaXRdRvBJJ8ifHZut/CBnKMH6FLSG/f4A/3VdmjayVxC9kS5H+PSXhEn8yUHqJ33 ntU6l1YWrZSgaMmWm+TVyLwu1nBYrMUw+M6P7I4CKbPu9sAPzzaPh7ZnsbCETfVS8o5W 7Gxq1i4f70ViqJfMEppzAfC5SDJi9saLc8ABkeQrsVG23fr0601aexgthNAlRjTl/FNI sBeZwEPdL5BpkWFYHGij+vMn1m1K4fDLqbn+itMvnnBc9y2vNXrTC+18GSErJIioEmIJ rO1w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=yzkTNbdD0a2c3NKP5uSb0sKP6o4WHMSdtJob2Y7Lf9Y=; fh=Klt/jT7Pwb18i0ge/DHE8h2I+jBrCY0I584QCQGMvR0=; b=I6A9wCycOu0E0XimpAugkq/M6xOeNt3lpiSA8Z/3lljrqznWqTNdCLiYTCYSEscyWD 1FkdTEV2UYkSZeCfXEKwZ7PhOoVJlJ/mrFxUJi52ZmRLEiYhrq70Vhjk+YTj9KJL+EuE 3DT97blGs66GNw35WJPLhCcztWpFo0trlRExh/frxoT5w8qfBeowepmcPmS5I85Ure4q /kBkxaropr7LNSDZYPJBEKOrMb3F+n32EBERusGQ/OkC5cwKu6jk2qrm+GbLvnhL6X5z O6sxU1rTZ8v16OsMmk5y9rhz1Y6xJhKWp8IdpfaR/TjhZjILdnQRRxUxLHqKltF8Py0H JkrQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=ERvfPeDP; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-213594-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-213594-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id a640c23a62f3a-a6f56d2138asi97389266b.42.2024.06.13.11.13.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jun 2024 11:13:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-213594-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=ERvfPeDP; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-213594-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-213594-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id EA1BE1F24AAD for ; Thu, 13 Jun 2024 15:47:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8408915ADB7; Thu, 13 Jun 2024 15:40:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="ERvfPeDP" Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E21614198E; Thu, 13 Jun 2024 15:40:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718293244; cv=none; b=WPGW7YT4TVM3fRcih2Jn5yS7D9uECaOAyWIRNs2fMquz9fmgam9qAiOc6tj5mNsrvgcwKlP80wmmlNonsYhbk8/aYM6BU2mRSgJX5itCPhdmFYwupb9xcTL18BHfcSSelK3EdocqUpHtXzcN0Q55Me1157B34xavcSLT+n+jJlE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718293244; c=relaxed/simple; bh=N+sDX7ZbU5QCuJT6w9YMdnRaDrdkZf5y5viAAmIsDG4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mAPN0fhNG/U2WIQWOwP/SKv2yuhXuRC5KV/AeLzX+KKGDNWPxWHvcFY0QhQ8AvpftHbYV5ASR6HR0ExkFJg5TGZVM38t+laPyoaDh29MOxtFyluSYIMUteD4IgvzMOeGD/wRLC4JRZp0Uw0uqtJ05enr2qFFSAyeyVgtosVeecs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=ERvfPeDP; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=yzkTNbdD0a2c3NKP5uSb0sKP6o4WHMSdtJob2Y7Lf9Y=; b=ERvfPeDPd5l14AF4yJ+ldt9Nxz 7bS1JZiLy38Xf8wDo1A0V82qM67Vcpl4Hd18YEIdOpUE2l68glcOxjLeR/M86injkZp45uVvSyGwB 7Ag/sfbWYK4LDA+e6kncbnlWIOp5gMidKClL5x4raeJIt40QGuz0wb8qQx/slJbGswml3lq/zlmQX B13i8h5Xj460i6GnPDJUEGQ8RtYJVZP5fPBsBjxRS0nQ5SkIRy8Pi/WcHqAn9a5oXDNjfmapzJ/Lt C/i9zs92LoKtssDB0DvCPnBXCIbOZKLAHY2YqGxy9Gwk4NKmxB+PiaqN6Rqo1yofXq7sFl8G/2p0e +8LPn/RA==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHmYu-0000000Furm-1Tae; Thu, 13 Jun 2024 15:40:28 +0000 Date: Thu, 13 Jun 2024 16:40:28 +0100 From: Matthew Wilcox To: Luis Chamberlain Cc: David Hildenbrand , Hugh Dickins , yang@os.amperecomputing.com, linmiaohe@huawei.com, muchun.song@linux.dev, osalvador@suse.de, "Pankaj Raghav (Samsung)" , david@fromorbit.com, djwong@kernel.org, chandan.babu@oracle.com, brauner@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, hare@suse.de, linux-kernel@vger.kernel.org, Zi Yan , linux-xfs@vger.kernel.org, p.raghav@samsung.com, linux-fsdevel@vger.kernel.org, hch@lst.de, gost.dev@samsung.com, cl@os.amperecomputing.com, john.g.garry@oracle.com Subject: Re: [PATCH v7 06/11] filemap: cap PTE range to be created to allowed zero fill in folio_map_range() Message-ID: References: <20240607145902.1137853-1-kernel@pankajraghav.com> <20240607145902.1137853-7-kernel@pankajraghav.com> <818f69fa-9dc7-4ca0-b3ab-a667cd1fb16d@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Jun 13, 2024 at 08:38:15AM -0700, Luis Chamberlain wrote: > On Thu, Jun 13, 2024 at 04:32:27PM +0100, Matthew Wilcox wrote: > > On Thu, Jun 13, 2024 at 08:27:27AM -0700, Luis Chamberlain wrote: > > > The case I tested that failed the test was tmpfs with huge pages (not > > > large folios). So should we then have this: > > > > No. > > OK so this does have a change for tmpfs with huge pages enabled, do we > take the position then this is a fix for that? You literally said it was a fix just a few messages up thread? Besides, the behaviour changes (currently) depending on whether you specify "within_size" or "always". This patch makes it consistent.