Received-SPF: pass (google.com: domain of linux-kernel+bounces-213868-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 13 Jun 2024 12:56:43 -0600
From: Rob Herring <robh@kernel.org>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: Lee Jones <lee@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Paul Burton <paulburton@kernel.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mips@vger.kernel.org
Subject: Re: [PATCH v2 8/8] dt-bindings: mips: img: Add devices binding
Message-ID: <20240613185643.GA2286020-robh@kernel.org>
References: <20240612-boston-syscon-v2-0-9f8e1a07fa63@flygoat.com>
 <20240612-boston-syscon-v2-8-9f8e1a07fa63@flygoat.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240612-boston-syscon-v2-8-9f8e1a07fa63@flygoat.com>

On Wed, Jun 12, 2024 at 12:56:27PM +0100, Jiaxun Yang wrote:
> Add devices binding for various Imagination Technologies
> MIPS based Platforms.
> 
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> ---
>  .../devicetree/bindings/mips/img/devices.yaml      | 33 ++++++++++++++++++++++
>  1 file changed, 33 insertions(+)

Please drop the old bindings or at least the portion covered by 
this. That's 
Documentation/devicetree/bindings/mips/img/pistachio-marduk.txt, 
pistachio.txt, and xilfpga.txt. 

Some of the description can go in here. CPU nodes are documented 
elsewhere by schemas already and can be dropped. The boot protocol isn't 
really DT bindings, so that belongs elsewhere if you want to keep it. 
Documentation/arch/mips/ perhaps?

Rob