Received-SPF: pass (google.com: domain of linux-kernel+bounces-213927-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Feedback-ID: ifd894703:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-515-g87b2bad5a-fm-20240604.001-g87b2bad5
Precedence: bulk
MIME-Version: 1.0
Message-Id: <bbbd52c2-aaf2-4777-bee4-855d805923b5@app.fastmail.com>
In-Reply-To: <20240613190429.GA2309072-robh@kernel.org>
References: <20240612-boston-syscon-v2-0-9f8e1a07fa63@flygoat.com>
 <20240612-boston-syscon-v2-6-9f8e1a07fa63@flygoat.com>
 <20240613190429.GA2309072-robh@kernel.org>
Date: Thu, 13 Jun 2024 20:31:46 +0100
From: "Jiaxun Yang" <jiaxun.yang@flygoat.com>
To: "Rob Herring" <robh@kernel.org>
Cc: "Lee Jones" <lee@kernel.org>, "Krzysztof Kozlowski" <krzk+dt@kernel.org>,
 "Conor Dooley" <conor+dt@kernel.org>,
 "paulburton@kernel.org" <paulburton@kernel.org>,
 "Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
 "linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>
Subject: Re: [PATCH v2 6/8] dt-bindings: mfd: Add img,boston-platform-regs
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable


=E5=9C=A82024=E5=B9=B46=E6=9C=8813=E6=97=A5=E5=85=AD=E6=9C=88 =E4=B8=8B=E5=
=8D=888:04=EF=BC=8CRob Herring=E5=86=99=E9=81=93=EF=BC=9A
> On Wed, Jun 12, 2024 at 12:56:25PM +0100, Jiaxun Yang wrote:
>> This compatible has been used in arch/mips/boot/dts/img/boston.dts
>> for a while but never documented properly.
>>=20
>> Write a new binding for this device.
>> This also covers old img,boston-clock binding so remove that binding.
>>=20
>> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
>> ---
>>  .../devicetree/bindings/clock/img,boston-clock.txt | 31 ---------
>>  .../bindings/mfd/img,boston-platform-regs.yaml     | 74 ++++++++++++=
++++++++++
>>  2 files changed, 74 insertions(+), 31 deletions(-)
>>=20
>> diff --git a/Documentation/devicetree/bindings/clock/img,boston-clock=
.txt b/Documentation/devicetree/bindings/clock/img,boston-clock.txt
>> deleted file mode 100644
>> index 7bc5e9ffb624..000000000000
>> --- a/Documentation/devicetree/bindings/clock/img,boston-clock.txt
>> +++ /dev/null
>> @@ -1,31 +0,0 @@
>> -Binding for Imagination Technologies MIPS Boston clock sources.
>> -
>> -This binding uses the common clock binding[1].
>> -
>> -[1] Documentation/devicetree/bindings/clock/clock-bindings.txt
>> -
>> -The device node must be a child node of the syscon node correspondin=
g to the
>> -Boston system's platform registers.
>> -
>> -Required properties:
>> -- compatible : Should be "img,boston-clock".
>> -- #clock-cells : Should be set to 1.
>> -  Values available for clock consumers can be found in the header fi=
le:
>> -    <dt-bindings/clock/boston-clock.h>
>> -
>> -Example:
>> -
>> -	system-controller@17ffd000 {
>> -		compatible =3D "img,boston-platform-regs", "syscon";
>> -		reg =3D <0x17ffd000 0x1000>;
>> -
>> -		clk_boston: clock {
>> -			compatible =3D "img,boston-clock";
>> -			#clock-cells =3D <1>;
>> -		};
>> -	};
>> -
>> -	uart0: uart@17ffe000 {
>> -		/* ... */
>> -		clocks =3D <&clk_boston BOSTON_CLK_SYS>;
>> -	};
>> diff --git a/Documentation/devicetree/bindings/mfd/img,boston-platfor=
m-regs.yaml b/Documentation/devicetree/bindings/mfd/img,boston-platform-=
regs.yaml
>> new file mode 100644
>> index 000000000000..bf94de38a89f
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mfd/img,boston-platform-regs.=
yaml
>> @@ -0,0 +1,74 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/mfd/img,boston-platform-regs.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Imagination Technologies Boston Platform Registers
>> +
>> +maintainers:
>> +  - Jiaxun Yang <jiaxun.yang@flygoat.com>
>> +
>> +properties:
>> +  compatible:
>> +    items:
>> +      - const: img,boston-platform-regs
>> +      - const: syscon
>> +      - const: simple-mfd
>
> Why did you add 'simple-mfd'? That's not what is in use.
>

U-Boot needs this to probe sub-nodes such as reboot and clock :-(

I had updated dts in an earlier patch of this series.

Thanks
>>

--=20
- Jiaxun