Received-SPF: pass (google.com: domain of linux-kernel+bounces-213930-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240610-cros_ec-charge-control-v3-0-135e37252094@weissschuh.net> <20240610-cros_ec-charge-control-v3-1-135e37252094@weissschuh.net>
In-Reply-To: <20240610-cros_ec-charge-control-v3-1-135e37252094@weissschuh.net>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Thu, 13 Jun 2024 21:33:56 +0200
Message-ID: <CAJZ5v0iUjvrs+57_meCkK7fcokH0j8sTAG3xXai5av_n5OHJwA@mail.gmail.com>
Subject: Re: [PATCH v3 1/5] ACPI: battery: add devm_battery_hook_register()
To: =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>
Cc: Benson Leung <bleung@chromium.org>, Guenter Roeck <groeck@chromium.org>, 
	Sebastian Reichel <sre@kernel.org>, =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= <thomas@weissschuh.net>, 
	"Rafael J. Wysocki" <rafael@kernel.org>, Len Brown <lenb@kernel.org>, 
	Robert Moore <robert.moore@intel.com>, Tzung-Bi Shih <tzungbi@kernel.org>, 
	chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org, 
	linux-pm@vger.kernel.org, Mario Limonciello <mario.limonciello@amd.com>, 
	Dustin Howett <dustin@howett.net>, Stephen Horvath <s.horvath@outlook.com.au>, 
	Rajas Paranjpe <paranjperajas@gmail.com>, linux-acpi@vger.kernel.org, 
	acpica-devel@lists.linux.dev, Matt Hartley <matt.hartley@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Jun 10, 2024 at 5:52=E2=80=AFPM Thomas Wei=C3=9Fschuh <linux@weisss=
chuh.net> wrote:
>
> Add a utility function for device-managed registration of battery hooks.
> The function makes it easier to manage the lifecycle of a hook.
>
> Signed-off-by: Thomas Wei=C3=9Fschuh <linux@weissschuh.net>

Please feel free to add

Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

to this patch and route it along with the rest of the series as needed.

Thanks!

> ---
>  drivers/acpi/battery.c | 15 +++++++++++++++
>  include/acpi/battery.h |  2 ++
>  2 files changed, 17 insertions(+)
>
> diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c
> index b379401ff1c2..6ea979f76f84 100644
> --- a/drivers/acpi/battery.c
> +++ b/drivers/acpi/battery.c
> @@ -756,6 +756,21 @@ void battery_hook_register(struct acpi_battery_hook =
*hook)
>  }
>  EXPORT_SYMBOL_GPL(battery_hook_register);
>
> +static void devm_battery_hook_unregister(void *data)
> +{
> +       struct acpi_battery_hook *hook =3D data;
> +
> +       battery_hook_unregister(hook);
> +}
> +
> +int devm_battery_hook_register(struct device *dev, struct acpi_battery_h=
ook *hook)
> +{
> +       battery_hook_register(hook);
> +
> +       return devm_add_action_or_reset(dev, devm_battery_hook_unregister=
, hook);
> +}
> +EXPORT_SYMBOL_GPL(devm_battery_hook_register);
> +
>  /*
>   * This function gets called right after the battery sysfs
>   * attributes have been added, so that the drivers that
> diff --git a/include/acpi/battery.h b/include/acpi/battery.h
> index 611a2561a014..c93f16dfb944 100644
> --- a/include/acpi/battery.h
> +++ b/include/acpi/battery.h
> @@ -2,6 +2,7 @@
>  #ifndef __ACPI_BATTERY_H
>  #define __ACPI_BATTERY_H
>
> +#include <linux/device.h>
>  #include <linux/power_supply.h>
>
>  #define ACPI_BATTERY_CLASS "battery"
> @@ -19,5 +20,6 @@ struct acpi_battery_hook {
>
>  void battery_hook_register(struct acpi_battery_hook *hook);
>  void battery_hook_unregister(struct acpi_battery_hook *hook);
> +int devm_battery_hook_register(struct device *dev, struct acpi_battery_h=
ook *hook);
>
>  #endif
>
> --
> 2.45.2
>
>