Received-SPF: pass (google.com: domain of linux-kernel+bounces-213914-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Thu, 13 Jun 2024 22:21:49 +0300
From: Dan Carpenter <dan.carpenter@linaro.org>
To: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Cc: Teddy Engel <engel.teddy@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/6] staging: rtl8192e: Cleanup multiple issues
Message-ID: <c0f2bca8-a7e6-4874-b5fc-98911a7c09d8@moroto.mountain>
References: <cover.1718291024.git.engel.teddy@gmail.com>
 <ee01dbd2-fe83-46cf-9ceb-279a06ce9aad@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ee01dbd2-fe83-46cf-9ceb-279a06ce9aad@gmail.com>

On Thu, Jun 13, 2024 at 09:05:03PM +0200, Philipp Hortmann wrote:
> On 6/13/24 17:16, Teddy Engel wrote:
> > Remove some unused constants, macros, and structs.
> > Capitalize a constant.
> > 
> > No specific patch order required.
> > 
> > Teddy Engel (6):
> >    staging: rtl8192e: Remove unused constant IC_VersionCut_E
> >    staging: rtl8192e: Remove unused struct phy_ofdm_rx_status_rxsc
> >    staging: rtl8192e: Remove unused constant WA_IOT_TH_VAL
> >    staging: rtl8192e: Capitalize constant RegC38_TH
> >    staging: rtl8192e: Remove unused macro dm_tx_bb_gain_idx_to_amplify
> >    staging: rtl8192e: Remove unnecessary pre-declaration of struct
> >      net_device
> > 
> >   drivers/staging/rtl8192e/rtl8192e/r8190P_def.h | 8 --------
> >   drivers/staging/rtl8192e/rtl8192e/rtl_cam.h    | 1 -
> >   drivers/staging/rtl8192e/rtl8192e/rtl_dm.c     | 4 ++--
> >   drivers/staging/rtl8192e/rtl8192e/rtl_dm.h     | 6 +-----
> >   drivers/staging/rtl8192e/rtl8192e/rtl_pci.h    | 1 -
> >   5 files changed, 3 insertions(+), 17 deletions(-)
> > 
> 
> 
> Hi Teddy,
> 
> please combine patch 1 and 3 (Remove unused constant ...) . You can change
> more than one item in a patch. But it has to be of the same kind.
> 

Could you combine that with the earlier patch that deleted
IC_VersionCut_C as well?  (Unless that has already been merged).

regards,
dan carpenter